From: Andrew Morton <akpm@linux-foundation.org>
To: Zhaoyang Huang <huangzhaoyang@gmail.com>
Cc: Chintan Pandya <cpandya@codeaurora.org>,
David Rientjes <rientjes@google.com>,
Joe Perches <joe@perches.com>, Michal Hocko <mhocko@suse.com>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mm:vmalloc add vm_struct for vm_map_ram
Date: Thu, 8 Nov 2018 14:52:39 -0800 [thread overview]
Message-ID: <20181108145239.f8249da5833974bad286fb78@linux-foundation.org> (raw)
In-Reply-To: <1541675689-13363-1-git-send-email-huangzhaoyang@gmail.com>
On Thu, 8 Nov 2018 19:14:49 +0800 Zhaoyang Huang <huangzhaoyang@gmail.com> wrote:
> There is no caller and pages information etc for the area which is
> created by vm_map_ram as well as the page count > VMAP_MAX_ALLOC.
> Add them on in this commit.
Well I can kind of see what this is doing - it increases the amount of
info in /proc/vmallocinfo for regions which were created by
vm_map_area(), yes?
But I'd like to hear it in your words, please. What problem are we
trying to solve? Why is it actually a problem? Why is the additional
information considered useful, etc?
It would help a lot if the changelog were to include before-and-after
examples from the /proc/vmallocinfo output.
Thanks.
next prev parent reply other threads:[~2018-11-08 22:52 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-08 11:14 [PATCH] mm:vmalloc add vm_struct for vm_map_ram Zhaoyang Huang
2018-11-08 22:52 ` Andrew Morton [this message]
2018-11-12 3:24 ` Xishi Qiu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181108145239.f8249da5833974bad286fb78@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=cpandya@codeaurora.org \
--cc=huangzhaoyang@gmail.com \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@suse.com \
--cc=rientjes@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).