From: Peter Zijlstra <peterz@infradead.org>
To: "Paul E. McKenney" <paulmck@linux.ibm.com>
Cc: mingo@redhat.com, linux-kernel@vger.kernel.org
Subject: Re: Question on comment header for for_each_domain()
Date: Thu, 8 Nov 2018 16:35:40 +0100 [thread overview]
Message-ID: <20181108153540.GW9761@hirez.programming.kicks-ass.net> (raw)
In-Reply-To: <20181108153109.GF4170@linux.ibm.com>
On Thu, Nov 08, 2018 at 07:31:09AM -0800, Paul E. McKenney wrote:
> On Thu, Nov 08, 2018 at 10:21:51AM +0100, Peter Zijlstra wrote:
> > On Wed, Nov 07, 2018 at 03:00:02PM -0800, Paul E. McKenney wrote:
> > > Hello!
> > >
> > > The header comment for for_each_domain() talks about a call to
> > > synchronize_sched() within detach_destroy_domains(), but I am not
> > > seeing any such call. Because synchronize_sched() is now folded into
> > > synchronize_rcu(), I have a patch that edits the comment, but it looks
> > > like a larger change is needed.
> > >
> > > Or am I blind today?
> >
> > I think you're quite right and that comment is a wee bit stale.
> >
> > The sched domain tree is indeed protected by regular RCU (not RCU-sched
> > as the comment seems to imply) and this is per destroy_sched_domains()
> > using call_rcu().
> >
> > And most (I didn't look at all) uses for the sched-domain tree do indeed
> > employ rcu_read_lock().
>
> Ah, thank you for the info! Would this patch do the trick?
> diff --git a/kernel/sched/sched.h b/kernel/sched/sched.h
> index 618577fc9aa8..00b91d16af9f 100644
> --- a/kernel/sched/sched.h
> +++ b/kernel/sched/sched.h
> @@ -1237,7 +1237,7 @@ extern void sched_ttwu_pending(void);
>
> /*
> * The domain tree (rq->sd) is protected by RCU's quiescent state transition.
> - * See detach_destroy_domains: synchronize_sched for details.
> + * See destroy_sched_domains: call_rcu for details.
> *
> * The domain tree of any CPU may only be accessed from within
> * preempt-disabled sections.
> diff --git a/kernel/sched/topology.c b/kernel/sched/topology.c
> index 8d7f15ba5916..04d458faf2c1 100644
> --- a/kernel/sched/topology.c
> +++ b/kernel/sched/topology.c
> @@ -248,7 +248,7 @@ void rq_attach_root(struct rq *rq, struct root_domain *rd)
> raw_spin_unlock_irqrestore(&rq->lock, flags);
>
> if (old_rd)
> - call_rcu_sched(&old_rd->rcu, free_rootdomain);
> + call_rcu(&old_rd->rcu, free_rootdomain);
> }
>
> void sched_get_rd(struct root_domain *rd)
> @@ -261,7 +261,7 @@ void sched_put_rd(struct root_domain *rd)
> if (!atomic_dec_and_test(&rd->refcount))
> return;
>
> - call_rcu_sched(&rd->rcu, free_rootdomain);
> + call_rcu(&rd->rcu, free_rootdomain);
> }
>
> static int init_rootdomain(struct root_domain *rd)
>
Argh, that is the rootdomain, not the regular sched-domain tree. Now
I'll have to go audit that stuff again.
ISTR there being slightly different rules for rootdomain, and with a
reason.
Can we hold onto this until after LPC?
next prev parent reply other threads:[~2018-11-08 15:35 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-07 23:00 Question on comment header for for_each_domain() Paul E. McKenney
2018-11-08 9:21 ` Peter Zijlstra
2018-11-08 15:31 ` Paul E. McKenney
2018-11-08 15:35 ` Peter Zijlstra [this message]
2018-11-08 16:11 ` Paul E. McKenney
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181108153540.GW9761@hirez.programming.kicks-ass.net \
--to=peterz@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=paulmck@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).