Re: [PATCH v2] x86/cpu: fix prototype warning

From: Borislav Petkov <bp@alien8.de>
To: Michael Matz <matz@suse.de>
Cc: Yi Wang <wang.yi59@zte.com.cn>,
	tglx@linutronix.de, mingo@redhat.com, hpa@zytor.com,
	x86@kernel.org, suravee.suthikulpanit@amd.com, puwen@hygon.cn,
	davidwang@zhaoxin.com, linux-kernel@vger.kernel.org,
	zhong.weidong@zte.com.cn
Subject: Re: [PATCH v2] x86/cpu: fix prototype warning
Date: Thu, 8 Nov 2018 18:22:25 +0100	[thread overview]
Message-ID: <20181108172225.GH7543@zn.tnic> (raw)
In-Reply-To: <alpine.LSU.2.21.1811081538120.21712@wotan.suse.de>

On Thu, Nov 08, 2018 at 03:47:32PM +0000, Michael Matz wrote:
> What tglx said.  If you don't intend such functions to be called 
> from other units make them static, if you do intend them to be callable 
> declare the properly.
> 
> [There's also one subtle issue with argument promotions.  prototypeless 
> functions are called as if they are declared "int name()" that is 
> default argument promotions take place (float->double, {char,short}->int), 
> which won't happen with prototypes, and argument type conversions won't 
> take place (as no parameter types are known).  This might lead to 
> different values between calling a prototyped and a prototype-less 
> function arriving at the function even though the call expression looked 
> the same]

Eww, that's yucky.

Ok, so we should enalbe this warning by default then. And doing that in
the main Makefile gives ~1400 warnings on an allmodconfig build.

Yi Wang, I guess you have a long road in front of you. :-)

Thx.

-- 
Regards/Gruss,
    Boris.

Good mailing practices for 400: avoid top-posting and trim the reply.