From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.5 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8B15EECDE47 for ; Thu, 8 Nov 2018 17:26:03 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 5E66C20827 for ; Thu, 8 Nov 2018 17:26:03 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 5E66C20827 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=atomide.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727251AbeKIDCb (ORCPT ); Thu, 8 Nov 2018 22:02:31 -0500 Received: from muru.com ([72.249.23.125]:53590 "EHLO muru.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726583AbeKIDCb (ORCPT ); Thu, 8 Nov 2018 22:02:31 -0500 Received: from atomide.com (localhost [127.0.0.1]) by muru.com (Postfix) with ESMTPS id 45078812D; Thu, 8 Nov 2018 17:26:01 +0000 (UTC) Date: Thu, 8 Nov 2018 09:25:58 -0800 From: Tony Lindgren To: Janusz Krzysztofik Cc: Aaro Koskinen , Greg Kroah-Hartman , Jiri Slaby , linux-arm-kernel@lists.infradead.org, linux-omap@vger.kernel.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org Subject: Re: [PATCH] ARM: OMAP1: ams-delta: Fix possible use of uninitialized field Message-ID: <20181108172558.GO56134@atomide.com> References: <20181107213031.21650-1-jmkrzyszt@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20181107213031.21650-1-jmkrzyszt@gmail.com> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org * Janusz Krzysztofik [181107 13:28]: > While playing with initialization order of modem device, it has been > discovered that under some circumstances (early console init, I > believe) its .pm() callback may be called before the > uart_port->private_data pointer is initialized from > plat_serial8250_port->private_data, resulting in NULL pointer > dereference. Fix it by checking for uninitialized pointer before using > it in modem_pm(). Applying into omap-for-v4.20/fixes thanks. Tony