linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Paul Burton <paul.burton@mips.com>
To: Maksym Kokhan <maksym.kokhan@globallogic.com>
Cc: "geert@linux-m68k.org" <geert@linux-m68k.org>,
	"sergei.shtylyov@cogentembedded.com" 
	<sergei.shtylyov@cogentembedded.com>,
	Ralf Baechle <ralf@linux-mips.org>,
	James Hogan <jhogan@kernel.org>,
	Andrii Bordunov <andrew.bordunov@gmail.com>,
	"linux-mips@linux-mips.org" <linux-mips@linux-mips.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] mips: delete duplication of BUILTIN_DTB selection
Date: Thu, 8 Nov 2018 18:30:16 +0000	[thread overview]
Message-ID: <20181108183014.gjzmquibbjvysui7@pburton-laptop> (raw)
In-Reply-To: <CAMT6-xji=XrteXm6KbUYLiKqSH_-RHzXzwn3zi5hYbtq_R_sRg@mail.gmail.com>

Hi Maksym,

On Tue, Nov 06, 2018 at 05:29:40PM +0200, Maksym Kokhan wrote:
> > > > > diff --git a/arch/mips/Kconfig b/arch/mips/Kconfig
> > > > > index 3551199..71d6549 100644
> > > > > --- a/arch/mips/Kconfig
> > > > > +++ b/arch/mips/Kconfig
> > > > > @@ -539,7 +539,6 @@ config MIPS_MALTA
> > > > >       select USE_OF
> > > > >       select LIBFDT
> > > > >       select ZONE_DMA32 if 64BIT
> > > > > -     select BUILTIN_DTB
> > > > >       select LIBFDT
> > > >
> > > >     LIBFDT seems duplicated too.
> > >
> > > Using random sort order doesn't help. Keep them sorted, please?
> >
> > We are going to deal with it in the separate patch.
> 
> Is it OK to leave this patch as it is and make another patch/patches
> for other changes or it would be better to modify it to remove
> duplication of LIBFDT too and sort this list of configs?

My preference would be that you remove all the duplicates as one patch,
then sort the selects alphabetically in a second patch. That should be
granular enough to make it easy to review, but not so fine-grained that
it becomes annoying.

Thanks,
    Paul

      reply	other threads:[~2018-11-08 18:39 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-10-03 17:23 [PATCH] mips: delete duplication of BUILTIN_DTB selection Maksym Kokhan
2018-10-04  8:36 ` Sergei Shtylyov
2018-10-04  9:14   ` Geert Uytterhoeven
2018-10-04 12:06     ` Maksym Kokhan
2018-11-06 15:29       ` Maksym Kokhan
2018-11-08 18:30         ` Paul Burton [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20181108183014.gjzmquibbjvysui7@pburton-laptop \
    --to=paul.burton@mips.com \
    --cc=andrew.bordunov@gmail.com \
    --cc=geert@linux-m68k.org \
    --cc=jhogan@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mips@linux-mips.org \
    --cc=maksym.kokhan@globallogic.com \
    --cc=ralf@linux-mips.org \
    --cc=sergei.shtylyov@cogentembedded.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).