linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Roman Gushchin <guroan@gmail.com>
To: cgroups@vger.kernel.org
Cc: linux-kernel@vger.kernel.org, kernel-team@fb.com,
	Roman Gushchin <guro@fb.com>, Shuah Khan <shuah@kernel.org>,
	Tejun Heo <tj@kernel.org>
Subject: [PATCH 4/5] kselftests: cgroup: don't fail on cg_kill_all() error in cg_destroy()
Date: Thu,  8 Nov 2018 15:15:59 -0500	[thread overview]
Message-ID: <20181108201600.9129-5-guro@fb.com> (raw)
In-Reply-To: <20181108201600.9129-1-guro@fb.com>

If the cgroup destruction races with an exit() of a belonging
process(es), cg_kill_all() may fail. It's not a good reason to make
cg_destroy() fail and leave the cgroup in place, potentially causing
next test runs to fail.

Signed-off-by: Roman Gushchin <guro@fb.com>
Cc: Shuah Khan <shuah@kernel.org>
Cc: Tejun Heo <tj@kernel.org>
Cc: kernel-team@fb.com
---
 tools/testing/selftests/cgroup/cgroup_util.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/tools/testing/selftests/cgroup/cgroup_util.c b/tools/testing/selftests/cgroup/cgroup_util.c
index 14c9fe284806..eba06f94433b 100644
--- a/tools/testing/selftests/cgroup/cgroup_util.c
+++ b/tools/testing/selftests/cgroup/cgroup_util.c
@@ -227,9 +227,7 @@ int cg_destroy(const char *cgroup)
 retry:
 	ret = rmdir(cgroup);
 	if (ret && errno == EBUSY) {
-		ret = cg_killall(cgroup);
-		if (ret)
-			return ret;
+		cg_killall(cgroup);
 		usleep(100);
 		goto retry;
 	}
-- 
2.17.2


  parent reply	other threads:[~2018-11-08 20:16 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-11-08 20:15 [PATCH 0/5] freezer for cgroup v2 Roman Gushchin
2018-11-08 20:15 ` [PATCH 1/5] cgroup: rename freezer.c into legacy_freezer.c Roman Gushchin
2018-11-08 20:15 ` [PATCH 2/5] cgroup: implement __cgroup_task_count() helper Roman Gushchin
2018-11-08 20:15 ` [PATCH 3/5] cgroup: cgroup v2 freezer Roman Gushchin
2018-11-08 20:15 ` Roman Gushchin [this message]
2018-11-08 20:16 ` [PATCH 5/5] kselftests: cgroup: add freezer controller self-tests Roman Gushchin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20181108201600.9129-5-guro@fb.com \
    --to=guroan@gmail.com \
    --cc=cgroups@vger.kernel.org \
    --cc=guro@fb.com \
    --cc=kernel-team@fb.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=shuah@kernel.org \
    --cc=tj@kernel.org \
    --subject='Re: [PATCH 4/5] kselftests: cgroup: don'\''t fail on cg_kill_all() error in cg_destroy()' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
on how to clone and mirror all data and code used for this inbox