From: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
To: Bartosz Golaszewski <brgl@bgdev.pl>
Cc: Bamvor Jian Zhang <bamv2005@gmail.com>,
Linus Walleij <linus.walleij@linaro.org>,
linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/3] gpio: mockup: fix indicated direction
Date: Thu, 8 Nov 2018 21:35:46 +0100 [thread overview]
Message-ID: <20181108203546.54rncnydgamud5z3@pengutronix.de> (raw)
In-Reply-To: <20181108165255.9940-2-brgl@bgdev.pl>
Hello Bartosz,
On Thu, Nov 08, 2018 at 05:52:53PM +0100, Bartosz Golaszewski wrote:
> Commit 3edfb7bd76bd ("gpiolib: Show correct direction from the
> beginning") fixed an existing issue but broke libgpiod tests by
> changing the default direction of dummy lines to output.
The indicated commit only changed what was shown in debugfs, but didn't
touch the actual direction of a GPIO, doesn't it? If someone called
gpiod_get_direction before it would have returned "output", too, unless
I miss something.
Best regards
Uwe
--
Pengutronix e.K. | Uwe Kleine-König |
Industrial Linux Solutions | http://www.pengutronix.de/ |
next prev parent reply other threads:[~2018-11-08 20:35 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-08 16:52 [PATCH 0/3] gpio: mockup: misc updates Bartosz Golaszewski
2018-11-08 16:52 ` [PATCH 1/3] gpio: mockup: fix indicated direction Bartosz Golaszewski
2018-11-08 20:35 ` Uwe Kleine-König [this message]
2018-11-09 11:13 ` Bartosz Golaszewski
2018-11-09 11:54 ` Uwe Kleine-König
2018-11-09 12:24 ` Bartosz Golaszewski
2018-11-09 13:10 ` Uwe Kleine-König
2018-11-09 13:53 ` Bartosz Golaszewski
2018-11-09 14:39 ` Uwe Kleine-König
2018-11-09 15:24 ` Bartosz Golaszewski
2018-11-09 17:03 ` Uwe Kleine-König
2018-11-09 17:23 ` Bartosz Golaszewski
2018-11-11 16:59 ` Uwe Kleine-König
2018-11-12 14:14 ` Bartosz Golaszewski
2018-11-13 6:57 ` Uwe Kleine-König
2018-11-16 21:38 ` Linus Walleij
2018-11-08 16:52 ` [PATCH 2/3] gpio: mockup: add locking Bartosz Golaszewski
2018-11-08 21:13 ` Uwe Kleine-König
2018-11-16 21:43 ` Linus Walleij
2018-11-19 9:09 ` Bartosz Golaszewski
2018-11-20 8:46 ` Linus Walleij
2018-11-08 16:52 ` [PATCH 3/3] gpio: mockup: implement get_multiple() Bartosz Golaszewski
2018-11-08 20:36 ` Uwe Kleine-König
2018-11-16 21:44 ` Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181108203546.54rncnydgamud5z3@pengutronix.de \
--to=u.kleine-koenig@pengutronix.de \
--cc=bamv2005@gmail.com \
--cc=brgl@bgdev.pl \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).