From: David Miller <davem@davemloft.net>
To: robh@kernel.org
Cc: frowand.list@gmail.com, linux-kernel@vger.kernel.org,
sparclinux@vger.kernel.org
Subject: Re: [PATCH 2/8] of: Drop full path from Sparc PDT full_name
Date: Fri, 09 Nov 2018 20:36:50 -0800 (PST) [thread overview]
Message-ID: <20181109.203650.2137044253712054807.davem@davemloft.net> (raw)
In-Reply-To: <CAL_JsqLs7P81KiT3b3W5G=qt6JfU0tvM1TKdtJJ5Vq1HSzRW3w@mail.gmail.com>
From: Rob Herring <robh@kernel.org>
Date: Fri, 9 Nov 2018 14:30:01 -0600
> That is the intent. With this change we stop storing the full path for
> every node. Everywhere that needs the full path, generates it with the
> %pOF printf specifier. Other than users in arch/sparc converted in
> this series all the users of full_name have been converted already or
> use kbasename(full_name) so they work either way. BTW, I've found a
> couple more, so I'll be sending you a v2.
>
> And of_pdt_build_full_name for !SPARC does need to be converted too,
> but I'll do that separately.
I would think that, for correctness, you'd need to adjust both functions
at the same time, no?
next prev parent reply other threads:[~2018-11-10 5:55 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-07 22:31 [PATCH 0/8] sparc: OF name and device_type rework Rob Herring
2018-11-07 22:31 ` [PATCH 1/8] fs/openpromfs: use full_name instead of path_component_name Rob Herring
2018-11-07 22:31 ` [PATCH 2/8] of: Drop full path from Sparc PDT full_name Rob Herring
2018-11-09 3:11 ` David Miller
2018-11-09 20:30 ` Rob Herring
2018-11-10 4:36 ` David Miller [this message]
2018-11-07 22:31 ` [PATCH 3/8] sparc: prom: use property "name" directly to construct node names Rob Herring
2018-11-09 3:13 ` David Miller
2018-11-09 13:02 ` Rob Herring
2018-11-10 0:32 ` David Miller
2018-11-07 22:31 ` [PATCH 4/8] sparc: Convert to using %pOF instead of full_name Rob Herring
2018-11-07 22:31 ` [PATCH 5/8] sparc: Convert to using %pOFn instead of device_node.name Rob Herring
2018-11-07 22:31 ` [PATCH 6/8] sparc: Use of_node_name_eq for node name comparisons Rob Herring
2018-11-07 22:31 ` [PATCH 7/8] sparc: Remove unused leon_trans_init Rob Herring
2018-11-07 22:31 ` [PATCH 8/8] sparc: Use device_type helpers to access the node type Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181109.203650.2137044253712054807.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=frowand.list@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=robh@kernel.org \
--cc=sparclinux@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).