From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.6 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_PASS,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C0A08C43441 for ; Fri, 9 Nov 2018 00:04:41 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 7FED220855 for ; Fri, 9 Nov 2018 00:04:41 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="k5Yrw03K" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 7FED220855 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727662AbeKIJmj (ORCPT ); Fri, 9 Nov 2018 04:42:39 -0500 Received: from mail.kernel.org ([198.145.29.99]:35876 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727289AbeKIJmj (ORCPT ); Fri, 9 Nov 2018 04:42:39 -0500 Received: from localhost (unknown [167.220.2.187]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 4F41A20855; Fri, 9 Nov 2018 00:04:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1541721879; bh=pg3IOsCooCKbpDzY2LvNyPjv/LOQFWLn5g8rmKsDoQE=; h=Date:From:To:Subject:References:In-Reply-To:From; b=k5Yrw03KbxOvWX/QCRnTYPDfra3ThW9hHG17Egf733wbGgFs+Vrn1kDefR4eCVd9v dWW+T8AjI+ict8+QuePRD0ZXSILy0y3jmKBkUUnj/QhYA2HlzalV1lXLMnjOZ+jwwd GvGOoHBt0LUvo5dVHLLA2J9Z6QUFjok33f6fkpms= Date: Thu, 8 Nov 2018 19:04:38 -0500 From: Sasha Levin To: dsterba@suse.cz, Greg Kroah-Hartman , linux-kernel@vger.kernel.org, Jiri Kosina , stable@vger.kernel.org Subject: Re: [PATCH 4.4 026/114] btrfs: cleaner_kthread() doesnt need explicit freeze Message-ID: <20181109000438.GB14882@sasha-vm> References: <20181108215059.051093652@linuxfoundation.org> <20181108215101.483013816@linuxfoundation.org> <20181108232809.GI24115@suse.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline In-Reply-To: <20181108232809.GI24115@suse.cz> User-Agent: Mutt/1.9.4 (2018-02-28) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Nov 09, 2018 at 12:28:10AM +0100, David Sterba wrote: >On Thu, Nov 08, 2018 at 01:50:41PM -0800, Greg Kroah-Hartman wrote: >> 4.4-stable review patch. If anyone has any objections, please let me know. > >> [ Upstream commit 838fe1887765f4cc679febea60d87d2a06bd300e ] > >Please check the discussion under > >https://lore.kernel.org/lkml/20181025141705.213937-8-sashal@kernel.org/ > >Jiri's reply: > >"This patch just removes pointless try_to_freeze(), that's guaranteed >not to do anything and return immediately, as the btrfs kthread is not >freezable. So I don't think it's needed in stable; the semantics is >equivalent before and after." > >Sasha was fine with dropping the patch from stable candidates and this >has not changed. Thanks. Indeed, I thought I dropped it but I see that I didn't. My bad, sorry. -- Thanks, Sasha