linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] xen/netfront: remove unnecessary wmb
@ 2018-11-09  6:53 Jacob Wen
  2018-11-09  6:58 ` Juergen Gross
                   ` (2 more replies)
  0 siblings, 3 replies; 4+ messages in thread
From: Jacob Wen @ 2018-11-09  6:53 UTC (permalink / raw)
  To: netdev; +Cc: jgross, xen-devel, linux-kernel

RING_PUSH_REQUESTS_AND_CHECK_NOTIFY is already able to make sure backend sees
requests before req_prod is updated.

Signed-off-by: Jacob Wen <jian.w.wen@oracle.com>
---
 drivers/net/xen-netfront.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/drivers/net/xen-netfront.c b/drivers/net/xen-netfront.c
index f17f602e6171..a8303afa15f1 100644
--- a/drivers/net/xen-netfront.c
+++ b/drivers/net/xen-netfront.c
@@ -337,8 +337,6 @@ static void xennet_alloc_rx_buffers(struct netfront_queue *queue)
 		return;
 	}
 
-	wmb();		/* barrier so backend seens requests */
-
 	RING_PUSH_REQUESTS_AND_CHECK_NOTIFY(&queue->rx, notify);
 	if (notify)
 		notify_remote_via_irq(queue->rx_irq);
-- 
2.17.1


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] xen/netfront: remove unnecessary wmb
  2018-11-09  6:53 [PATCH] xen/netfront: remove unnecessary wmb Jacob Wen
@ 2018-11-09  6:58 ` Juergen Gross
  2018-11-09 10:52 ` [Xen-devel] " Wei Liu
  2018-11-09 23:17 ` David Miller
  2 siblings, 0 replies; 4+ messages in thread
From: Juergen Gross @ 2018-11-09  6:58 UTC (permalink / raw)
  To: Jacob Wen, netdev; +Cc: xen-devel, linux-kernel

On 09/11/2018 07:53, Jacob Wen wrote:
> RING_PUSH_REQUESTS_AND_CHECK_NOTIFY is already able to make sure backend sees
> requests before req_prod is updated.
> 
> Signed-off-by: Jacob Wen <jian.w.wen@oracle.com>

Reviewed-by: Juergen Gross <jgross@suse.com>


Juergen

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [Xen-devel] [PATCH] xen/netfront: remove unnecessary wmb
  2018-11-09  6:53 [PATCH] xen/netfront: remove unnecessary wmb Jacob Wen
  2018-11-09  6:58 ` Juergen Gross
@ 2018-11-09 10:52 ` Wei Liu
  2018-11-09 23:17 ` David Miller
  2 siblings, 0 replies; 4+ messages in thread
From: Wei Liu @ 2018-11-09 10:52 UTC (permalink / raw)
  To: Jacob Wen; +Cc: netdev, jgross, xen-devel, linux-kernel, Wei Liu

On Fri, Nov 09, 2018 at 02:53:59PM +0800, Jacob Wen wrote:
> RING_PUSH_REQUESTS_AND_CHECK_NOTIFY is already able to make sure backend sees
> requests before req_prod is updated.
> 
> Signed-off-by: Jacob Wen <jian.w.wen@oracle.com>

Reviewed-by: Wei Liu <wei.liu2@citrix.com>

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] xen/netfront: remove unnecessary wmb
  2018-11-09  6:53 [PATCH] xen/netfront: remove unnecessary wmb Jacob Wen
  2018-11-09  6:58 ` Juergen Gross
  2018-11-09 10:52 ` [Xen-devel] " Wei Liu
@ 2018-11-09 23:17 ` David Miller
  2 siblings, 0 replies; 4+ messages in thread
From: David Miller @ 2018-11-09 23:17 UTC (permalink / raw)
  To: jian.w.wen; +Cc: netdev, jgross, xen-devel, linux-kernel

From: Jacob Wen <jian.w.wen@oracle.com>
Date: Fri,  9 Nov 2018 14:53:59 +0800

> RING_PUSH_REQUESTS_AND_CHECK_NOTIFY is already able to make sure backend sees
> requests before req_prod is updated.
> 
> Signed-off-by: Jacob Wen <jian.w.wen@oracle.com>

Applied to net-next.

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2018-11-09 23:17 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-11-09  6:53 [PATCH] xen/netfront: remove unnecessary wmb Jacob Wen
2018-11-09  6:58 ` Juergen Gross
2018-11-09 10:52 ` [Xen-devel] " Wei Liu
2018-11-09 23:17 ` David Miller

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).