From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 12BF7C43441 for ; Fri, 9 Nov 2018 06:29:05 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id D8A3920840 for ; Fri, 9 Nov 2018 06:29:04 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D8A3920840 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=bootlin.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727807AbeKIQIH (ORCPT ); Fri, 9 Nov 2018 11:08:07 -0500 Received: from mail.bootlin.com ([62.4.15.54]:33646 "EHLO mail.bootlin.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727693AbeKIQIH (ORCPT ); Fri, 9 Nov 2018 11:08:07 -0500 Received: by mail.bootlin.com (Postfix, from userid 110) id 7115920787; Fri, 9 Nov 2018 07:29:00 +0100 (CET) Received: from bbrezillon (unknown [91.160.177.164]) by mail.bootlin.com (Postfix) with ESMTPSA id 1B448206D8; Fri, 9 Nov 2018 07:29:00 +0100 (CET) Date: Fri, 9 Nov 2018 07:28:57 +0100 From: Boris Brezillon To: Naga Sureshkumar Relli Cc: , , , , , , , , , Subject: Re: [LINUX PATCH v12 1/3] dt-bindings: mtd: arasan: Add device tree binding documentation Message-ID: <20181109072857.75e86cb6@bbrezillon> In-Reply-To: <1541739641-17789-2-git-send-email-naga.sureshkumar.relli@xilinx.com> References: <1541739641-17789-1-git-send-email-naga.sureshkumar.relli@xilinx.com> <1541739641-17789-2-git-send-email-naga.sureshkumar.relli@xilinx.com> X-Mailer: Claws Mail 3.16.0 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 9 Nov 2018 10:30:39 +0530 Naga Sureshkumar Relli wrote: > This patch adds the dts binding document for arasan nand flash controller > > Signed-off-by: Naga Sureshkumar Relli > --- > Changes in v12: > - Removed interrupt-parent description as it is implied as suggested by > Rob Herring > - Added missing ';' as required > Changes in v11: > - Updated compatible description as suggested by Boris > - Removed arasan-has-dma property > Changes in v10: > - None > Changes in v9: > - None > Changes in v8: > - Updated compatible and clock-names as per Boris comments > Changes in v7: > - Corrected the acronyms those should be in caps > Changes in v6: > - Removed num-cs property > - Separated nandchip from nand controller > Changes in v5: > - None > Changes in v4: > - Added num-cs property > - Added clock support > Changes in v3: > - None > Changes in v2: > - None > --- > .../devicetree/bindings/mtd/arasan_nand.txt | 32 ++++++++++++++++++++++ > 1 file changed, 32 insertions(+) > create mode 100644 Documentation/devicetree/bindings/mtd/arasan_nand.txt > > diff --git a/Documentation/devicetree/bindings/mtd/arasan_nand.txt b/Documentation/devicetree/bindings/mtd/arasan_nand.txt > new file mode 100644 > index 0000000..b522daf > --- /dev/null > +++ b/Documentation/devicetree/bindings/mtd/arasan_nand.txt > @@ -0,0 +1,32 @@ > +Arasan NAND Flash Controller with ONFI 3.1 support > + > +Required properties: > +- compatible: Should be "xlnx,zynqmp-nand", "arasan,nfc-v3p10" > +- reg: Memory map for module access > +- interrupts: Should contain the interrupt for the device > +- clock-name: List of input clocks - "sys", "flash" > + (See clock bindings for details) > +- clocks: Clock phandles (see clock bindings for details) > + > +Required properties for child node: > +- nand-ecc-mode: see nand.txt Why is it required? Can't you fallback to HW when this prop is missing? Oh, and reg is not listed in the required props. > + > +For NAND partition information please refer the below file > +Documentation/devicetree/bindings/mtd/partition.txt > + > +Example: > + nfc: nand@ff100000 { > + compatible = "xlnx,zynqmp-nand", "arasan,nfc-v3p10"; > + reg = <0x0 0xff100000 0x1000>; > + clock-name = "sys", "flash"; > + clocks = <&misc_clk &misc_clk>; > + interrupt-parent = <&gic>; > + interrupts = <0 14 4>; > + #address-cells = <1>; > + #size-cells = <0>; > + > + nand@0 { > + reg = <0>; > + nand-ecc-mode = "hw"; > + }; > + };