linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Ming Lei <ming.lei@redhat.com>
To: Jens Axboe <axboe@kernel.dk>
Cc: linux-block@vger.kernel.org, linux-kernel@vger.kernel.org,
	Ming Lei <ming.lei@redhat.com>, Christoph Hellwig <hch@lst.de>,
	David Sterba <dsterba@suse.com>,
	linux-btrfs@vger.kernel.org
Subject: [PATCH V8 08/18] btrfs: move bio_pages_all() to btrfs
Date: Sat, 10 Nov 2018 00:26:00 +0800	[thread overview]
Message-ID: <20181109162610.18981-9-ming.lei@redhat.com> (raw)
In-Reply-To: <20181109162610.18981-1-ming.lei@redhat.com>

BTRFS is the only user of this helper, so move this helper into
BTRFS, and implement it via bio_for_each_segment_all(), since
bio->bi_vcnt may not equal to number of pages after multipage bvec
is enabled.

Cc: Christoph Hellwig <hch@lst.de>
Cc: David Sterba <dsterba@suse.com>
Cc: linux-btrfs@vger.kernel.org
Signed-off-by: Ming Lei <ming.lei@redhat.com>
---
 fs/btrfs/extent_io.c | 14 +++++++++++++-
 1 file changed, 13 insertions(+), 1 deletion(-)

diff --git a/fs/btrfs/extent_io.c b/fs/btrfs/extent_io.c
index 5d5965297e7e..874bb9aeebdc 100644
--- a/fs/btrfs/extent_io.c
+++ b/fs/btrfs/extent_io.c
@@ -2348,6 +2348,18 @@ struct bio *btrfs_create_repair_bio(struct inode *inode, struct bio *failed_bio,
 	return bio;
 }
 
+static unsigned btrfs_bio_pages_all(struct bio *bio)
+{
+	unsigned i;
+	struct bio_vec *bv;
+
+	WARN_ON_ONCE(bio_flagged(bio, BIO_CLONED));
+
+	bio_for_each_segment_all(bv, bio, i)
+		;
+	return i;
+}
+
 /*
  * this is a generic handler for readpage errors (default
  * readpage_io_failed_hook). if other copies exist, read those and write back
@@ -2368,7 +2380,7 @@ static int bio_readpage_error(struct bio *failed_bio, u64 phy_offset,
 	int read_mode = 0;
 	blk_status_t status;
 	int ret;
-	unsigned failed_bio_pages = bio_pages_all(failed_bio);
+	unsigned failed_bio_pages = btrfs_bio_pages_all(failed_bio);
 
 	BUG_ON(bio_op(failed_bio) == REQ_OP_WRITE);
 
-- 
2.9.5


  parent reply	other threads:[~2018-11-09 16:27 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-11-09 16:25 [PATCH V8 00/18] block: support multi-page bvec Ming Lei
2018-11-09 16:25 ` [PATCH V8 01/18] block: introduce multi-page page bvec helpers Ming Lei
2018-11-09 16:25 ` [PATCH V8 02/18] block: introduce bio_for_each_bvec() Ming Lei
2018-11-09 16:25 ` [PATCH V8 03/18] block: use bio_for_each_bvec() to compute multi-page bvec count Ming Lei
2018-11-09 16:25 ` [PATCH V8 04/18] block: use bio_for_each_bvec() to map sg Ming Lei
2018-11-09 16:25 ` [PATCH V8 05/18] block: introduce bvec_last_segment() Ming Lei
2018-11-09 16:25 ` [PATCH V8 06/18] fs/buffer.c: use bvec iterator to truncate the bio Ming Lei
2018-11-09 16:25 ` [PATCH V8 07/18] btrfs: use bvec_last_segment to get bio's last page Ming Lei
2018-11-09 16:26 ` Ming Lei [this message]
2018-11-09 16:26 ` [PATCH V8 09/18] block: introduce bio_bvecs() Ming Lei
2018-11-09 16:26 ` [PATCH V8 10/18] block: loop: pass multi-page bvec to iov_iter Ming Lei
2018-11-09 16:26 ` [PATCH V8 11/18] bcache: avoid to use bio_for_each_segment_all() in bch_bio_alloc_pages() Ming Lei
2018-11-09 16:26 ` [PATCH V8 12/18] block: allow bio_for_each_segment_all() to iterate over multi-page bvec Ming Lei
2018-11-09 16:26 ` [PATCH V8 13/18] block: enable multipage bvecs Ming Lei
2018-11-13 11:39   ` Ming Lei
2018-11-09 16:26 ` [PATCH V8 14/18] block: always define BIO_MAX_PAGES as 256 Ming Lei
2018-11-09 16:26 ` [PATCH V8 15/18] block: document usage of bio iterator helpers Ming Lei
2018-11-09 16:26 ` [PATCH V8 16/18] block: don't use bio->bi_vcnt to figure out segment number Ming Lei
2018-11-09 16:26 ` [PATCH V8 17/18] block: kill QUEUE_FLAG_NO_SG_MERGE Ming Lei
2018-11-09 16:26 ` [PATCH V8 18/18] block: kill BLK_MQ_F_SG_MERGE Ming Lei
2018-11-09 19:44 ` [PATCH V8 00/18] block: support multi-page bvec Jens Axboe

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20181109162610.18981-9-ming.lei@redhat.com \
    --to=ming.lei@redhat.com \
    --cc=axboe@kernel.dk \
    --cc=dsterba@suse.com \
    --cc=hch@lst.de \
    --cc=linux-block@vger.kernel.org \
    --cc=linux-btrfs@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).