linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: Fabien Lahoudere <fabien.lahoudere@collabora.com>
Cc: linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org
Subject: Re: [PATCH v3 1/1] serial: imx - Add dma buffer confugration via sysfs
Date: Fri, 9 Nov 2018 09:02:57 -0800	[thread overview]
Message-ID: <20181109170257.GA14151@kroah.com> (raw)
In-Reply-To: <1539764425.3694.1.camel@collabora.com>

On Wed, Oct 17, 2018 at 10:20:25AM +0200, Fabien Lahoudere wrote:
> Hi Greg,
> 
> On Mon, 2018-10-15 at 16:01 +0200, Greg KH wrote:
> > On Thu, Oct 11, 2018 at 11:25:03AM +0200, Fabien Lahoudere wrote:
> > > In order to optimize serial communication on imx53 and imx6, we may
> > > need to tweak DMA period and buffer length per period.
> > 
> > Why can you not just automatically determine this information?  What is
> > userspace going to know that the kernel can not just learn now?
> > 
> > Having tunables is nice, but it is even better to not need them at all.
> 
> I agree that it is better to let the kernel do the configuration.

Great!

> However in our case we use several serial communication for different device
> and one of them need to tweak that configuration to get small data with a better
> period. However having this parameter for all serial port implies a bigger number
> of interrupts for others too.

Why can you not dynamically figure this out?  How are you figuring it
out "by hand" today in userspace?

thanks,

greg k-h

      reply	other threads:[~2018-11-09 17:03 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-10-11  9:25 [PATCH v3 1/1] serial: imx - Add dma buffer confugration via sysfs Fabien Lahoudere
2018-10-15 14:01 ` Greg KH
2018-10-17  8:20   ` Fabien Lahoudere
2018-11-09 17:02     ` Greg KH [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20181109170257.GA14151@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=fabien.lahoudere@collabora.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-serial@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).