* [PATCH v6 0/2] media: usb: pwc: Don't use coherent DMA buffers for ISO transfer
@ 2018-11-09 19:01 Matwey V. Kornilov
0 siblings, 0 replies; 5+ messages in thread
From: Matwey V. Kornilov @ 2018-11-09 19:01 UTC (permalink / raw)
To: linux-media, linux-kernel
Cc: matwey.kornilov, Matwey V. Kornilov, tfiga, laurent.pinchart,
stern, ezequiel, hdegoede, hverkuil, mchehab, rostedt, mingo,
isely, bhumirks, colin.king, kieran.bingham, keiichiw
DMA cocherency slows the transfer down on systems without hardware coherent
DMA. In order to demontrate this we introduce performance measurement
facilities in patch 1 and fix the performance issue in patch 2 in order to
obtain 3.3 times speedup.
Changes since v5:
* add dma_sync_single_for_device() as required by Laurent Pinchart
Changes since v4:
* fix fields order in trace events
* minor style fixes
Changes since v3:
* fix scripts/checkpatch.pl errors
* use __string to store name in trace events
Changes since v2:
* use dma_sync_single_for_cpu() to achive better performance
* remeasured performance
Changes since v1:
* trace_pwc_handler_exit() call moved to proper place
* detailed description added for commit 1
* additional output added to trace to track separate frames
Matwey V. Kornilov (2):
media: usb: pwc: Introduce TRACE_EVENTs for pwc_isoc_handler()
media: usb: pwc: Don't use coherent DMA buffers for ISO transfer
drivers/media/usb/pwc/pwc-if.c | 69 ++++++++++++++++++++++++++++++++++--------
include/trace/events/pwc.h | 65 +++++++++++++++++++++++++++++++++++++++
2 files changed, 121 insertions(+), 13 deletions(-)
create mode 100644 include/trace/events/pwc.h
--
2.16.4
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH v6 0/2] media: usb: pwc: Don't use coherent DMA buffers for ISO transfer
2018-12-12 17:41 ` Ezequiel Garcia
@ 2018-12-24 8:23 ` Matwey V. Kornilov
0 siblings, 0 replies; 5+ messages in thread
From: Matwey V. Kornilov @ 2018-12-24 8:23 UTC (permalink / raw)
To: Ezequiel Garcia
Cc: Laurent Pinchart, linux-media, Linux Kernel Mailing List,
Tomasz Figa, Alan Stern, Ezequiel Garcia, Hans de Goede,
Hans Verkuil, Mauro Carvalho Chehab, Steven Rostedt, mingo,
Mike Isely, Bhumika Goyal, Colin King, Kieran Bingham,
Keiichi Watanabe
ср, 12 дек. 2018 г. в 20:41, Ezequiel Garcia <ezequiel@vanguardiasur.com.ar>:
>
> On Wed, 12 Dec 2018 at 14:27, Laurent Pinchart
> <laurent.pinchart@ideasonboard.com> wrote:
> >
> > Hi Matwey,
> >
> > Thank you for the patches.
> >
> > For the whole series,
> >
> > Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> >
>
> Thanks Laurent.
>
> Matwey, given your detailed analysis of this issue,
> and given you have pwc hardware to test, I think
> you should consider co-maintaining this driver.
>
Well, It would be great if I could help. Is there some guide how to apply?
> Thanks,
> --
> Ezequiel García, VanguardiaSur
> www.vanguardiasur.com.ar
--
With best regards,
Matwey V. Kornilov
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH v6 0/2] media: usb: pwc: Don't use coherent DMA buffers for ISO transfer
2018-12-12 17:28 ` Laurent Pinchart
@ 2018-12-12 17:41 ` Ezequiel Garcia
2018-12-24 8:23 ` Matwey V. Kornilov
0 siblings, 1 reply; 5+ messages in thread
From: Ezequiel Garcia @ 2018-12-12 17:41 UTC (permalink / raw)
To: Laurent Pinchart
Cc: matwey, linux-media, Linux Kernel Mailing List, matwey.kornilov,
Tomasz Figa, Alan Stern, Ezequiel Garcia, Hans de Goede,
Hans Verkuil, Mauro Carvalho Chehab, rostedt, mingo, isely,
bhumirks, colin.king, kieran.bingham, Keiichi Watanabe
On Wed, 12 Dec 2018 at 14:27, Laurent Pinchart
<laurent.pinchart@ideasonboard.com> wrote:
>
> Hi Matwey,
>
> Thank you for the patches.
>
> For the whole series,
>
> Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
>
Thanks Laurent.
Matwey, given your detailed analysis of this issue,
and given you have pwc hardware to test, I think
you should consider co-maintaining this driver.
Thanks,
--
Ezequiel García, VanguardiaSur
www.vanguardiasur.com.ar
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH v6 0/2] media: usb: pwc: Don't use coherent DMA buffers for ISO transfer
2018-11-09 19:03 Matwey V. Kornilov
@ 2018-12-12 17:28 ` Laurent Pinchart
2018-12-12 17:41 ` Ezequiel Garcia
0 siblings, 1 reply; 5+ messages in thread
From: Laurent Pinchart @ 2018-12-12 17:28 UTC (permalink / raw)
To: Matwey V. Kornilov
Cc: linux-media, linux-kernel, matwey.kornilov, tfiga, stern,
ezequiel, hdegoede, hverkuil, mchehab, rostedt, mingo, isely,
bhumirks, colin.king, kieran.bingham, keiichiw
Hi Matwey,
Thank you for the patches.
For the whole series,
Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
On Friday, 9 November 2018 21:03:25 EET Matwey V. Kornilov wrote:
> DMA cocherency slows the transfer down on systems without hardware coherent
> DMA. In order to demontrate this we introduce performance measurement
> facilities in patch 1 and fix the performance issue in patch 2 in order to
> obtain 3.3 times speedup.
>
> Changes since v5:
> * add dma_sync_single_for_device() as required by Laurent Pinchart
>
> Changes since v4:
> * fix fields order in trace events
> * minor style fixes
>
> Changes since v3:
> * fix scripts/checkpatch.pl errors
> * use __string to store name in trace events
>
> Changes since v2:
> * use dma_sync_single_for_cpu() to achive better performance
> * remeasured performance
>
> Changes since v1:
> * trace_pwc_handler_exit() call moved to proper place
> * detailed description added for commit 1
> * additional output added to trace to track separate frames
>
> Matwey V. Kornilov (2):
> media: usb: pwc: Introduce TRACE_EVENTs for pwc_isoc_handler()
> media: usb: pwc: Don't use coherent DMA buffers for ISO transfer
>
> drivers/media/usb/pwc/pwc-if.c | 69 +++++++++++++++++++++++++++++++--------
> include/trace/events/pwc.h | 65 +++++++++++++++++++++++++++++++++++++++
> 2 files changed, 121 insertions(+), 13 deletions(-)
> create mode 100644 include/trace/events/pwc.h
--
Regards,
Laurent Pinchart
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH v6 0/2] media: usb: pwc: Don't use coherent DMA buffers for ISO transfer
@ 2018-11-09 19:03 Matwey V. Kornilov
2018-12-12 17:28 ` Laurent Pinchart
0 siblings, 1 reply; 5+ messages in thread
From: Matwey V. Kornilov @ 2018-11-09 19:03 UTC (permalink / raw)
To: linux-media, linux-kernel
Cc: matwey.kornilov, Matwey V. Kornilov, tfiga, laurent.pinchart,
stern, ezequiel, hdegoede, hverkuil, mchehab, rostedt, mingo,
isely, bhumirks, colin.king, kieran.bingham, keiichiw
DMA cocherency slows the transfer down on systems without hardware coherent
DMA. In order to demontrate this we introduce performance measurement
facilities in patch 1 and fix the performance issue in patch 2 in order to
obtain 3.3 times speedup.
Changes since v5:
* add dma_sync_single_for_device() as required by Laurent Pinchart
Changes since v4:
* fix fields order in trace events
* minor style fixes
Changes since v3:
* fix scripts/checkpatch.pl errors
* use __string to store name in trace events
Changes since v2:
* use dma_sync_single_for_cpu() to achive better performance
* remeasured performance
Changes since v1:
* trace_pwc_handler_exit() call moved to proper place
* detailed description added for commit 1
* additional output added to trace to track separate frames
Matwey V. Kornilov (2):
media: usb: pwc: Introduce TRACE_EVENTs for pwc_isoc_handler()
media: usb: pwc: Don't use coherent DMA buffers for ISO transfer
drivers/media/usb/pwc/pwc-if.c | 69 ++++++++++++++++++++++++++++++++++--------
include/trace/events/pwc.h | 65 +++++++++++++++++++++++++++++++++++++++
2 files changed, 121 insertions(+), 13 deletions(-)
create mode 100644 include/trace/events/pwc.h
--
2.16.4
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2018-12-24 8:24 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-11-09 19:01 [PATCH v6 0/2] media: usb: pwc: Don't use coherent DMA buffers for ISO transfer Matwey V. Kornilov
2018-11-09 19:03 Matwey V. Kornilov
2018-12-12 17:28 ` Laurent Pinchart
2018-12-12 17:41 ` Ezequiel Garcia
2018-12-24 8:23 ` Matwey V. Kornilov
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).