linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Cyrill Gorcunov <gorcunov@gmail.com>
To: Rafael David Tinoco <rafael.tinoco@linaro.org>
Cc: adobriyan@gmail.com, akpm@linux-foundation.org,
	linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-kselftest@vger.kernel.org, shuah@kernel.org
Subject: Re: [PATCH] proc: fix and merge proc-self-map-file tests
Date: Fri, 9 Nov 2018 22:39:36 +0300	[thread overview]
Message-ID: <20181109193936.GP13195@uranus.lan> (raw)
In-Reply-To: <1541789329.305173.1571657968.7229F301@webmail.messagingengine.com>

On Fri, Nov 09, 2018 at 04:48:49PM -0200, Rafael David Tinoco wrote:
> 
> let me see if I got this right.. the premise for this test is to have *at least*
> 2 vmas, so we can check if the symlink for the mem range, describing the mapped
> area, is correct in procfs files, correct ? if yes, then why to have a totally
> duplicated test... just to check if mmap(0, ... MAP_FIXED ...) would work ?
> 
> Wouldn't exist a better place to have such test ? like in
> tools/testing/selftests/vm/mmap-null.c or something like it ?  genuine
> curiosity.. thinking i'm missing something about this test...

Ah, I happen to miss that they are identical except nil address. Then
true, vm/ looks like more suitable place for that. Do you happen to
know which exactly archs reserve first page (together with x86)?

  reply	other threads:[~2018-11-09 19:39 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-10-11 18:43 [PATCH] proc: fix proc-self-map-files selftest for arm Rafael David Tinoco
2018-10-11 19:42 ` Cyrill Gorcunov
2018-10-11 20:56 ` Alexey Dobriyan
2018-10-11 21:02   ` Cyrill Gorcunov
2018-10-11 21:30     ` Alexey Dobriyan
2018-10-11 22:00       ` Cyrill Gorcunov
2018-10-15 16:55         ` Rafael David Tinoco
2018-10-15 17:21           ` Cyrill Gorcunov
2018-11-08 10:41             ` Rafael David Tinoco
2018-11-08 11:11               ` Cyrill Gorcunov
2018-11-09 11:30                 ` [PATCH] proc: fix and merge proc-self-map-file tests Rafael David Tinoco
2018-11-09 11:41                   ` Cyrill Gorcunov
2018-11-09 11:45                     ` Rafael David Tinoco
2018-11-09 11:48                       ` Cyrill Gorcunov
2018-11-09 12:01                         ` Rafael David Tinoco
2018-11-09 18:04                           ` Cyrill Gorcunov
2018-11-09 18:48                             ` Rafael David Tinoco
2018-11-09 19:39                               ` Cyrill Gorcunov [this message]
2018-11-10 17:47                   ` Alexey Dobriyan
2018-11-10 17:56                     ` Rafael David Tinoco
2018-11-10 18:49                       ` Alexey Dobriyan
2018-11-11  2:50                         ` Rafael David Tinoco

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20181109193936.GP13195@uranus.lan \
    --to=gorcunov@gmail.com \
    --cc=adobriyan@gmail.com \
    --cc=akpm@linux-foundation.org \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-kselftest@vger.kernel.org \
    --cc=rafael.tinoco@linaro.org \
    --cc=shuah@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).