* [PATCH 1/3] staging: rtl8188eu: use __func__ in recv_linux.c
@ 2018-11-10 17:54 Michael Straube
2018-11-10 17:54 ` [PATCH 2/3] staging: rtl8188eu: add spaces around '*' " Michael Straube
2018-11-10 17:54 ` [PATCH 3/3] staging: rtl8188eu: remove unnecessary parentheses " Michael Straube
0 siblings, 2 replies; 3+ messages in thread
From: Michael Straube @ 2018-11-10 17:54 UTC (permalink / raw)
To: gregkh; +Cc: devel, linux-kernel, Michael Straube
Use __func__ instead of hardcoded function name.
Reported by checkpatch.
Signed-off-by: Michael Straube <straube.linux@gmail.com>
---
drivers/staging/rtl8188eu/os_dep/recv_linux.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/rtl8188eu/os_dep/recv_linux.c b/drivers/staging/rtl8188eu/os_dep/recv_linux.c
index 6f74f49bf3ab..764d33c4e839 100644
--- a/drivers/staging/rtl8188eu/os_dep/recv_linux.c
+++ b/drivers/staging/rtl8188eu/os_dep/recv_linux.c
@@ -75,7 +75,7 @@ int rtw_recv_indicatepkt(struct adapter *padapter,
skb = precv_frame->pkt;
if (!skb) {
RT_TRACE(_module_recv_osdep_c_, _drv_err_,
- ("rtw_recv_indicatepkt():skb == NULL something wrong!!!!\n"));
+ ("%s():skb == NULL something wrong!!!!\n", __func__));
goto _recv_indicatepkt_drop;
}
@@ -126,7 +126,7 @@ int rtw_recv_indicatepkt(struct adapter *padapter,
rtw_free_recvframe(precv_frame, pfree_recv_queue);
RT_TRACE(_module_recv_osdep_c_, _drv_info_,
- ("\n rtw_recv_indicatepkt :after netif_rx!!!!\n"));
+ ("\n %s :after netif_rx!!!!\n", __func__));
return _SUCCESS;
--
2.19.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [PATCH 2/3] staging: rtl8188eu: add spaces around '*' in recv_linux.c
2018-11-10 17:54 [PATCH 1/3] staging: rtl8188eu: use __func__ in recv_linux.c Michael Straube
@ 2018-11-10 17:54 ` Michael Straube
2018-11-10 17:54 ` [PATCH 3/3] staging: rtl8188eu: remove unnecessary parentheses " Michael Straube
1 sibling, 0 replies; 3+ messages in thread
From: Michael Straube @ 2018-11-10 17:54 UTC (permalink / raw)
To: gregkh; +Cc: devel, linux-kernel, Michael Straube
Add spaces around '*' to conform with kernel coding style.
Reported by checkpatch.
Signed-off-by: Michael Straube <straube.linux@gmail.com>
---
drivers/staging/rtl8188eu/os_dep/recv_linux.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/rtl8188eu/os_dep/recv_linux.c b/drivers/staging/rtl8188eu/os_dep/recv_linux.c
index 764d33c4e839..0d253a84904d 100644
--- a/drivers/staging/rtl8188eu/os_dep/recv_linux.c
+++ b/drivers/staging/rtl8188eu/os_dep/recv_linux.c
@@ -38,7 +38,7 @@ void rtw_handle_tkip_mic_err(struct adapter *padapter, u8 bgroup)
} else {
cur_time = jiffies;
- if (cur_time - psecuritypriv->last_mic_err_time < 60*HZ) {
+ if (cur_time - psecuritypriv->last_mic_err_time < 60 * HZ) {
psecuritypriv->btkip_countermeasure = true;
psecuritypriv->last_mic_err_time = 0;
psecuritypriv->btkip_countermeasure_time = cur_time;
--
2.19.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [PATCH 3/3] staging: rtl8188eu: remove unnecessary parentheses in recv_linux.c
2018-11-10 17:54 [PATCH 1/3] staging: rtl8188eu: use __func__ in recv_linux.c Michael Straube
2018-11-10 17:54 ` [PATCH 2/3] staging: rtl8188eu: add spaces around '*' " Michael Straube
@ 2018-11-10 17:54 ` Michael Straube
1 sibling, 0 replies; 3+ messages in thread
From: Michael Straube @ 2018-11-10 17:54 UTC (permalink / raw)
To: gregkh; +Cc: devel, linux-kernel, Michael Straube
Remove unnecessary parentheses reported by checkpatch.
Signed-off-by: Michael Straube <straube.linux@gmail.com>
---
drivers/staging/rtl8188eu/os_dep/recv_linux.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/rtl8188eu/os_dep/recv_linux.c b/drivers/staging/rtl8188eu/os_dep/recv_linux.c
index 0d253a84904d..9c9339863a4a 100644
--- a/drivers/staging/rtl8188eu/os_dep/recv_linux.c
+++ b/drivers/staging/rtl8188eu/os_dep/recv_linux.c
@@ -69,8 +69,8 @@ int rtw_recv_indicatepkt(struct adapter *padapter,
struct sk_buff *skb;
struct mlme_priv *pmlmepriv = &padapter->mlmepriv;
- precvpriv = &(padapter->recvpriv);
- pfree_recv_queue = &(precvpriv->free_recv_queue);
+ precvpriv = &padapter->recvpriv;
+ pfree_recv_queue = &precvpriv->free_recv_queue;
skb = precv_frame->pkt;
if (!skb) {
--
2.19.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-11-10 17:55 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-11-10 17:54 [PATCH 1/3] staging: rtl8188eu: use __func__ in recv_linux.c Michael Straube
2018-11-10 17:54 ` [PATCH 2/3] staging: rtl8188eu: add spaces around '*' " Michael Straube
2018-11-10 17:54 ` [PATCH 3/3] staging: rtl8188eu: remove unnecessary parentheses " Michael Straube
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).