From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: MyungJoo Ham <myungjoo.ham@samsung.com>,
Chanwoo Choi <cw00.choi@samsung.com>,
linux-usb@vger.kernel.org, Felipe Balbi <balbi@kernel.org>,
Guenter Roeck <linux@roeck-us.net>,
Heikki Krogerus <heikki.krogerus@linux.intel.com>,
Roger Quadros <rogerq@ti.com>,
linux-pm@vger.kernel.org, "Rafael J. Wysocki" <rafael@kernel.org>,
Sebastian Reichel <sre@kernel.org>,
linux-omap@vger.kernel.org, Darren Hart <dvhart@infradead.org>,
platform-driver-x86@vger.kernel.org,
linux-kernel@vger.kernel.org, Chen-Yu Tsai <wens@csie.org>,
Hans de Goede <hdegoede@redhat.com>,
Grant Likely <grant.likely@linaro.org>,
Peter Ujfalusi <peter.ujfalusi@ti.com>,
Mark Brown <broonie@kernel.org>,
Andrzej Hajda <a.hajda@samsung.com>
Subject: Re: [PATCH v1 1/5] drivercore: Revert "deferral race condition fix"
Date: Sat, 10 Nov 2018 20:36:29 +0200 [thread overview]
Message-ID: <20181110183629.GE10650@smile.fi.intel.com> (raw)
In-Reply-To: <20181110182622.GA32657@kroah.com>
On Sat, Nov 10, 2018 at 10:26:22AM -0800, Greg Kroah-Hartman wrote:
> On Sat, Nov 10, 2018 at 08:10:57PM +0200, Andy Shevchenko wrote:
> > Consider the following scenario.
> >
> > There are two independent devices coupled together by functional dependencies:
> > - USB OTG (dwc3-pci)
> > - extcon (tested with extcon-intel-mrfld, not yet in upstream)
> >
> > Each of the driver services a corresponding device is built as a module. In the
> > Buildroot environment the modules are probed by alphabetical ordering of their
> > modaliases. The latter comes to the case when USB OTG driver will be probed
> > first followed by extcon one.
> >
> > So, if the platform anticipates extcon device to be appeared, in the above case
> > we will get deferred probe of USB OTG, because of ordering.
> >
> > Now, a cherry on top of the cake, the deferred probing list contains
> > the only two modules, i.e. USB OTG and extcon. Due to above circumstances,
> > values in the local_trigger_count and deferred_trigger_count are not the same,
> > and thus provokes deferred probe triggering again and again.
> >
> > ...
> > [ 20.678332] platform dwc3.0.auto: Retrying from deferred list
> > [ 20.694743] platform dwc3.0.auto: Driver dwc3 requests probe deferral
> > [ 20.701254] platform dwc3.0.auto: Added to deferred list
> > [ 20.706620] platform dwc3.0.auto: driver_deferred_probe_add_trigger 1 2
> > [ 20.713732] platform dwc3.0.auto: Retrying from deferred list
> > [ 20.730035] platform dwc3.0.auto: Driver dwc3 requests probe deferral
> > [ 20.736540] platform dwc3.0.auto: Added to deferred list
> > [ 20.741889] platform dwc3.0.auto: driver_deferred_probe_add_trigger 3 4
> > [ 20.748991] platform dwc3.0.auto: Retrying from deferred list
> > [ 20.765416] platform dwc3.0.auto: Driver dwc3 requests probe deferral
> > [ 20.771914] platform dwc3.0.auto: Added to deferred list
> > [ 20.777279] platform dwc3.0.auto: driver_deferred_probe_add_trigger 5 6
> > ...
> >
> > Deeper investigation shows the culprit commit 58b116bce136
> > ("drivercore: deferral race condition fix") which was dedicated to fix some
> > other issue while bringing a regression.
> >
> > This reverts commit 58b116bce13612e5aa6fcd49ecbd4cf8bb59e835 for good until
> > we will have better solution.
> >
> > Cc: Grant Likely <grant.likely@linaro.org>
> > Cc: Peter Ujfalusi <peter.ujfalusi@ti.com>
> > Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> > Cc: Mark Brown <broonie@kernel.org>
> > Cc: Felipe Balbi <balbi@kernel.org>
> > Cc: Andrzej Hajda <a.hajda@samsung.com>
> > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> > ---
> > drivers/base/dd.c | 27 ++-------------------------
> > 1 file changed, 2 insertions(+), 25 deletions(-)
>
> Shouldn't there be a "Fixes:" line and cc: stable here?
I'm not sure (yet). I would like to hear from people first, especially from
Grant (I spoke to him already for the matters at ELCE in Edinburg).
Perhaps, Hans can have a chance to test this and comment on.
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2018-11-10 18:36 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-10 18:10 [PATCH v1 1/5] drivercore: Revert "deferral race condition fix" Andy Shevchenko
2018-11-10 18:10 ` [PATCH v1 2/5] extcon: Return -EPROBE_DEFER when extcon device is not found Andy Shevchenko
2018-11-10 18:39 ` Guenter Roeck
2018-11-11 0:06 ` Sebastian Reichel
2018-11-12 0:24 ` Chanwoo Choi
2018-11-13 23:52 ` Chanwoo Choi
2018-11-14 8:35 ` Andy Shevchenko
2018-11-14 9:13 ` Chanwoo Choi
2018-11-14 9:36 ` Andy Shevchenko
2018-11-14 9:48 ` Chanwoo Choi
2018-11-14 10:20 ` Andy Shevchenko
2018-11-14 11:05 ` Chanwoo Choi
2018-11-14 11:17 ` Andy Shevchenko
2018-11-14 14:04 ` Andy Shevchenko
2018-11-15 1:16 ` Chanwoo Choi
2018-11-12 11:47 ` Heikki Krogerus
2018-11-10 18:10 ` [PATCH v1 3/5] staging: typec: fusb302: Rename fcs,extcon-name to linux,extcon-name Andy Shevchenko
2018-11-10 18:40 ` Guenter Roeck
2018-11-10 18:11 ` [PATCH v1 4/5] usb: dwc3: drd: Switch to device property for 'extcon' handling Andy Shevchenko
2018-11-12 11:47 ` Felipe Balbi
2018-11-10 18:11 ` [PATCH v1 5/5] usb: dwc3: drd: Add support for DR detection through extcon Andy Shevchenko
2018-11-10 18:26 ` [PATCH v1 1/5] drivercore: Revert "deferral race condition fix" Greg Kroah-Hartman
2018-11-10 18:36 ` Andy Shevchenko [this message]
2018-11-11 11:45 ` Hans de Goede
2018-11-11 13:04 ` Andy Shevchenko
2018-11-11 19:26 ` Rob Herring
2018-11-11 23:53 ` Andy Shevchenko
2018-11-14 23:25 ` Grant Likely
2018-11-12 16:11 ` Peter Ujfalusi
2018-11-14 0:33 ` Mark Brown
2018-11-14 8:45 ` Andy Shevchenko
2018-11-14 10:19 ` Peter Ujfalusi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181110183629.GE10650@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=a.hajda@samsung.com \
--cc=balbi@kernel.org \
--cc=broonie@kernel.org \
--cc=cw00.choi@samsung.com \
--cc=dvhart@infradead.org \
--cc=grant.likely@linaro.org \
--cc=gregkh@linuxfoundation.org \
--cc=hdegoede@redhat.com \
--cc=heikki.krogerus@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=myungjoo.ham@samsung.com \
--cc=peter.ujfalusi@ti.com \
--cc=platform-driver-x86@vger.kernel.org \
--cc=rafael@kernel.org \
--cc=rogerq@ti.com \
--cc=sre@kernel.org \
--cc=wens@csie.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).