From: Jonathan Cameron <jic23@kernel.org>
To: "Ardelean, Alexandru" <alexandru.Ardelean@analog.com>
Cc: "lars@metafoo.de" <lars@metafoo.de>,
"knaack.h@gmx.de" <knaack.h@gmx.de>,
"Hennerich, Michael" <Michael.Hennerich@analog.com>,
"renatogeh@gmail.com" <renatogeh@gmail.com>,
"giuliano.belinassi@gmail.com" <giuliano.belinassi@gmail.com>,
"pmeerw@pmeerw.net" <pmeerw@pmeerw.net>,
"gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-iio@vger.kernel.org" <linux-iio@vger.kernel.org>,
"devel@driverdev.osuosl.org" <devel@driverdev.osuosl.org>,
"kernel-usp@googlegroups.com" <kernel-usp@googlegroups.com>
Subject: Re: [PATCH v2 1/2] staging: iio: ad7780: check if ad778x before gain update
Date: Sun, 11 Nov 2018 12:58:59 +0000 [thread overview]
Message-ID: <20181111125859.7263bc15@archlinux> (raw)
In-Reply-To: <77c3b6ee484b077152138cb8e1b7e03295114e54.camel@analog.com>
On Thu, 8 Nov 2018 13:44:17 +0000
"Ardelean, Alexandru" <alexandru.Ardelean@analog.com> wrote:
> On Thu, 2018-11-08 at 11:03 -0200, Giuliano Belinassi wrote:
> > Only the ad778x have the 'gain' status bit. Check it before updating
> > through a new variable is_ad778x in chip_info.
> >
>
> Looks good.
Alex, formal tags definitely preferred! It's not as though a
looks good is any less of a review than an Ack, it's just better
hidden as people need to look at mailing list archives...
Jonathan
>
> Alex
>
> > Signed-off-by: Giuliano Belinassi <giuliano.belinassi@usp.br>
> > ---
> > Changes in v2:
> > - Squashed is_ad778x declaration commit with the ad778x checkage
> > - Changed is_ad778x type to bool
> >
> > drivers/staging/iio/adc/ad7780.c | 15 +++++++++++----
> > 1 file changed, 11 insertions(+), 4 deletions(-)
> >
> > diff --git a/drivers/staging/iio/adc/ad7780.c
> > b/drivers/staging/iio/adc/ad7780.c
> > index 91e016d534ed..9ec2b002539e 100644
> > --- a/drivers/staging/iio/adc/ad7780.c
> > +++ b/drivers/staging/iio/adc/ad7780.c
> > @@ -35,6 +35,7 @@ struct ad7780_chip_info {
> > struct iio_chan_spec channel;
> > unsigned int pattern_mask;
> > unsigned int pattern;
> > + bool is_ad778x;
> > };
> >
> > struct ad7780_state {
> > @@ -113,10 +114,12 @@ static int ad7780_postprocess_sample(struct
> > ad_sigma_delta *sigma_delta,
> > ((raw_sample & chip_info->pattern_mask) != chip_info->pattern))
> > return -EIO;
> >
> > - if (raw_sample & AD7780_GAIN)
> > - st->gain = 1;
> > - else
> > - st->gain = 128;
> > + if (chip_info->is_ad778x) {
> > + if (raw_sample & AD7780_GAIN)
> > + st->gain = 1;
> > + else
> > + st->gain = 128;
> > + }
> >
> > return 0;
> > }
> > @@ -135,21 +138,25 @@ static const struct ad7780_chip_info
> > ad7780_chip_info_tbl[] = {
> > .channel = AD7780_CHANNEL(12, 24),
> > .pattern = 0x5,
> > .pattern_mask = 0x7,
> > + .is_ad778x = false,
> > },
> > [ID_AD7171] = {
> > .channel = AD7780_CHANNEL(16, 24),
> > .pattern = 0x5,
> > .pattern_mask = 0x7,
> > + .is_ad778x = false,
> > },
> > [ID_AD7780] = {
> > .channel = AD7780_CHANNEL(24, 32),
> > .pattern = 0x1,
> > .pattern_mask = 0x3,
> > + .is_ad778x = true,
> > },
> > [ID_AD7781] = {
> > .channel = AD7780_CHANNEL(20, 32),
> > .pattern = 0x1,
> > .pattern_mask = 0x3,
> > + .is_ad778x = true,
> > },
> > };
> >
next prev parent reply other threads:[~2018-11-11 12:59 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-08 13:03 [PATCH v2 0/2] pattern generation and gain update Giuliano Belinassi
2018-11-08 13:03 ` [PATCH v2 1/2] staging: iio: ad7780: check if ad778x before " Giuliano Belinassi
2018-11-08 13:44 ` Ardelean, Alexandru
2018-11-11 12:58 ` Jonathan Cameron [this message]
2018-11-12 7:57 ` Ardelean, Alexandru
2018-11-16 18:32 ` Jonathan Cameron
2018-11-08 18:26 ` Tomasz Duszynski
2018-11-09 22:15 ` Giuliano Augusto Faulin Belinassi
2018-11-11 13:00 ` Jonathan Cameron
2018-11-08 13:03 ` [PATCH v2 2/2] staging: iio: ad7780: generates pattern_mask from PAT bits Giuliano Belinassi
2018-11-08 13:51 ` Ardelean, Alexandru
2018-11-09 22:18 ` Giuliano Augusto Faulin Belinassi
2018-11-11 13:04 ` Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181111125859.7263bc15@archlinux \
--to=jic23@kernel.org \
--cc=Michael.Hennerich@analog.com \
--cc=alexandru.Ardelean@analog.com \
--cc=devel@driverdev.osuosl.org \
--cc=giuliano.belinassi@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=kernel-usp@googlegroups.com \
--cc=knaack.h@gmx.de \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pmeerw@pmeerw.net \
--cc=renatogeh@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).