From: Ingo Molnar <mingo@kernel.org>
To: Masahiro Yamada <yamada.masahiro@socionext.com>
Cc: Ingo Molnar <mingo@redhat.com>,
Thomas Gleixner <tglx@linutronix.de>,
x86@kernel.org, Richard Weinberger <richard@sigma-star.at>,
linuxppc-dev@lists.ozlabs.org,
Michael Ellerman <mpe@ellerman.id.au>,
"H. Peter Anvin" <hpa@zytor.com>, Borislav Petkov <bp@alien8.de>,
Benjamin Herrenschmidt <benh@kernel.crashing.org>,
linux-kernel@vger.kernel.org, Paul Mackerras <paulus@samba.org>
Subject: Re: [PATCH 2/2] x86, powerpc: remove -funit-at-a-time compiler option entirely
Date: Mon, 12 Nov 2018 04:01:34 +0100 [thread overview]
Message-ID: <20181112030134.GA39035@gmail.com> (raw)
In-Reply-To: <1541990120-9643-3-git-send-email-yamada.masahiro@socionext.com>
* Masahiro Yamada <yamada.masahiro@socionext.com> wrote:
> GCC 4.6 manual says:
>
> -funit-at-a-time
> This option is left for compatibility reasons. -funit-at-a-time has
> no effect, while -fno-unit-at-a-time implies -fno-toplevel-reorder
> and -fno-section-anchors.
> Enabled by default.
>
> Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
> ---
>
> arch/powerpc/Makefile | 4 ----
> arch/x86/Makefile | 4 ----
> arch/x86/Makefile.um | 5 -----
> 3 files changed, 13 deletions(-)
>
> diff --git a/arch/x86/Makefile b/arch/x86/Makefile
> index 88398fd..3508049 100644
> --- a/arch/x86/Makefile
> +++ b/arch/x86/Makefile
> @@ -130,10 +130,6 @@ else
>
> KBUILD_CFLAGS += -mno-red-zone
> KBUILD_CFLAGS += -mcmodel=kernel
> -
> - # -funit-at-a-time shrinks the kernel .text considerably
> - # unfortunately it makes reading oopses harder.
> - KBUILD_CFLAGS += $(call cc-option,-funit-at-a-time)
> endif
>
> ifdef CONFIG_X86_X32
> diff --git a/arch/x86/Makefile.um b/arch/x86/Makefile.um
> index 577976b..1db7913 100644
> --- a/arch/x86/Makefile.um
> +++ b/arch/x86/Makefile.um
> @@ -26,9 +26,6 @@ cflags-y += $(call cc-option,-mpreferred-stack-boundary=2)
> # an unresolved reference.
> cflags-y += -ffreestanding
>
> -# gcc 4.3.0 needs -funit-at-a-time for extern inline functions.
> -KBUILD_CFLAGS += $(call cc-option,-funit-at-a-time)
> -
> KBUILD_CFLAGS += $(cflags-y)
>
> else
> @@ -50,6 +47,4 @@ ELF_FORMAT := elf64-x86-64
> LINK-$(CONFIG_LD_SCRIPT_DYN) += -Wl,-rpath,/lib64
> LINK-y += -m64
>
> -# Do unit-at-a-time unconditionally on x86_64, following the host
> -KBUILD_CFLAGS += $(call cc-option,-funit-at-a-time)
> endif
Acked-by: Ingo Molnar <mingo@kernel.org>
Thanks,
Ingo
next prev parent reply other threads:[~2018-11-12 3:01 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-12 2:35 [PATCH 0/2] Remove -fno-unit-at-a-time and -funit-at-a-time compiler flags entirely Masahiro Yamada
2018-11-12 2:35 ` [PATCH 1/2] um: remove -fno-unit-at-a-time workaround for pre-4.0 GCC Masahiro Yamada
2018-11-13 9:47 ` Richard Weinberger
2018-12-08 6:35 ` Masahiro Yamada
2018-12-08 8:54 ` Richard Weinberger
2018-12-08 19:18 ` Masahiro Yamada
2018-12-09 11:06 ` [tip:x86/build] x86/um: Remove " tip-bot for Masahiro Yamada
2018-11-12 2:35 ` [PATCH 2/2] x86, powerpc: remove -funit-at-a-time compiler option entirely Masahiro Yamada
2018-11-12 3:01 ` Ingo Molnar [this message]
2018-11-12 11:22 ` Michael Ellerman
2018-12-08 6:36 ` Masahiro Yamada
2018-12-08 11:33 ` Borislav Petkov
2018-12-08 19:17 ` Masahiro Yamada
2018-12-09 11:07 ` [tip:x86/build] x86, powerpc: Remove " tip-bot for Masahiro Yamada
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181112030134.GA39035@gmail.com \
--to=mingo@kernel.org \
--cc=benh@kernel.crashing.org \
--cc=bp@alien8.de \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mingo@redhat.com \
--cc=mpe@ellerman.id.au \
--cc=paulus@samba.org \
--cc=richard@sigma-star.at \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
--cc=yamada.masahiro@socionext.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).