* [PATCH -next] USB: serial: mos7840: remove set but not used variables 'st, data1, iflag'
@ 2018-10-26 12:25 YueHaibing
2018-11-12 9:35 ` Johan Hovold
0 siblings, 1 reply; 2+ messages in thread
From: YueHaibing @ 2018-10-26 12:25 UTC (permalink / raw)
To: johan, gregkh; +Cc: linux-kernel, linux-usb, YueHaibing
Fixes gcc '-Wunused-but-set-variable' warning:
drivers/usb/serial/mos7840.c: In function 'mos7840_interrupt_callback':
drivers/usb/serial/mos7840.c:604:14: warning:
variable 'st' set but not used [-Wunused-but-set-variable]
drivers/usb/serial/mos7840.c: In function 'mos7840_write':
drivers/usb/serial/mos7840.c:1303:17: warning:
variable 'data1' set but not used [-Wunused-but-set-variable]
drivers/usb/serial/mos7840.c:1700:11: warning:
variable 'iflag' set but not used [-Wunused-but-set-variable]
They are never used since introduction in
commit 3f5429746d91 ("USB: Moschip 7840 USB-Serial Driver")
Signed-off-by: YueHaibing <yuehaibing@huawei.com>
---
drivers/usb/serial/mos7840.c | 7 +------
1 file changed, 1 insertion(+), 6 deletions(-)
diff --git a/drivers/usb/serial/mos7840.c b/drivers/usb/serial/mos7840.c
index 88828b4..bfbf75b 100644
--- a/drivers/usb/serial/mos7840.c
+++ b/drivers/usb/serial/mos7840.c
@@ -601,7 +601,7 @@ static void mos7840_interrupt_callback(struct urb *urb)
struct usb_serial *serial;
__u16 Data;
unsigned char *data;
- __u8 sp[5], st;
+ __u8 sp[5];
int i, rv = 0;
__u16 wval, wreg = 0;
int status = urb->status;
@@ -644,7 +644,6 @@ static void mos7840_interrupt_callback(struct urb *urb)
sp[1] = (__u8) data[1];
sp[2] = (__u8) data[2];
sp[3] = (__u8) data[3];
- st = (__u8) data[4];
for (i = 0; i < serial->num_ports; i++) {
mos7840_port = mos7840_get_port_private(serial->port[i]);
@@ -1300,7 +1299,6 @@ static int mos7840_write(struct tty_struct *tty, struct usb_serial_port *port,
struct urb *urb;
/* __u16 Data; */
const unsigned char *current_position = data;
- unsigned char *data1;
if (mos7840_port_paranoia_check(port, __func__))
return -1;
@@ -1361,7 +1359,6 @@ static int mos7840_write(struct tty_struct *tty, struct usb_serial_port *port,
mos7840_bulk_out_data_callback, mos7840_port);
}
- data1 = urb->transfer_buffer;
dev_dbg(&port->dev, "bulkout endpoint is %d\n", port->bulk_out_endpointAddress);
if (mos7840_port->has_led)
@@ -1697,7 +1694,6 @@ static void mos7840_change_port_settings(struct tty_struct *tty,
{
int baud;
unsigned cflag;
- unsigned iflag;
__u8 lData;
__u8 lParity;
__u8 lStop;
@@ -1729,7 +1725,6 @@ static void mos7840_change_port_settings(struct tty_struct *tty,
lParity = LCR_PAR_NONE;
cflag = tty->termios.c_cflag;
- iflag = tty->termios.c_iflag;
/* Change the number of bits */
switch (cflag & CSIZE) {
--
2.7.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH -next] USB: serial: mos7840: remove set but not used variables 'st, data1, iflag'
2018-10-26 12:25 [PATCH -next] USB: serial: mos7840: remove set but not used variables 'st, data1, iflag' YueHaibing
@ 2018-11-12 9:35 ` Johan Hovold
0 siblings, 0 replies; 2+ messages in thread
From: Johan Hovold @ 2018-11-12 9:35 UTC (permalink / raw)
To: YueHaibing; +Cc: johan, gregkh, linux-kernel, linux-usb
On Fri, Oct 26, 2018 at 08:25:49PM +0800, YueHaibing wrote:
> Fixes gcc '-Wunused-but-set-variable' warning:
>
> drivers/usb/serial/mos7840.c: In function 'mos7840_interrupt_callback':
> drivers/usb/serial/mos7840.c:604:14: warning:
> variable 'st' set but not used [-Wunused-but-set-variable]
>
> drivers/usb/serial/mos7840.c: In function 'mos7840_write':
> drivers/usb/serial/mos7840.c:1303:17: warning:
> variable 'data1' set but not used [-Wunused-but-set-variable]
>
> drivers/usb/serial/mos7840.c:1700:11: warning:
> variable 'iflag' set but not used [-Wunused-but-set-variable]
>
> They are never used since introduction in
> commit 3f5429746d91 ("USB: Moschip 7840 USB-Serial Driver")
>
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
Applied, thanks.
Johan
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-11-12 9:36 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-10-26 12:25 [PATCH -next] USB: serial: mos7840: remove set but not used variables 'st, data1, iflag' YueHaibing
2018-11-12 9:35 ` Johan Hovold
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).