linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Boris Brezillon <boris.brezillon@bootlin.com>
To: Vitor soares <vitor.soares@synopsys.com>
Cc: wsa@the-dreams.de, linux-i2c@vger.kernel.org, corbet@lwn.net,
	linux-doc@vger.kernel.org, gregkh@linuxfoundation.org,
	arnd@arndb.de, psroka@cadence.com, agolec@cadence.com,
	adouglas@cadence.com, bfolta@cadence.com, dkos@cadence.com,
	alicja@cadence.com, cwronka@cadence.com, sureshp@cadence.com,
	rafalc@cadence.com, thomas.petazzoni@bootlin.com, nm@ti.com,
	robh+dt@kernel.org, pawel.moll@arm.com, mark.rutland@arm.com,
	ijc+devicetree@hellion.org.uk, galak@codeaurora.org,
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
	geert@linux-m68k.org, linus.walleij@linaro.org,
	Xiang.Lin@synaptics.com, linux-gpio@vger.kernel.org,
	nsekhar@ti.com, pgaj@cadence.com, peda@axentia.se,
	mshettel@codeaurora.org, swboyd@chromium.org,
	joao.pinto@synopsys.com
Subject: Re: [PATCH v3 2/3] dt-bindings: i3c: Document Synopsys DesignWare I3C master bindings
Date: Mon, 12 Nov 2018 10:17:03 +0100	[thread overview]
Message-ID: <20181112101703.024ba1f3@bbrezillon> (raw)
In-Reply-To: <1541697251-20392-3-git-send-email-soares@synopsys.com>

On Thu,  8 Nov 2018 17:14:10 +0000
Vitor soares <vitor.soares@synopsys.com> wrote:

> Document Synopsys DesignWare I3C master module
> 
> Signed-off-by: Vitor soares <soares@synopsys.com>
> ---
> Changes in v3:
> - Remove dummy characters
> 
> Changes in v2:
> - Address the changes in Documentation/devicetree/bindings/i3c/i3c.txt
> - Add controller version on compatible string
> 
>  .../devicetree/bindings/i3c/snps,dw-i3c-master.txt | 42 ++++++++++++++++++++++
>  1 file changed, 42 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/i3c/snps,dw-i3c-master.txt
> 
> diff --git a/Documentation/devicetree/bindings/i3c/snps,dw-i3c-master.txt b/Documentation/devicetree/bindings/i3c/snps,dw-i3c-master.txt
> new file mode 100644
> index 0000000..b930c09
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/i3c/snps,dw-i3c-master.txt
> @@ -0,0 +1,42 @@
> +Bindings for Synopsys DesignWare I3C master block
> +=================================================
> +
> +Required properties:
> +--------------------
> +- compatible: shall be "snps,dw-i3c-master-1.00a"
> +- clocks: shall reference the core_clk

Are you sure this IP only requires only one clock? If you're unsure,
you'd better have a clock-names prop.

> +- interrupts: the interrupt line connected to this I3C master
> +- reg: Offset and length of I3C master registers
> +
> +Mandatory properties defined by the generic binding (see
> +Documentation/devicetree/bindings/i3c/i3c.txt for more details):
> +
> +- #address-cells: shall be set to 3
> +- #size-cells: shall be set to 0
> +
> +Optional properties defined by the generic binding (see
> +Documentation/devicetree/bindings/i3c/i3c.txt for more details):
> +
> +- i2c-scl-hz
> +- i3c-scl-hz
> +
> +I3C device connected on the bus follow the generic description (see
> +Documentation/devicetree/bindings/i3c/i3c.txt for more details).
> +
> +Example:
> +
> +	i3c-master@2000 {
> +		compatible = "snps,dw-i3c-master-1.00a";
> +		#address-cells = <3>;
> +		#size-cells = <0>;
> +		reg = <0x02000 0x1000>;
> +		interrupts = <0>;
> +		clocks = <&i3cclk>;
> +
> +		eeprom@57{
> +			compatible = "atmel,24c01";
> +			reg = < 0x57 0x0 0x10>;

			       ^ remove this white space.

> +			pagesize = <0x8>;
> +		};
> +	};
> +


  reply	other threads:[~2018-11-12  9:17 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-11-08 17:14 [PATCH v3 0/3] Add driver for Synopsys DesignWare I3C master IP Vitor soares
2018-11-08 17:14 ` [PATCH v3 1/3] i3c: master: Add driver for Synopsys DesignWare IP Vitor soares
2018-11-08 17:14 ` [PATCH v3 2/3] dt-bindings: i3c: Document Synopsys DesignWare I3C master bindings Vitor soares
2018-11-12  9:17   ` Boris Brezillon [this message]
2018-11-13 11:11     ` vitor
2018-11-13  2:09   ` Rob Herring
2018-11-13 11:20     ` vitor
2018-11-08 17:14 ` [PATCH v3 3/3] MAINTAINERS: Add myself as the dw-i3c-master module maintainer Vitor soares
2018-11-11 17:40 ` [PATCH v3 0/3] Add driver for Synopsys DesignWare I3C master IP Greg KH
2018-11-12  9:12 ` Boris Brezillon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20181112101703.024ba1f3@bbrezillon \
    --to=boris.brezillon@bootlin.com \
    --cc=Xiang.Lin@synaptics.com \
    --cc=adouglas@cadence.com \
    --cc=agolec@cadence.com \
    --cc=alicja@cadence.com \
    --cc=arnd@arndb.de \
    --cc=bfolta@cadence.com \
    --cc=corbet@lwn.net \
    --cc=cwronka@cadence.com \
    --cc=devicetree@vger.kernel.org \
    --cc=dkos@cadence.com \
    --cc=galak@codeaurora.org \
    --cc=geert@linux-m68k.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=ijc+devicetree@hellion.org.uk \
    --cc=joao.pinto@synopsys.com \
    --cc=linus.walleij@linaro.org \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-gpio@vger.kernel.org \
    --cc=linux-i2c@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=mshettel@codeaurora.org \
    --cc=nm@ti.com \
    --cc=nsekhar@ti.com \
    --cc=pawel.moll@arm.com \
    --cc=peda@axentia.se \
    --cc=pgaj@cadence.com \
    --cc=psroka@cadence.com \
    --cc=rafalc@cadence.com \
    --cc=robh+dt@kernel.org \
    --cc=sureshp@cadence.com \
    --cc=swboyd@chromium.org \
    --cc=thomas.petazzoni@bootlin.com \
    --cc=vitor.soares@synopsys.com \
    --cc=wsa@the-dreams.de \
    --subject='Re: [PATCH v3 2/3] dt-bindings: i3c: Document Synopsys DesignWare I3C master bindings' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).