[PATCH] mfd: at91-usart: Add platform dependency

[PATCH] mfd: at91-usart: Add platform dependency

[Jean Delvare]

It doesn't make sense to present option MFD_AT91_USART by default if
not building an AT91 kernel, as the drivers which depend on it are
not available.

Signed-off-by: Jean Delvare <jdelvare@suse.de>
Fixes: 7d3aa342cef7 ("mfd: at91-usart: Add MFD driver for USART")
Cc: Radu Pirea <radu.pirea@microchip.com>
Cc: Lee Jones <lee.jones@linaro.org>
---
As a side note, maybe it would make sense to have SPI_AT91_USART
select MFD_AT91_USART instead of depend on it, so that
MFD_AT91_USART could be hidden?

 drivers/mfd/Kconfig |    1 +
 1 file changed, 1 insertion(+)

--- linux-4.20-rc2.orig/drivers/mfd/Kconfig	2018-11-12 09:34:20.096038788 +0100
+++ linux-4.20-rc2/drivers/mfd/Kconfig	2018-11-12 10:39:51.102170181 +0100
@@ -102,6 +102,7 @@ config MFD_AAT2870_CORE
 config MFD_AT91_USART
 	tristate "AT91 USART Driver"
 	select MFD_CORE
+	depends on ARCH_AT91 || COMPILE_TEST
 	help
 	  Select this to get support for AT91 USART IP. This is a wrapper
 	  over at91-usart-serial driver and usart-spi-driver. Only one function


-- 
Jean Delvare
SUSE L3 Support

Re: [PATCH] mfd: at91-usart: Add platform dependency

[Lee Jones]

On Mon, 12 Nov 2018, Jean Delvare wrote:

> It doesn't make sense to present option MFD_AT91_USART by default if
> not building an AT91 kernel, as the drivers which depend on it are
> not available.
> 
> Signed-off-by: Jean Delvare <jdelvare@suse.de>
> Fixes: 7d3aa342cef7 ("mfd: at91-usart: Add MFD driver for USART")
> Cc: Radu Pirea <radu.pirea@microchip.com>
> Cc: Lee Jones <lee.jones@linaro.org>
> ---
> As a side note, maybe it would make sense to have SPI_AT91_USART
> select MFD_AT91_USART instead of depend on it, so that
> MFD_AT91_USART could be hidden?
> 
>  drivers/mfd/Kconfig |    1 +
>  1 file changed, 1 insertion(+)

Applied, thanks.

-- 
Lee Jones [李琼斯]
Linaro Services Technical Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog