* [PATCH] drm/arm/malidp: Consider rotation memory requirement in case of AFBC framebuffer
@ 2018-11-09 10:37 Ayan Halder
2018-11-09 10:46 ` Liviu Dudau
2018-11-12 12:51 ` Alexandru-Cosmin Gheorghe
0 siblings, 2 replies; 3+ messages in thread
From: Ayan Halder @ 2018-11-09 10:37 UTC (permalink / raw)
To: Ayan Halder, Liviu Dudau, Brian Starkey, malidp, airlied,
dri-devel, linux-kernel
Cc: nd
Rotation memory for layers is shared with AFBC decoder block. Thus one needs to
calculate rotation memory requirement in case of AFBC framebuffer. This is
used later to verify if it can be sufficed by the hardware rotation memory
availibility.
Fixes: 66da13a ("drm/arm/malidp: Validate rotations for compressed/uncompressed framebuffers for each layer")
Signed-off-by: Ayan Kumar halder <ayan.halder@arm.com>
---
drivers/gpu/drm/arm/malidp_planes.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/arm/malidp_planes.c b/drivers/gpu/drm/arm/malidp_planes.c
index c9a6d3e..3f4dc64 100644
--- a/drivers/gpu/drm/arm/malidp_planes.c
+++ b/drivers/gpu/drm/arm/malidp_planes.c
@@ -470,7 +470,7 @@ static int malidp_de_plane_check(struct drm_plane *plane,
}
ms->rotmem_size = 0;
- if (state->rotation & MALIDP_ROTATED_MASK) {
+ if ((state->rotation & MALIDP_ROTATED_MASK) || fb->modifier) {
int val;
val = mp->hwdev->hw->rotmem_required(mp->hwdev, state->crtc_w,
--
2.7.4
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] drm/arm/malidp: Consider rotation memory requirement in case of AFBC framebuffer
2018-11-09 10:37 [PATCH] drm/arm/malidp: Consider rotation memory requirement in case of AFBC framebuffer Ayan Halder
@ 2018-11-09 10:46 ` Liviu Dudau
2018-11-12 12:51 ` Alexandru-Cosmin Gheorghe
1 sibling, 0 replies; 3+ messages in thread
From: Liviu Dudau @ 2018-11-09 10:46 UTC (permalink / raw)
To: Ayan Halder; +Cc: Brian Starkey, malidp, airlied, dri-devel, linux-kernel, nd
On Fri, Nov 09, 2018 at 10:37:19AM +0000, Ayan Halder wrote:
> Rotation memory for layers is shared with AFBC decoder block. Thus one needs to
> calculate rotation memory requirement in case of AFBC framebuffer. This is
> used later to verify if it can be sufficed by the hardware rotation memory
> availibility.
>
> Fixes: 66da13a ("drm/arm/malidp: Validate rotations for compressed/uncompressed framebuffers for each layer")
> Signed-off-by: Ayan Kumar halder <ayan.halder@arm.com>
Acked-by: Liviu Dudau <liviu.dudau@arm.com>
> ---
> drivers/gpu/drm/arm/malidp_planes.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/arm/malidp_planes.c b/drivers/gpu/drm/arm/malidp_planes.c
> index c9a6d3e..3f4dc64 100644
> --- a/drivers/gpu/drm/arm/malidp_planes.c
> +++ b/drivers/gpu/drm/arm/malidp_planes.c
> @@ -470,7 +470,7 @@ static int malidp_de_plane_check(struct drm_plane *plane,
> }
>
> ms->rotmem_size = 0;
> - if (state->rotation & MALIDP_ROTATED_MASK) {
> + if ((state->rotation & MALIDP_ROTATED_MASK) || fb->modifier) {
> int val;
>
> val = mp->hwdev->hw->rotmem_required(mp->hwdev, state->crtc_w,
> --
> 2.7.4
>
--
====================
| I would like to |
| fix the world, |
| but they're not |
| giving me the |
\ source code! /
---------------
¯\_(ツ)_/¯
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] drm/arm/malidp: Consider rotation memory requirement in case of AFBC framebuffer
2018-11-09 10:37 [PATCH] drm/arm/malidp: Consider rotation memory requirement in case of AFBC framebuffer Ayan Halder
2018-11-09 10:46 ` Liviu Dudau
@ 2018-11-12 12:51 ` Alexandru-Cosmin Gheorghe
1 sibling, 0 replies; 3+ messages in thread
From: Alexandru-Cosmin Gheorghe @ 2018-11-12 12:51 UTC (permalink / raw)
To: Ayan Halder
Cc: Liviu Dudau, Brian Starkey, malidp, airlied, dri-devel, linux-kernel, nd
Hi Ayan,
On Fri, Nov 09, 2018 at 10:37:19AM +0000, Ayan Halder wrote:
> Rotation memory for layers is shared with AFBC decoder block. Thus one needs to
> calculate rotation memory requirement in case of AFBC framebuffer. This is
> used later to verify if it can be sufficed by the hardware rotation memory
> availibility.
>
> Fixes: 66da13a ("drm/arm/malidp: Validate rotations for compressed/uncompressed framebuffers for each layer")
Reviewed-by: Alexandru Gheorghe <alexandru-cosmin.gheorghe@arm.com>
> Signed-off-by: Ayan Kumar halder <ayan.halder@arm.com>
> ---
> drivers/gpu/drm/arm/malidp_planes.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/arm/malidp_planes.c b/drivers/gpu/drm/arm/malidp_planes.c
> index c9a6d3e..3f4dc64 100644
> --- a/drivers/gpu/drm/arm/malidp_planes.c
> +++ b/drivers/gpu/drm/arm/malidp_planes.c
> @@ -470,7 +470,7 @@ static int malidp_de_plane_check(struct drm_plane *plane,
> }
>
> ms->rotmem_size = 0;
> - if (state->rotation & MALIDP_ROTATED_MASK) {
> + if ((state->rotation & MALIDP_ROTATED_MASK) || fb->modifier) {
> int val;
>
> val = mp->hwdev->hw->rotmem_required(mp->hwdev, state->crtc_w,
> --
> 2.7.4
>
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel
--
Cheers,
Alex G
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-11-12 12:51 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-11-09 10:37 [PATCH] drm/arm/malidp: Consider rotation memory requirement in case of AFBC framebuffer Ayan Halder
2018-11-09 10:46 ` Liviu Dudau
2018-11-12 12:51 ` Alexandru-Cosmin Gheorghe
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).