From: Andreas Kemnade <andreas@kemnade.info>
To: Sebastian Reichel <sebastian.reichel@collabora.com>
Cc: marcel@holtmann.org, johan.hedberg@gmail.com,
linux-bluetooth@vger.kernel.org, linux-kernel@vger.kernel.org,
devicetree@vger.kernel.org, letux-kernel@openphoenux.org
Subject: Re: [PATCH RFC] bluetooth: add uart h4 devices via serdev/devicetree
Date: Mon, 12 Nov 2018 21:59:34 +0100 [thread overview]
Message-ID: <20181112215812.18ebca35@aktux> (raw)
In-Reply-To: <20181111024648.7rt7rlhaqihtqecv@earth.universe>
[-- Attachment #1: Type: text/plain, Size: 931 bytes --]
Hi,
On Sun, 11 Nov 2018 03:46:48 +0100
Sebastian Reichel <sebastian.reichel@collabora.com> wrote:
> Hi,
>
> On Sun, Nov 11, 2018 at 12:20:34AM +0100, Andreas Kemnade wrote:
> > This is a first try to be able to use h4 devices specified in
> > the devicetree, so you do not need to call hciattach and
> > it can be automatically probed.
> >
> > Of course, proper devicetree bindings documentation is
> > missing. And also you would extend that by regulator/
> > enable gpio settings.
> >
> > But before proceeding further it should be checked if the
> > general way of doing things is right.
> >
> > Signed-off-by: Andreas Kemnade <andreas@kemnade.info>
> > ---
>
> Patch looks good to me, just one note
>
I found one thing myself:
Shouldn't we have a generic compatible string like "generic-h4".
ehci-platform.c has for example:
{ .compatible = "generic-ehci", },
Regards,
Andreas
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2018-11-12 20:59 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-10 23:20 [PATCH RFC] bluetooth: add uart h4 devices via serdev/devicetree Andreas Kemnade
2018-11-11 2:46 ` Sebastian Reichel
2018-11-12 20:59 ` Andreas Kemnade [this message]
2018-11-12 21:19 ` [Letux-kernel] " H. Nikolaus Schaller
2018-11-12 22:27 ` Sebastian Reichel
2018-11-13 0:17 ` Rob Herring
2018-11-13 16:01 ` Andreas Kemnade
2018-11-14 7:51 ` Marcel Holtmann
2018-11-14 11:13 ` Andreas Kemnade
2018-11-16 19:46 ` Andreas Kemnade
2018-11-16 19:58 ` Marcel Holtmann
2019-01-04 5:44 ` Andreas Kemnade
2019-01-04 9:07 ` Marcel Holtmann
2019-01-04 19:57 ` Andreas Kemnade
2019-01-12 11:16 ` Jon Nettleton
2019-01-12 12:15 ` H. Nikolaus Schaller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181112215812.18ebca35@aktux \
--to=andreas@kemnade.info \
--cc=devicetree@vger.kernel.org \
--cc=johan.hedberg@gmail.com \
--cc=letux-kernel@openphoenux.org \
--cc=linux-bluetooth@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marcel@holtmann.org \
--cc=sebastian.reichel@collabora.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).