* [PATCH v6 0/2] arm64: dts: qcom: pm8998: Add die temperature channel node to the ADC
@ 2018-11-12 22:11 Matthias Kaehlcke
2018-11-12 22:11 ` [PATCH v6 1/2] dt-bindings: iio: vadc: Add unit address to ADC channel node in example Matthias Kaehlcke
` (2 more replies)
0 siblings, 3 replies; 6+ messages in thread
From: Matthias Kaehlcke @ 2018-11-12 22:11 UTC (permalink / raw)
To: Andy Gross, David Brown, Rob Herring, Mark Rutland,
Jonathan Cameron, Hartmut Knaack, Lars-Peter Clausen,
Peter Meerwald-Stadler
Cc: linux-arm-msm, linux-soc, devicetree, linux-iio, linux-kernel,
Douglas Anderson, Matthias Kaehlcke
This series adds a channel for the die temperature to the QCOM SPMI
PMIC5 ADC. It also fixes an example in the DT documentation.
Matthias Kaehlcke (2):
dt-bindings: iio: vadc: Add unit address to ADC channel node in
example
arm64: dts: qcom: pm8998: Add die temperature channel node to the ADC
.../devicetree/bindings/iio/adc/qcom,spmi-vadc.txt | 6 +++++-
arch/arm64/boot/dts/qcom/pm8998.dtsi | 5 +++++
2 files changed, 10 insertions(+), 1 deletion(-)
--
2.19.1.930.g4563a0d9d0-goog
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH v6 1/2] dt-bindings: iio: vadc: Add unit address to ADC channel node in example
2018-11-12 22:11 [PATCH v6 0/2] arm64: dts: qcom: pm8998: Add die temperature channel node to the ADC Matthias Kaehlcke
@ 2018-11-12 22:11 ` Matthias Kaehlcke
2018-11-16 18:13 ` Jonathan Cameron
2018-11-12 22:11 ` [PATCH v6 2/2] arm64: dts: qcom: pm8998: Add die temperature channel node to the ADC Matthias Kaehlcke
2018-11-14 18:20 ` [PATCH v6 0/2] " Andy Gross
2 siblings, 1 reply; 6+ messages in thread
From: Matthias Kaehlcke @ 2018-11-12 22:11 UTC (permalink / raw)
To: Andy Gross, David Brown, Rob Herring, Mark Rutland,
Jonathan Cameron, Hartmut Knaack, Lars-Peter Clausen,
Peter Meerwald-Stadler
Cc: linux-arm-msm, linux-soc, devicetree, linux-iio, linux-kernel,
Douglas Anderson, Matthias Kaehlcke
The node has a reg property, therefore its name should include a unit
address. Also change the name from 'usb_id_nopull' to 'adc-chan', which
is the preferred name for ADC channel nodes.
Include headers for constants used in the example.
Signed-off-by: Matthias Kaehlcke <mka@chromium.org>
Reviewed-by: Douglas Anderson <dianders@chromium.org>
---
Changes in v6:
- changed node name to adc-chan@
- added includes for constants used in the example
- updated commit message
- added 'Reviewed-by: Douglas Anderson <dianders@chromium.org>' tag
Changes in v5:
- patch added to the series
---
.../devicetree/bindings/iio/adc/qcom,spmi-vadc.txt | 6 +++++-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/Documentation/devicetree/bindings/iio/adc/qcom,spmi-vadc.txt b/Documentation/devicetree/bindings/iio/adc/qcom,spmi-vadc.txt
index b3c86f4ac7cdb..c81993f8d8c39 100644
--- a/Documentation/devicetree/bindings/iio/adc/qcom,spmi-vadc.txt
+++ b/Documentation/devicetree/bindings/iio/adc/qcom,spmi-vadc.txt
@@ -140,6 +140,10 @@ VADC_GND_REF and VADC_VDD_VADC.
Example:
+#include <dt-bindings/iio/qcom,spmi-vadc.h>
+#include <linux/irq.h>
+/* ... */
+
/* VADC node */
pmic_vadc: vadc@3100 {
compatible = "qcom,spmi-vadc";
@@ -151,7 +155,7 @@ Example:
io-channel-ranges;
/* Channel node */
- usb_id_nopull {
+ adc-chan@VADC_LR_MUX10_USB_ID {
reg = <VADC_LR_MUX10_USB_ID>;
qcom,decimation = <512>;
qcom,ratiometric;
--
2.19.1.930.g4563a0d9d0-goog
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH v6 2/2] arm64: dts: qcom: pm8998: Add die temperature channel node to the ADC
2018-11-12 22:11 [PATCH v6 0/2] arm64: dts: qcom: pm8998: Add die temperature channel node to the ADC Matthias Kaehlcke
2018-11-12 22:11 ` [PATCH v6 1/2] dt-bindings: iio: vadc: Add unit address to ADC channel node in example Matthias Kaehlcke
@ 2018-11-12 22:11 ` Matthias Kaehlcke
2018-11-14 18:20 ` [PATCH v6 0/2] " Andy Gross
2 siblings, 0 replies; 6+ messages in thread
From: Matthias Kaehlcke @ 2018-11-12 22:11 UTC (permalink / raw)
To: Andy Gross, David Brown, Rob Herring, Mark Rutland,
Jonathan Cameron, Hartmut Knaack, Lars-Peter Clausen,
Peter Meerwald-Stadler
Cc: linux-arm-msm, linux-soc, devicetree, linux-iio, linux-kernel,
Douglas Anderson, Matthias Kaehlcke
Add a channel node for the die temperature to the ADC.
Signed-off-by: Matthias Kaehlcke <mka@chromium.org>
Reviewed-by: Douglas Anderson <dianders@chromium.org>
---
Changes in v6:
- changed node name to 'adc-chan@'
Changes in v5:
- added unit address to 'die-temp' node
Changes in v4:
- none
Changes in v3:
- fixed separator in commit message
- remove duplicate 'Signed-off-by' tag
Changes in v2:
- none
---
arch/arm64/boot/dts/qcom/pm8998.dtsi | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/arch/arm64/boot/dts/qcom/pm8998.dtsi b/arch/arm64/boot/dts/qcom/pm8998.dtsi
index 048f19fa01504..f1025a50c227b 100644
--- a/arch/arm64/boot/dts/qcom/pm8998.dtsi
+++ b/arch/arm64/boot/dts/qcom/pm8998.dtsi
@@ -75,6 +75,11 @@
#address-cells = <1>;
#size-cells = <0>;
#io-channel-cells = <1>;
+
+ adc-chan@ADC5_DIE_TEMP {
+ reg = <ADC5_DIE_TEMP>;
+ label = "die_temp";
+ };
};
rtc@6000 {
--
2.19.1.930.g4563a0d9d0-goog
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH v6 0/2] arm64: dts: qcom: pm8998: Add die temperature channel node to the ADC
2018-11-12 22:11 [PATCH v6 0/2] arm64: dts: qcom: pm8998: Add die temperature channel node to the ADC Matthias Kaehlcke
2018-11-12 22:11 ` [PATCH v6 1/2] dt-bindings: iio: vadc: Add unit address to ADC channel node in example Matthias Kaehlcke
2018-11-12 22:11 ` [PATCH v6 2/2] arm64: dts: qcom: pm8998: Add die temperature channel node to the ADC Matthias Kaehlcke
@ 2018-11-14 18:20 ` Andy Gross
2 siblings, 0 replies; 6+ messages in thread
From: Andy Gross @ 2018-11-14 18:20 UTC (permalink / raw)
To: Matthias Kaehlcke
Cc: David Brown, Rob Herring, Mark Rutland, Jonathan Cameron,
Hartmut Knaack, Lars-Peter Clausen, Peter Meerwald-Stadler,
linux-arm-msm, linux-soc, devicetree, linux-iio, linux-kernel,
Douglas Anderson
On Mon, Nov 12, 2018 at 02:11:24PM -0800, Matthias Kaehlcke wrote:
> This series adds a channel for the die temperature to the QCOM SPMI
> PMIC5 ADC. It also fixes an example in the DT documentation.
>
> Matthias Kaehlcke (2):
> dt-bindings: iio: vadc: Add unit address to ADC channel node in
> example
> arm64: dts: qcom: pm8998: Add die temperature channel node to the ADC
>
I queued both of these. Thanks for updating these.
Andy
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH v6 1/2] dt-bindings: iio: vadc: Add unit address to ADC channel node in example
2018-11-12 22:11 ` [PATCH v6 1/2] dt-bindings: iio: vadc: Add unit address to ADC channel node in example Matthias Kaehlcke
@ 2018-11-16 18:13 ` Jonathan Cameron
2018-11-16 18:14 ` Jonathan Cameron
0 siblings, 1 reply; 6+ messages in thread
From: Jonathan Cameron @ 2018-11-16 18:13 UTC (permalink / raw)
To: Matthias Kaehlcke
Cc: Andy Gross, David Brown, Rob Herring, Mark Rutland,
Hartmut Knaack, Lars-Peter Clausen, Peter Meerwald-Stadler,
linux-arm-msm, linux-soc, devicetree, linux-iio, linux-kernel,
Douglas Anderson
On Mon, 12 Nov 2018 14:11:25 -0800
Matthias Kaehlcke <mka@chromium.org> wrote:
> The node has a reg property, therefore its name should include a unit
> address. Also change the name from 'usb_id_nopull' to 'adc-chan', which
> is the preferred name for ADC channel nodes.
>
> Include headers for constants used in the example.
>
> Signed-off-by: Matthias Kaehlcke <mka@chromium.org>
> Reviewed-by: Douglas Anderson <dianders@chromium.org>
Looks good to me. I'd just like to leave it a little longer
to give Rob or other device tree specialists a change
to take one last look at it.
Ping me if I seem to have forgotten about it!
Thanks,
Jonathan
> ---
> Changes in v6:
> - changed node name to adc-chan@
> - added includes for constants used in the example
> - updated commit message
> - added 'Reviewed-by: Douglas Anderson <dianders@chromium.org>' tag
>
> Changes in v5:
> - patch added to the series
> ---
> .../devicetree/bindings/iio/adc/qcom,spmi-vadc.txt | 6 +++++-
> 1 file changed, 5 insertions(+), 1 deletion(-)
>
> diff --git a/Documentation/devicetree/bindings/iio/adc/qcom,spmi-vadc.txt b/Documentation/devicetree/bindings/iio/adc/qcom,spmi-vadc.txt
> index b3c86f4ac7cdb..c81993f8d8c39 100644
> --- a/Documentation/devicetree/bindings/iio/adc/qcom,spmi-vadc.txt
> +++ b/Documentation/devicetree/bindings/iio/adc/qcom,spmi-vadc.txt
> @@ -140,6 +140,10 @@ VADC_GND_REF and VADC_VDD_VADC.
>
> Example:
>
> +#include <dt-bindings/iio/qcom,spmi-vadc.h>
> +#include <linux/irq.h>
> +/* ... */
> +
> /* VADC node */
> pmic_vadc: vadc@3100 {
> compatible = "qcom,spmi-vadc";
> @@ -151,7 +155,7 @@ Example:
> io-channel-ranges;
>
> /* Channel node */
> - usb_id_nopull {
> + adc-chan@VADC_LR_MUX10_USB_ID {
> reg = <VADC_LR_MUX10_USB_ID>;
> qcom,decimation = <512>;
> qcom,ratiometric;
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH v6 1/2] dt-bindings: iio: vadc: Add unit address to ADC channel node in example
2018-11-16 18:13 ` Jonathan Cameron
@ 2018-11-16 18:14 ` Jonathan Cameron
0 siblings, 0 replies; 6+ messages in thread
From: Jonathan Cameron @ 2018-11-16 18:14 UTC (permalink / raw)
To: Matthias Kaehlcke
Cc: Andy Gross, David Brown, Rob Herring, Mark Rutland,
Hartmut Knaack, Lars-Peter Clausen, Peter Meerwald-Stadler,
linux-arm-msm, linux-soc, devicetree, linux-iio, linux-kernel,
Douglas Anderson
On Fri, 16 Nov 2018 18:13:38 +0000
Jonathan Cameron <jic23@kernel.org> wrote:
> On Mon, 12 Nov 2018 14:11:25 -0800
> Matthias Kaehlcke <mka@chromium.org> wrote:
>
> > The node has a reg property, therefore its name should include a unit
> > address. Also change the name from 'usb_id_nopull' to 'adc-chan', which
> > is the preferred name for ADC channel nodes.
> >
> > Include headers for constants used in the example.
> >
> > Signed-off-by: Matthias Kaehlcke <mka@chromium.org>
> > Reviewed-by: Douglas Anderson <dianders@chromium.org>
> Looks good to me. I'd just like to leave it a little longer
> to give Rob or other device tree specialists a change
> to take one last look at it.
>
> Ping me if I seem to have forgotten about it!
>
Ah, I should have read on. Already queued. That's fine with me.
Jonathan
> Thanks,
>
> Jonathan
> > ---
> > Changes in v6:
> > - changed node name to adc-chan@
> > - added includes for constants used in the example
> > - updated commit message
> > - added 'Reviewed-by: Douglas Anderson <dianders@chromium.org>' tag
> >
> > Changes in v5:
> > - patch added to the series
> > ---
> > .../devicetree/bindings/iio/adc/qcom,spmi-vadc.txt | 6 +++++-
> > 1 file changed, 5 insertions(+), 1 deletion(-)
> >
> > diff --git a/Documentation/devicetree/bindings/iio/adc/qcom,spmi-vadc.txt b/Documentation/devicetree/bindings/iio/adc/qcom,spmi-vadc.txt
> > index b3c86f4ac7cdb..c81993f8d8c39 100644
> > --- a/Documentation/devicetree/bindings/iio/adc/qcom,spmi-vadc.txt
> > +++ b/Documentation/devicetree/bindings/iio/adc/qcom,spmi-vadc.txt
> > @@ -140,6 +140,10 @@ VADC_GND_REF and VADC_VDD_VADC.
> >
> > Example:
> >
> > +#include <dt-bindings/iio/qcom,spmi-vadc.h>
> > +#include <linux/irq.h>
> > +/* ... */
> > +
> > /* VADC node */
> > pmic_vadc: vadc@3100 {
> > compatible = "qcom,spmi-vadc";
> > @@ -151,7 +155,7 @@ Example:
> > io-channel-ranges;
> >
> > /* Channel node */
> > - usb_id_nopull {
> > + adc-chan@VADC_LR_MUX10_USB_ID {
> > reg = <VADC_LR_MUX10_USB_ID>;
> > qcom,decimation = <512>;
> > qcom,ratiometric;
>
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2018-11-16 18:14 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-11-12 22:11 [PATCH v6 0/2] arm64: dts: qcom: pm8998: Add die temperature channel node to the ADC Matthias Kaehlcke
2018-11-12 22:11 ` [PATCH v6 1/2] dt-bindings: iio: vadc: Add unit address to ADC channel node in example Matthias Kaehlcke
2018-11-16 18:13 ` Jonathan Cameron
2018-11-16 18:14 ` Jonathan Cameron
2018-11-12 22:11 ` [PATCH v6 2/2] arm64: dts: qcom: pm8998: Add die temperature channel node to the ADC Matthias Kaehlcke
2018-11-14 18:20 ` [PATCH v6 0/2] " Andy Gross
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).