From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A9927C43441 for ; Mon, 12 Nov 2018 22:19:26 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 72BC22241E for ; Mon, 12 Nov 2018 22:19:26 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 72BC22241E Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730744AbeKMIOc (ORCPT ); Tue, 13 Nov 2018 03:14:32 -0500 Received: from mx1.redhat.com ([209.132.183.28]:48858 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730567AbeKMIOc (ORCPT ); Tue, 13 Nov 2018 03:14:32 -0500 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id B23B3308A959; Mon, 12 Nov 2018 22:19:24 +0000 (UTC) Received: from localhost (ovpn-200-16.brq.redhat.com [10.40.200.16]) by smtp.corp.redhat.com (Postfix) with ESMTPS id A6E825D961; Mon, 12 Nov 2018 22:19:22 +0000 (UTC) Date: Mon, 12 Nov 2018 23:19:17 +0100 From: Stefano Brivio To: Nathan Chancellor Cc: "David S. Miller" , Sabrina Dubroca , netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] geneve: Add missing braces in addr6 initializer Message-ID: <20181112231917.4f2f07b5@redhat.com> In-Reply-To: <20181112221248.11477-1-natechancellor@gmail.com> References: <20181112221248.11477-1-natechancellor@gmail.com> Organization: Red Hat MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.41]); Mon, 12 Nov 2018 22:19:24 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 12 Nov 2018 15:12:48 -0700 Nathan Chancellor wrote: > Clang warns: > > drivers/net/geneve.c:428:29: error: suggest braces around initialization > of subobject [-Werror,-Wmissing-braces] > struct in6_addr addr6 = { 0 }; > ^ > {} > > Fixes: a07966447f39 ("geneve: ICMP error lookup handler") > Signed-off-by: Nathan Chancellor Thanks for spotting this. By the way, I guess you should indicate in the subject when patches are meant for net-next. Reviewed-by: Stefano Brivio -- Stefano