archive mirror
 help / color / mirror / Atom feed
From: Tom Burkart <>
To: Linux kernel mailing list <>
Cc: Tom Burkart <>
Subject: [PATCH v6 0/4] PPS: pps-gpio PPS ECHO implementation
Date: Tue, 13 Nov 2018 14:40:03 +1100	[thread overview]
Message-ID: <> (raw)

Hi all,
please find attached the PPS-GPIO PPS ECHO implementation patch. The
driver claims to have echo functionality in the sysfs interface but this
functionality is not present.  This patch provides this functionality.

Parts 1 and 2 of the patch change the original driver from the number
based GPIO API to the descriptor based API.  This does break the backward
compatibility of all devicetree descriptions for this driver as the
descriptor based API appends either "-gpios" or "-gpio" to all names
passed to it and then tries to find a match in the devicetree.

Parts 3 and 4 then add the PPS ECHO functionality.  This is enabled if a
"echo-gpios" entry is found in the devicetree.

Changes in v4:
There is a bugfix in part 2 that was returning an uninitialised variable
and juggling some code that speeds up the probe by not running code when
not using PPS ECHO.

Changes in v5:
Meet all requirements of checkpatch

Changes in v6:
Cosmetic changes to code layout

On the linuxpps mailing list it was suggested to use a hrtimer for
resetting the GPIO ECHO active state to the inactive state.
Please also comment on whether a hrtimer is necessary/desirable for the
purpose of resetting the echo pin active state.  I am happy to implement
it if there is a need.

Please install, test and comment as it is now a quite major change to
the driver.
Please do send suggestions for improvement.

Tom Burkart

Tom Burkart (4):
  dt-bindings: pps: descriptor-based gpio, capture-clear addition
  pps: descriptor-based gpio, capture-clear addition
  dt-bindings: pps: pps-gpio PPS ECHO implementation
  pps: pps-gpio pps-echo implementation

 Documentation/devicetree/bindings/pps/pps-gpio.txt |  15 ++-
 drivers/pps/clients/pps-gpio.c                     | 133 +++++++++++++++++----
 include/linux/pps-gpio.h                           |   5 +-
 3 files changed, 126 insertions(+), 27 deletions(-)


             reply	other threads:[~2018-11-13  4:05 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-11-13  3:40 Tom Burkart [this message]
2018-11-13  3:40 ` [PATCH v6 1/4] dt-bindings: pps: descriptor-based gpio, capture-clear addition Tom Burkart
2018-11-13  3:40   ` [PATCH v6 2/4] " Tom Burkart
2018-11-13  3:40     ` [PATCH v6 3/4] dt-bindings: pps: pps-gpio PPS ECHO implementation Tom Burkart
2018-11-13  3:40       ` [PATCH v6 4/4] pps: pps-gpio pps-echo implementation Tom Burkart
2018-11-13 15:14     ` [PATCH v6 2/4] pps: descriptor-based gpio, capture-clear addition Richard Cochran
2018-11-14  9:25       ` tom burkart
2018-11-17 11:11     ` Philipp Zabel
2018-11-17 11:24       ` tom burkart

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).