From: Darren Hart <dvhart@infradead.org>
To: Loic WEI YU NENG <loic.wyn@gmail.com>
Cc: andy.shevchenko@gmail.com, ike.pan@canonical.com,
andy@infradead.org, trivial@kernel.org,
platform-driver-x86@vger.kernel.org,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] ideapad-laptop: Add Lenovo Yoga 2 13 to the no_hw_rfkill DMI list
Date: Tue, 13 Nov 2018 21:16:03 -0800 [thread overview]
Message-ID: <20181114051603.GF7890@fedora.eng.vmware.com> (raw)
In-Reply-To: <20181114022245.5798-1-loic.wyn@gmail.com>
On Tue, Nov 13, 2018 at 06:22:45PM -0800, Loic WEI YU NENG wrote:
> Some Lenovo ideapad models lack a physical rfkill switch.
> On Lenovo models Yoga 2 13, ideapad-laptop would wrongly report all
> radios as blocked by hardware which caused wireless network connections
> to fail.
> Add these models without an rfkill switch to the no_hw_rfkill list.
>
> Signed-off-by: Loic WEI YU NENG <loic.wyn@gmail.com>
Thank you for the patch.
In the future, please be sure to check MAINTAINERS and include the
relevant lists, now Cc'd.
I see this in the context of your patch, but can you confirm the current
driver fails to match your system? It contains the following, which I
would expect to match:
.ident = "Lenovo Yoga 2 11 / 13 / Pro",
.matches = {
DMI_MATCH(DMI_SYS_VENDOR, "LENOVO"),
DMI_MATCH(DMI_BOARD_NAME, "Yoga2"),
},
If it doesn't match, what does dmidecode report for SYS_VENDOR and
BOARD_NAME on your system? Perhaps we need to make the above more
generic.
> ---
> drivers/platform/x86/ideapad-laptop.c | 7 +++++++
> 1 file changed, 7 insertions(+)
>
> diff --git a/drivers/platform/x86/ideapad-laptop.c b/drivers/platform/x86/ideapad-laptop.c
> index b6489cba2985..1589dffab9fa 100644
> --- a/drivers/platform/x86/ideapad-laptop.c
> +++ b/drivers/platform/x86/ideapad-laptop.c
> @@ -1188,6 +1188,13 @@ static const struct dmi_system_id no_hw_rfkill_list[] = {
> DMI_MATCH(DMI_BOARD_NAME, "Yoga2"),
> },
> },
> + {
> + .ident = "Lenovo Yoga 2 13",
> + .matches = {
> + DMI_MATCH(DMI_SYS_VENDOR, "LENOVO"),
> + DMI_MATCH(DMI_PRODUCT_VERSION, "Yoga 2 13"),
> + },
> + },
> {
> .ident = "Lenovo Yoga 3 1170 / 1470",
> .matches = {
> --
> 2.17.1
>
>
--
Darren Hart
VMware Open Source Technology Center
next parent reply other threads:[~2018-11-14 5:16 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20181114022245.5798-1-loic.wyn@gmail.com>
2018-11-14 5:16 ` Darren Hart [this message]
[not found] ` <CAJxRB+DyrRWLTsW6fpOYuhS5W3iS3FATSRsoQTFx9ZJjzLv_dg@mail.gmail.com>
2018-11-14 10:52 ` [PATCH] ideapad-laptop: Add Lenovo Yoga 2 13 to the no_hw_rfkill DMI list Andy Shevchenko
2018-11-14 15:15 ` Loic Wei-Yu-Neng
2018-11-14 15:12 Loic WEI YU NENG
2018-11-14 16:01 ` Andy Shevchenko
[not found] <20180516011741.18010-1-loic.wyn@gmail.com>
[not found] ` <CAHp75VfY3nYgoUD3kjkZrMHzg2MZVNhgWiXJtxZAfpx_3ZGELQ@mail.gmail.com>
[not found] ` <CAJxRB+DUzxf2dAwBSPP2FTLkwXHGM22WvUM0yrLGB4inPE3O5A@mail.gmail.com>
[not found] ` <CAJxRB+C3xzL_m755ifoVzPugCg=bCbb-_mMOvkoH7iUvs3MV8w@mail.gmail.com>
2018-11-13 12:52 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181114051603.GF7890@fedora.eng.vmware.com \
--to=dvhart@infradead.org \
--cc=andy.shevchenko@gmail.com \
--cc=andy@infradead.org \
--cc=ike.pan@canonical.com \
--cc=linux-kernel@vger.kernel.org \
--cc=loic.wyn@gmail.com \
--cc=platform-driver-x86@vger.kernel.org \
--cc=trivial@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).