From: Christoph Hellwig <hch@lst.de>
To: Benjamin Herrenschmidt <benh@kernel.crashing.org>,
Paul Mackerras <paulus@samba.org>,
Michael Ellerman <mpe@ellerman.id.au>
Cc: linuxppc-dev@lists.ozlabs.org, iommu@lists.linux-foundation.org,
linux-mm@kvack.org, linux-arch@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: [PATCH 08/34] powerpc/dma: untangle vio_dma_mapping_ops from dma_iommu_ops
Date: Wed, 14 Nov 2018 09:22:48 +0100 [thread overview]
Message-ID: <20181114082314.8965-9-hch@lst.de> (raw)
In-Reply-To: <20181114082314.8965-1-hch@lst.de>
vio_dma_mapping_ops currently does a lot of indirect calls through
dma_iommu_ops, which not only make the code harder to follow but are
also expensive in the post-spectre world. Unwind the indirect calls
by calling the ppc_iommu_* or iommu_* APIs directly applicable, or
just use the dma_iommu_* methods directly where we can.
Signed-off-by: Christoph Hellwig <hch@lst.de>
---
arch/powerpc/include/asm/iommu.h | 1 +
arch/powerpc/kernel/dma-iommu.c | 2 +-
arch/powerpc/platforms/pseries/vio.c | 87 ++++++++++++----------------
3 files changed, 38 insertions(+), 52 deletions(-)
diff --git a/arch/powerpc/include/asm/iommu.h b/arch/powerpc/include/asm/iommu.h
index 35db0cbc9222..75daa10f31a4 100644
--- a/arch/powerpc/include/asm/iommu.h
+++ b/arch/powerpc/include/asm/iommu.h
@@ -242,6 +242,7 @@ static inline int __init tce_iommu_bus_notifier_init(void)
}
#endif /* !CONFIG_IOMMU_API */
+u64 dma_iommu_get_required_mask(struct device *dev);
int dma_iommu_mapping_error(struct device *dev, dma_addr_t dma_addr);
#else
diff --git a/arch/powerpc/kernel/dma-iommu.c b/arch/powerpc/kernel/dma-iommu.c
index 2ca6cfaebf65..0613278abf9f 100644
--- a/arch/powerpc/kernel/dma-iommu.c
+++ b/arch/powerpc/kernel/dma-iommu.c
@@ -92,7 +92,7 @@ int dma_iommu_dma_supported(struct device *dev, u64 mask)
return 1;
}
-static u64 dma_iommu_get_required_mask(struct device *dev)
+u64 dma_iommu_get_required_mask(struct device *dev)
{
struct iommu_table *tbl = get_iommu_table_base(dev);
u64 mask;
diff --git a/arch/powerpc/platforms/pseries/vio.c b/arch/powerpc/platforms/pseries/vio.c
index 88f1ad1d6309..ea3a9745c812 100644
--- a/arch/powerpc/platforms/pseries/vio.c
+++ b/arch/powerpc/platforms/pseries/vio.c
@@ -492,7 +492,9 @@ static void *vio_dma_iommu_alloc_coherent(struct device *dev, size_t size,
return NULL;
}
- ret = dma_iommu_ops.alloc(dev, size, dma_handle, flag, attrs);
+ ret = iommu_alloc_coherent(dev, get_iommu_table_base(dev), size,
+ dma_handle, dev->coherent_dma_mask, flag,
+ dev_to_node(dev));
if (unlikely(ret == NULL)) {
vio_cmo_dealloc(viodev, roundup(size, PAGE_SIZE));
atomic_inc(&viodev->cmo.allocs_failed);
@@ -507,8 +509,7 @@ static void vio_dma_iommu_free_coherent(struct device *dev, size_t size,
{
struct vio_dev *viodev = to_vio_dev(dev);
- dma_iommu_ops.free(dev, size, vaddr, dma_handle, attrs);
-
+ iommu_free_coherent(get_iommu_table_base(dev), size, vaddr, dma_handle);
vio_cmo_dealloc(viodev, roundup(size, PAGE_SIZE));
}
@@ -518,22 +519,22 @@ static dma_addr_t vio_dma_iommu_map_page(struct device *dev, struct page *page,
unsigned long attrs)
{
struct vio_dev *viodev = to_vio_dev(dev);
- struct iommu_table *tbl;
+ struct iommu_table *tbl = get_iommu_table_base(dev);
dma_addr_t ret = IOMMU_MAPPING_ERROR;
- tbl = get_iommu_table_base(dev);
- if (vio_cmo_alloc(viodev, roundup(size, IOMMU_PAGE_SIZE(tbl)))) {
- atomic_inc(&viodev->cmo.allocs_failed);
- return ret;
- }
-
- ret = dma_iommu_ops.map_page(dev, page, offset, size, direction, attrs);
- if (unlikely(dma_mapping_error(dev, ret))) {
- vio_cmo_dealloc(viodev, roundup(size, IOMMU_PAGE_SIZE(tbl)));
- atomic_inc(&viodev->cmo.allocs_failed);
- }
-
+ if (vio_cmo_alloc(viodev, roundup(size, IOMMU_PAGE_SIZE(tbl))))
+ goto out_fail;
+ ret = iommu_map_page(dev, tbl, page, offset, size, device_to_mask(dev),
+ direction, attrs);
+ if (unlikely(ret == IOMMU_MAPPING_ERROR))
+ goto out_deallocate;
return ret;
+
+out_deallocate:
+ vio_cmo_dealloc(viodev, roundup(size, IOMMU_PAGE_SIZE(tbl)));
+out_fail:
+ atomic_inc(&viodev->cmo.allocs_failed);
+ return IOMMU_MAPPING_ERROR;
}
static void vio_dma_iommu_unmap_page(struct device *dev, dma_addr_t dma_handle,
@@ -542,11 +543,9 @@ static void vio_dma_iommu_unmap_page(struct device *dev, dma_addr_t dma_handle,
unsigned long attrs)
{
struct vio_dev *viodev = to_vio_dev(dev);
- struct iommu_table *tbl;
-
- tbl = get_iommu_table_base(dev);
- dma_iommu_ops.unmap_page(dev, dma_handle, size, direction, attrs);
+ struct iommu_table *tbl = get_iommu_table_base(dev);
+ iommu_unmap_page(tbl, dma_handle, size, direction, attrs);
vio_cmo_dealloc(viodev, roundup(size, IOMMU_PAGE_SIZE(tbl)));
}
@@ -555,34 +554,32 @@ static int vio_dma_iommu_map_sg(struct device *dev, struct scatterlist *sglist,
unsigned long attrs)
{
struct vio_dev *viodev = to_vio_dev(dev);
- struct iommu_table *tbl;
+ struct iommu_table *tbl = get_iommu_table_base(dev);
struct scatterlist *sgl;
int ret, count;
size_t alloc_size = 0;
- tbl = get_iommu_table_base(dev);
for_each_sg(sglist, sgl, nelems, count)
alloc_size += roundup(sgl->length, IOMMU_PAGE_SIZE(tbl));
- if (vio_cmo_alloc(viodev, alloc_size)) {
- atomic_inc(&viodev->cmo.allocs_failed);
- return 0;
- }
-
- ret = dma_iommu_ops.map_sg(dev, sglist, nelems, direction, attrs);
-
- if (unlikely(!ret)) {
- vio_cmo_dealloc(viodev, alloc_size);
- atomic_inc(&viodev->cmo.allocs_failed);
- return ret;
- }
+ if (vio_cmo_alloc(viodev, alloc_size))
+ goto out_fail;
+ ret = ppc_iommu_map_sg(dev, tbl, sglist, nelems, device_to_mask(dev),
+ direction, attrs);
+ if (unlikely(!ret))
+ goto out_deallocate;
for_each_sg(sglist, sgl, ret, count)
alloc_size -= roundup(sgl->dma_length, IOMMU_PAGE_SIZE(tbl));
if (alloc_size)
vio_cmo_dealloc(viodev, alloc_size);
-
return ret;
+
+out_deallocate:
+ vio_cmo_dealloc(viodev, alloc_size);
+out_fail:
+ atomic_inc(&viodev->cmo.allocs_failed);
+ return 0;
}
static void vio_dma_iommu_unmap_sg(struct device *dev,
@@ -591,30 +588,18 @@ static void vio_dma_iommu_unmap_sg(struct device *dev,
unsigned long attrs)
{
struct vio_dev *viodev = to_vio_dev(dev);
- struct iommu_table *tbl;
+ struct iommu_table *tbl = get_iommu_table_base(dev);
struct scatterlist *sgl;
size_t alloc_size = 0;
int count;
- tbl = get_iommu_table_base(dev);
for_each_sg(sglist, sgl, nelems, count)
alloc_size += roundup(sgl->dma_length, IOMMU_PAGE_SIZE(tbl));
- dma_iommu_ops.unmap_sg(dev, sglist, nelems, direction, attrs);
-
+ ppc_iommu_unmap_sg(tbl, sglist, nelems, direction, attrs);
vio_cmo_dealloc(viodev, alloc_size);
}
-static int vio_dma_iommu_dma_supported(struct device *dev, u64 mask)
-{
- return dma_iommu_ops.dma_supported(dev, mask);
-}
-
-static u64 vio_dma_get_required_mask(struct device *dev)
-{
- return dma_iommu_ops.get_required_mask(dev);
-}
-
static const struct dma_map_ops vio_dma_mapping_ops = {
.alloc = vio_dma_iommu_alloc_coherent,
.free = vio_dma_iommu_free_coherent,
@@ -623,8 +608,8 @@ static const struct dma_map_ops vio_dma_mapping_ops = {
.unmap_sg = vio_dma_iommu_unmap_sg,
.map_page = vio_dma_iommu_map_page,
.unmap_page = vio_dma_iommu_unmap_page,
- .dma_supported = vio_dma_iommu_dma_supported,
- .get_required_mask = vio_dma_get_required_mask,
+ .dma_supported = dma_iommu_mapping_error,
+ .get_required_mask = dma_iommu_get_required_mask,
.mapping_error = dma_iommu_mapping_error,
};
--
2.19.1
next prev parent reply other threads:[~2018-11-14 8:23 UTC|newest]
Thread overview: 178+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-14 8:22 use generic DMA mapping code in powerpc V4 Christoph Hellwig
2018-11-14 8:22 ` [PATCH 01/34] powerpc: use mm zones more sensibly Christoph Hellwig
2018-12-06 14:09 ` Christoph Hellwig
2018-12-07 12:18 ` Michael Ellerman
2018-12-07 14:09 ` Christoph Hellwig
2018-12-07 15:04 ` Christian Zigotzky
2018-11-14 8:22 ` [PATCH 02/34] powerpc: allow NOT_COHERENT_CACHE for amigaone Christoph Hellwig
2018-12-06 14:09 ` Christoph Hellwig
2018-11-14 8:22 ` [PATCH 03/34] powerpc/dma: remove the unused ARCH_HAS_DMA_MMAP_COHERENT define Christoph Hellwig
2018-12-06 14:09 ` Christoph Hellwig
2018-11-14 8:22 ` [PATCH 04/34] powerpc/dma: remove the unused ISA_DMA_THRESHOLD export Christoph Hellwig
2018-12-06 14:10 ` Christoph Hellwig
2018-11-14 8:22 ` [PATCH 05/34] powerpc/dma: remove the unused dma_iommu_ops export Christoph Hellwig
2018-12-06 14:10 ` Christoph Hellwig
2018-11-14 8:22 ` [PATCH 06/34] powerpc/dma: split the two __dma_alloc_coherent implementations Christoph Hellwig
2018-12-06 14:10 ` Christoph Hellwig
2018-11-14 8:22 ` [PATCH 07/34] powerpc/dma: remove the no-op dma_nommu_unmap_{page,sg} routines Christoph Hellwig
2018-12-06 14:10 ` [PATCH 07/34] powerpc/dma: remove the no-op dma_nommu_unmap_{page, sg} routines Christoph Hellwig
2018-11-14 8:22 ` Christoph Hellwig [this message]
2018-12-06 14:10 ` [PATCH 08/34] powerpc/dma: untangle vio_dma_mapping_ops from dma_iommu_ops Christoph Hellwig
2018-11-14 8:22 ` [PATCH 09/34] powerpc/dma: handle iommu bypass in dma_iommu_ops Christoph Hellwig
2018-11-14 8:22 ` [PATCH 10/34] powerpc/pseries: unwind dma_get_required_mask_pSeriesLP a bit Christoph Hellwig
2018-11-14 8:22 ` [PATCH 11/34] powerpc/pseries: use the generic iommu bypass code Christoph Hellwig
2018-11-14 8:22 ` [PATCH 12/34] powerpc/cell: move dma direct window setup out of dma_configure Christoph Hellwig
2018-12-09 10:23 ` Michael Ellerman
2018-12-12 14:36 ` Christoph Hellwig
2018-12-14 13:29 ` Michael Ellerman
2018-12-14 16:42 ` Christoph Hellwig
2018-11-14 8:22 ` [PATCH 13/34] powerpc/cell: use the generic iommu bypass code Christoph Hellwig
2018-11-14 8:22 ` [PATCH 14/34] powerpc/dart: remove dead cleanup code in iommu_init_early_dart Christoph Hellwig
2018-12-06 14:11 ` Christoph Hellwig
2018-11-14 8:22 ` [PATCH 15/34] powerpc/dart: use the generic iommu bypass code Christoph Hellwig
2018-11-14 8:22 ` [PATCH 16/34] powerpc/powernv: remove pnv_pci_ioda_pe_single_vendor Christoph Hellwig
2018-11-14 8:22 ` [PATCH 17/34] powerpc/powernv: remove pnv_npu_dma_set_mask Christoph Hellwig
2018-11-14 8:22 ` [PATCH 18/34] powerpc/powernv: use the generic iommu bypass code Christoph Hellwig
2018-11-14 8:22 ` [PATCH 19/34] cxl: drop the dma_set_mask callback from vphb Christoph Hellwig
2018-12-06 14:10 ` Christoph Hellwig
2018-11-14 8:23 ` [PATCH 20/34] powerpc/dma: stop overriding dma_get_required_mask Christoph Hellwig
2018-11-14 8:23 ` [PATCH 21/34] powerpc/pci: remove the dma_set_mask pci_controller ops methods Christoph Hellwig
2018-11-14 8:23 ` [PATCH 22/34] powerpc/dma: remove the iommu fallback for coherent allocations Christoph Hellwig
2018-11-14 8:23 ` [PATCH 23/34] powerpc/dma: remove get_pci_dma_ops Christoph Hellwig
2018-11-14 8:23 ` [PATCH 24/34] powerpc/dma: move pci_dma_dev_setup_swiotlb to fsl_pci.c Christoph Hellwig
2018-11-14 8:23 ` [PATCH 25/34] powerpc/dma: remove max_direct_dma_addr Christoph Hellwig
2018-11-14 8:23 ` [PATCH 26/34] powerpc/dma: fix an off-by-one in dma_capable Christoph Hellwig
2018-11-14 8:23 ` [PATCH 27/34] powerpc/fsl_pci: simplify fsl_pci_dma_set_mask Christoph Hellwig
2018-11-14 8:23 ` [PATCH 28/34] dma-mapping, powerpc: simplify the arch dma_set_mask override Christoph Hellwig
2018-11-14 8:23 ` [PATCH 29/34] powerpc/dma: use phys_to_dma instead of get_dma_offset Christoph Hellwig
2018-11-14 8:23 ` [PATCH 30/34] powerpc/dma: remove dma_nommu_mmap_coherent Christoph Hellwig
2018-11-14 8:23 ` [PATCH 31/34] powerpc/dma: use generic direct and swiotlb ops Christoph Hellwig
2018-11-14 8:23 ` [PATCH 32/34] powerpc/dma: remove get_dma_offset Christoph Hellwig
2018-11-14 8:23 ` [PATCH 33/34] powerpc/dma: remove set_dma_offset Christoph Hellwig
2018-11-14 8:23 ` [PATCH 34/34] powerpc/dma: trim the fat from <asm/dma-mapping.h> Christoph Hellwig
2018-11-27 7:42 ` use generic DMA mapping code in powerpc V4 Christoph Hellwig
2018-11-27 22:05 ` Benjamin Herrenschmidt
2018-11-28 11:05 ` Michael Ellerman
2018-11-28 15:55 ` Christian Zigotzky
2018-11-28 20:02 ` Christian Zigotzky
2018-11-28 20:35 ` Michal Suchánek
2018-11-29 17:03 ` Christoph Hellwig
2019-12-19 13:54 ` Christian Zigotzky
2018-11-29 12:05 ` Christian Zigotzky
2018-11-29 15:30 ` Christian Zigotzky
2018-11-29 17:03 ` Christoph Hellwig
2018-11-29 23:07 ` Christian Zigotzky
2018-11-30 10:53 ` Christoph Hellwig
2018-11-30 12:23 ` Christian Zigotzky
2018-11-30 13:10 ` Christoph Hellwig
2018-11-30 15:29 ` Christian Zigotzky
2018-12-04 7:31 ` Christian Zigotzky
2018-12-04 9:53 ` Christian Zigotzky
2018-12-04 14:24 ` Christoph Hellwig
2018-12-05 9:44 ` Christian Zigotzky
2018-12-05 14:05 ` Christoph Hellwig
2018-12-06 10:55 ` Christian Zigotzky
2018-12-06 17:10 ` Christian Zigotzky
2018-12-06 19:36 ` Christoph Hellwig
2018-12-07 7:48 ` Christian Zigotzky
2018-12-07 13:45 ` Christian Zigotzky
2018-12-07 18:33 ` Christian Zigotzky
2018-12-08 10:29 ` Christian Zigotzky
2018-12-08 13:47 ` Christian Zigotzky
2018-12-09 14:20 ` Christian Zigotzky
2018-12-09 18:26 ` Christian Zigotzky
2018-12-10 15:54 ` Christian Zigotzky
2018-12-11 14:28 ` Christian Zigotzky
2018-12-11 18:17 ` Christian Zigotzky
2018-12-12 0:47 ` Benjamin Herrenschmidt
2018-12-12 7:03 ` Christian Zigotzky
2018-12-12 14:15 ` Christoph Hellwig
2018-12-12 14:39 ` Christian Zigotzky
2018-12-13 8:41 ` Christian Zigotzky
2018-12-13 9:10 ` Christoph Hellwig
2018-12-13 9:47 ` Christian Zigotzky
2018-12-13 11:19 ` Christian Zigotzky
2018-12-13 11:25 ` Christoph Hellwig
2018-12-13 13:34 ` Christian Zigotzky
2018-12-13 17:48 ` Christian Zigotzky
2018-12-13 21:53 ` Christian Zigotzky
2018-12-14 12:00 ` Christian Zigotzky
2018-12-14 16:45 ` Christoph Hellwig
2019-01-03 7:36 ` Christoph Hellwig
2019-01-03 19:26 ` Christian Zigotzky
2019-01-05 16:03 ` Christian Zigotzky
2019-01-09 9:31 ` Christian Zigotzky
2019-01-11 2:10 ` Christian Zigotzky
2019-01-12 18:14 ` Christian Zigotzky
2019-01-15 8:07 ` Christian Zigotzky
2019-01-15 8:49 ` Christian Zigotzky
2019-01-15 10:55 ` Christian Zigotzky
2019-01-15 13:35 ` Christoph Hellwig
2019-01-15 13:56 ` Christian Zigotzky
2019-01-15 15:17 ` Christoph Hellwig
2019-01-17 9:21 ` Christian Zigotzky
2019-01-17 9:31 ` Christoph Hellwig
2019-01-17 9:44 ` Christian Zigotzky
2019-01-18 8:35 ` Christoph Hellwig
2019-01-18 11:10 ` Christian Zigotzky
2019-01-18 11:28 ` Christoph Hellwig
2019-01-18 12:07 ` Christian Zigotzky
2019-01-18 12:18 ` Christoph Hellwig
2019-01-18 12:46 ` Christian Zigotzky
2019-01-18 12:55 ` Christoph Hellwig
2019-01-18 15:06 ` Christian Zigotzky
2019-01-19 11:40 ` Christian Zigotzky
2019-01-19 11:52 ` Christian Zigotzky
2019-01-19 13:02 ` Christoph Hellwig
2019-01-19 14:04 ` Christoph Hellwig
2019-01-21 14:38 ` Christian Zigotzky
2019-01-23 14:34 ` Christian Zigotzky
2019-01-25 13:37 ` Christian Zigotzky
2019-01-27 13:13 ` Christian Zigotzky
2019-01-28 7:04 ` Christoph Hellwig
2019-01-28 16:22 ` Christoph Hellwig
2019-01-28 16:52 ` Christian Zigotzky
2019-01-29 15:03 ` Christian Zigotzky
2019-01-29 16:14 ` Christoph Hellwig
2019-01-29 16:34 ` Christoph Hellwig
2019-01-30 4:40 ` Christian Zigotzky
2019-01-31 12:48 ` Christian Zigotzky
2019-02-01 8:04 ` Christoph Hellwig
2019-02-01 16:54 ` Christian Zigotzky
2019-02-03 16:49 ` Christian Zigotzky
2019-02-04 7:56 ` Christoph Hellwig
2019-02-04 12:13 ` Christian Zigotzky
2019-02-04 12:38 ` Christoph Hellwig
2019-02-06 13:45 ` Christian Zigotzky
2019-02-06 15:15 ` Christoph Hellwig
2019-02-06 15:16 ` Christoph Hellwig
2019-02-07 4:34 ` Christian Zigotzky
2019-02-08 9:01 ` Christian Zigotzky
2019-02-08 9:18 ` Christoph Hellwig
2019-02-08 10:59 ` Christian Zigotzky
2019-02-10 12:00 ` Christian Zigotzky
[not found] ` <0042290A-2939-4EBA-A638-D404FA2055ED@xenosoft.de>
2019-02-11 7:21 ` Christian Zigotzky
2019-02-11 7:38 ` Christoph Hellwig
2019-02-12 12:42 ` Christian Zigotzky
2019-02-12 15:25 ` Christoph Hellwig
2019-02-12 19:31 ` Christian Zigotzky
2019-02-12 19:50 ` Christian Zigotzky
2019-02-12 19:52 ` Christoph Hellwig
2019-11-05 7:56 ` Bug 205201 - overflow of DMA mask and bus mask Christian Zigotzky
2019-11-05 16:28 ` Christoph Hellwig
2019-11-06 14:09 ` Robin Murphy
2019-11-21 17:26 ` Christoph Hellwig
2019-11-07 9:53 ` Christian Zigotzky
2019-11-10 7:27 ` Christian Zigotzky
2019-11-11 8:12 ` Christian Zigotzky
2019-11-11 8:16 ` Christian Zigotzky
2019-11-11 12:22 ` Christian Zigotzky
2019-11-12 14:41 ` Christoph Hellwig
2019-11-12 22:58 ` Christian Zigotzky
2019-11-13 10:14 ` Christian Zigotzky
2019-11-13 11:02 ` Christoph Hellwig
2018-11-29 17:02 ` use generic DMA mapping code in powerpc V4 Christoph Hellwig
2018-11-30 3:17 ` Benjamin Herrenschmidt
2018-12-08 17:03 ` Christoph Hellwig
2018-12-16 16:51 ` Christoph Hellwig
2018-12-17 1:14 ` Michael Ellerman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181114082314.8965-9-hch@lst.de \
--to=hch@lst.de \
--cc=benh@kernel.crashing.org \
--cc=iommu@lists.linux-foundation.org \
--cc=linux-arch@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mpe@ellerman.id.au \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).