From: Michal Hocko <mhocko@kernel.org>
To: Yi Wang <wang.yi59@zte.com.cn>
Cc: riel@redhat.com, linux@rasmusvillemoes.dk, keescook@chromium.org,
viro@ZenIV.linux.org.uk, linux-kernel@vger.kernel.org,
akpm@linux-foundation.org, rostedt@goodmis.org,
tglx@linutronix.de, mingo@kernel.org, rppt@linux.vnet.ibm.com,
linux@dominikbrodowski.net, pasha.tatashin@oracle.com,
ard.biesheuvel@linaro.org, luto@amacapital.net, wad@chromium.org,
riel@surriel.com, ebiederm@xmission.com,
kirill.shutemov@linux.intel.com, guro@fb.com,
marcos.souza.org@gmail.com, zhong.weidong@zte.com.cn
Subject: Re: [PATCH v2] fork: Fix some -Wmissing-prototypes warnings
Date: Wed, 14 Nov 2018 10:22:04 +0100 [thread overview]
Message-ID: <20181114092204.GH23419@dhcp22.suse.cz> (raw)
In-Reply-To: <1542170087-23645-1-git-send-email-wang.yi59@zte.com.cn>
On Wed 14-11-18 12:34:47, Yi Wang wrote:
> We get a warning when building kernel with W=1:
> kernel/fork.c:167:13: warning: no previous prototype for ‘arch_release_thread_stack’ [-Wmissing-prototypes]
> kernel/fork.c:779:13: warning: no previous prototype for ‘fork_init’ [-Wmissing-prototypes]
>
> Add the missing declaration in head file to fix this.
>
> Also, remove arch_release_thread_stack() completely because no
> arch seems to implement it since bb9d81264 (arch: remove tile port).
>
> Signed-off-by: Yi Wang <wang.yi59@zte.com.cn>
Looks good to me.
Acked-by: Michal Hocko <mhocko@suse.com>
> ---
> v2: remove arch_release_thread_stack(). Thanks to Rasmus.
> ---
> include/linux/sched/task.h | 2 ++
> init/main.c | 1 -
> kernel/fork.c | 5 -----
> 3 files changed, 2 insertions(+), 6 deletions(-)
>
> diff --git a/include/linux/sched/task.h b/include/linux/sched/task.h
> index 108ede9..44c6f15 100644
> --- a/include/linux/sched/task.h
> +++ b/include/linux/sched/task.h
> @@ -39,6 +39,8 @@
>
> extern void proc_caches_init(void);
>
> +extern void fork_init(void);
> +
> extern void release_task(struct task_struct * p);
>
> #ifdef CONFIG_HAVE_COPY_THREAD_TLS
> diff --git a/init/main.c b/init/main.c
> index ee14710..8feda42 100644
> --- a/init/main.c
> +++ b/init/main.c
> @@ -105,7 +105,6 @@
> static int kernel_init(void *);
>
> extern void init_IRQ(void);
> -extern void fork_init(void);
> extern void radix_tree_init(void);
>
> /*
> diff --git a/kernel/fork.c b/kernel/fork.c
> index 07cddff..c6d02be 100644
> --- a/kernel/fork.c
> +++ b/kernel/fork.c
> @@ -164,10 +164,6 @@ static inline void free_task_struct(struct task_struct *tsk)
> }
> #endif
>
> -void __weak arch_release_thread_stack(unsigned long *stack)
> -{
> -}
> -
> #ifndef CONFIG_ARCH_THREAD_STACK_ALLOCATOR
>
> /*
> @@ -417,7 +413,6 @@ static void release_task_stack(struct task_struct *tsk)
> return; /* Better to leak the stack than to free prematurely */
>
> account_kernel_stack(tsk, -1);
> - arch_release_thread_stack(tsk->stack);
> free_thread_stack(tsk);
> tsk->stack = NULL;
> #ifdef CONFIG_VMAP_STACK
> --
> 1.8.3.1
--
Michal Hocko
SUSE Labs
next prev parent reply other threads:[~2018-11-14 9:22 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-14 4:34 [PATCH v2] fork: Fix some -Wmissing-prototypes warnings Yi Wang
2018-11-14 9:22 ` Michal Hocko [this message]
2018-11-14 16:09 ` Mike Rapoport
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181114092204.GH23419@dhcp22.suse.cz \
--to=mhocko@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=ard.biesheuvel@linaro.org \
--cc=ebiederm@xmission.com \
--cc=guro@fb.com \
--cc=keescook@chromium.org \
--cc=kirill.shutemov@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@dominikbrodowski.net \
--cc=linux@rasmusvillemoes.dk \
--cc=luto@amacapital.net \
--cc=marcos.souza.org@gmail.com \
--cc=mingo@kernel.org \
--cc=pasha.tatashin@oracle.com \
--cc=riel@redhat.com \
--cc=riel@surriel.com \
--cc=rostedt@goodmis.org \
--cc=rppt@linux.vnet.ibm.com \
--cc=tglx@linutronix.de \
--cc=viro@ZenIV.linux.org.uk \
--cc=wad@chromium.org \
--cc=wang.yi59@zte.com.cn \
--cc=zhong.weidong@zte.com.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).