From: Alexandre Belloni <alexandre.belloni@bootlin.com>
To: "Maciej W. Rozycki" <macro@linux-mips.org>
Cc: Alessandro Zummo <a.zummo@towertech.it>,
linux-rtc@vger.kernel.org, linux-kernel@vger.kernel.org,
stable@vger.kernel.org
Subject: Re: [PATCH] rtc: m41t80: Correct alarm month range with RTC reads
Date: Wed, 14 Nov 2018 10:47:22 +0100 [thread overview]
Message-ID: <20181114094722.GT29768@piout.net> (raw)
In-Reply-To: <alpine.LFD.2.21.1811070053580.20378@eddie.linux-mips.org>
On 07/11/2018 02:39:13+0000, Maciej W. Rozycki wrote:
> Add the missing adjustment of the month range on alarm reads from the
> RTC, correcting an issue coming from commit 9c6dfed92c3e ("rtc: m41t80:
> add alarm functionality"). The range is 1-12 for hardware and 0-11 for
> `struct rtc_time', and is already correctly handled on alarm writes to
> the RTC.
>
> It was correct up until commit 48e9766726eb ("drivers/rtc/rtc-m41t80.c:
> remove disabled alarm functionality") too, which removed the previous
> implementation of alarm support.
>
> Signed-off-by: Maciej W. Rozycki <macro@linux-mips.org>
> Fixes: 9c6dfed92c3e ("rtc: m41t80: add alarm functionality")
> References: 48e9766726eb ("drivers/rtc/rtc-m41t80.c: remove disabled alarm functionality")
> Cc: stable@vger.kernel.org # 4.7+
> ---
> Hi,
>
> I have no means to verify this change at run time as my M41T81 device,
> which is the reason for me to use this driver, regrettably hasn't got its
> IRQ line routed, due to historical reasons I gathered, as it replaced a
> different RTC device, that didn't have an IRQ output at all, used with
> earlier revisions of the Broadcom SiByte SWARM board I have been using
> this code with. However it should be obvious by code inspection.
>
> Please apply and backport as appropriate.
>
> Maciej
> ---
> drivers/rtc/rtc-m41t80.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
Applied (and tested), thanks.
--
Alexandre Belloni, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
prev parent reply other threads:[~2018-11-14 9:47 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-07 2:39 [PATCH] rtc: m41t80: Correct alarm month range with RTC reads Maciej W. Rozycki
2018-11-14 9:47 ` Alexandre Belloni [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181114094722.GT29768@piout.net \
--to=alexandre.belloni@bootlin.com \
--cc=a.zummo@towertech.it \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rtc@vger.kernel.org \
--cc=macro@linux-mips.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).