From: Alexandre Belloni <alexandre.belloni@bootlin.com>
To: "Maciej W. Rozycki" <macro@linux-mips.org>
Cc: Alessandro Zummo <a.zummo@towertech.it>,
Matt Turner <mattst88@gmail.com>,
linux-rtc@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] rtc: m41t80: Complete error propagation from SMBus calls
Date: Wed, 14 Nov 2018 10:57:37 +0100 [thread overview]
Message-ID: <20181114095737.GV29768@piout.net> (raw)
In-Reply-To: <alpine.LFD.2.21.1811070142240.20378@eddie.linux-mips.org>
On 07/11/2018 02:39:51+0000, Maciej W. Rozycki wrote:
> Complement commit 85d77047c4ea ("drivers/rtc/rtc-m41t80.c: propagate
> error value from smbus functions") and correct the remaining places that
> fail to propagate the error code from SMBus calls.
>
> Signed-off-by: Maciej W. Rozycki <macro@linux-mips.org>
> References: 85d77047c4ea ("drivers/rtc/rtc-m41t80.c: propagate error value from smbus functions")
> ---
> Hi,
>
> I think this does not qualify for backporting, but please feel free to
> decide otherwise.
>
> This change I did verify at run time to the extent I was able to, but I
> didn't try to trigger artificial errors. Also the M41T81, which is the
> device I've been using this driver with, does not have battery failure
> indication implemented, so I could not execute the procfs handling path
> (again without making some artificial changes). These changes should be
> obvious regardless.
>
> I'll be posting further patches over the coming weeks, based on my
> original effort as archived here: <https://lkml.org/lkml/2008/5/12/385>,
> <https://lore.kernel.org/patchwork/project/lkml/list/?series=73524&archive=both>
> However I have just realised they'll need another iteration before I post
> them. So for now just these two obvious fixes.
>
Regarding the persistent part, do you really need more than what is
provided? As far as I know, the timekeeping core is already taking care
of using the best source to get the suspended time.
--
Alexandre Belloni, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
next prev parent reply other threads:[~2018-11-14 9:57 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-07 2:39 [PATCH] rtc: m41t80: Complete error propagation from SMBus calls Maciej W. Rozycki
2018-11-14 9:48 ` Alexandre Belloni
2018-11-14 9:57 ` Alexandre Belloni [this message]
2018-11-14 12:05 ` Maciej W. Rozycki
2018-11-14 12:20 ` Alexandre Belloni
2018-11-14 12:50 ` Maciej W. Rozycki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181114095737.GV29768@piout.net \
--to=alexandre.belloni@bootlin.com \
--cc=a.zummo@towertech.it \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rtc@vger.kernel.org \
--cc=macro@linux-mips.org \
--cc=mattst88@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).