linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] rtc: max77686: Fix the returned value in case of error in 'max77686_rtc_read_time()'
@ 2018-11-13 23:36 ` Christophe JAILLET
  2018-11-14  0:09   ` Chanwoo Choi
  2018-11-14 11:03   ` Alexandre Belloni
  0 siblings, 2 replies; 3+ messages in thread
From: Christophe JAILLET @ 2018-11-13 23:36 UTC (permalink / raw)
  To: cw00.choi, krzk, b.zolnierkie, a.zummo, alexandre.belloni
  Cc: linux-rtc, linux-kernel, kernel-janitors, Christophe JAILLET

In case of error, we return 0.
This is spurious and not consistent with the other functions of the driver.
Commit e115a2bf1426 has modified more than what is said in the commit
message. Reverse part of it znd return an error when needed, as it was
previously.

Fixes: e115a2bf1426 ("rtc: max77686: stop validating rtc_time in .read_time")
Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
---
 drivers/rtc/rtc-max77686.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/rtc/rtc-max77686.c b/drivers/rtc/rtc-max77686.c
index 8a60900d6b8b..4aff349ae301 100644
--- a/drivers/rtc/rtc-max77686.c
+++ b/drivers/rtc/rtc-max77686.c
@@ -360,7 +360,7 @@ static int max77686_rtc_read_time(struct device *dev, struct rtc_time *tm)
 
 out:
 	mutex_unlock(&info->lock);
-	return 0;
+	return ret;
 }
 
 static int max77686_rtc_set_time(struct device *dev, struct rtc_time *tm)
-- 
2.17.1


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] rtc: max77686: Fix the returned value in case of error in 'max77686_rtc_read_time()'
  2018-11-13 23:36 ` [PATCH] rtc: max77686: Fix the returned value in case of error in 'max77686_rtc_read_time()' Christophe JAILLET
@ 2018-11-14  0:09   ` Chanwoo Choi
  2018-11-14 11:03   ` Alexandre Belloni
  1 sibling, 0 replies; 3+ messages in thread
From: Chanwoo Choi @ 2018-11-14  0:09 UTC (permalink / raw)
  To: Christophe JAILLET, krzk, b.zolnierkie, a.zummo, alexandre.belloni
  Cc: linux-rtc, linux-kernel, kernel-janitors

On 2018년 11월 14일 08:36, Christophe JAILLET wrote:
> In case of error, we return 0.
> This is spurious and not consistent with the other functions of the driver.
> Commit e115a2bf1426 has modified more than what is said in the commit
> message. Reverse part of it znd return an error when needed, as it was
> previously.
> 
> Fixes: e115a2bf1426 ("rtc: max77686: stop validating rtc_time in .read_time")
> Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
> ---
>  drivers/rtc/rtc-max77686.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/rtc/rtc-max77686.c b/drivers/rtc/rtc-max77686.c
> index 8a60900d6b8b..4aff349ae301 100644
> --- a/drivers/rtc/rtc-max77686.c
> +++ b/drivers/rtc/rtc-max77686.c
> @@ -360,7 +360,7 @@ static int max77686_rtc_read_time(struct device *dev, struct rtc_time *tm)
>  
>  out:
>  	mutex_unlock(&info->lock);
> -	return 0;
> +	return ret;
>  }
>  
>  static int max77686_rtc_set_time(struct device *dev, struct rtc_time *tm)
> 

Reviewed-by: Chanwoo Choi <cw00.choi@samsung.com>

-- 
Best Regards,
Chanwoo Choi
Samsung Electronics

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] rtc: max77686: Fix the returned value in case of error in 'max77686_rtc_read_time()'
  2018-11-13 23:36 ` [PATCH] rtc: max77686: Fix the returned value in case of error in 'max77686_rtc_read_time()' Christophe JAILLET
  2018-11-14  0:09   ` Chanwoo Choi
@ 2018-11-14 11:03   ` Alexandre Belloni
  1 sibling, 0 replies; 3+ messages in thread
From: Alexandre Belloni @ 2018-11-14 11:03 UTC (permalink / raw)
  To: Christophe JAILLET
  Cc: cw00.choi, krzk, b.zolnierkie, a.zummo, linux-rtc, linux-kernel,
	kernel-janitors

On 14/11/2018 00:36:45+0100, Christophe JAILLET wrote:
> In case of error, we return 0.
> This is spurious and not consistent with the other functions of the driver.
> Commit e115a2bf1426 has modified more than what is said in the commit
> message. Reverse part of it znd return an error when needed, as it was
> previously.
> 
> Fixes: e115a2bf1426 ("rtc: max77686: stop validating rtc_time in .read_time")
> Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
> ---
>  drivers/rtc/rtc-max77686.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
Applied, thanks.

-- 
Alexandre Belloni, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2018-11-14 11:03 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
     [not found] <CGME20181113233753epcas4p2ecc97f5931a34bc0d176111b155738b8@epcas4p2.samsung.com>
2018-11-13 23:36 ` [PATCH] rtc: max77686: Fix the returned value in case of error in 'max77686_rtc_read_time()' Christophe JAILLET
2018-11-14  0:09   ` Chanwoo Choi
2018-11-14 11:03   ` Alexandre Belloni

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).