From: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
To: Sakari Ailus <sakari.ailus@iki.fi>
Cc: mchehab@kernel.org, robh+dt@kernel.org, todor.tomov@linaro.org,
hansverk@cisco.com, linux-media@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] dt-bindings: media: i2c: Fix external clock frequency for OV5645
Date: Wed, 14 Nov 2018 17:36:52 +0530 [thread overview]
Message-ID: <20181114120652.GA26112@Mani-XPS-13-9360> (raw)
In-Reply-To: <20181114105712.j5jkspfasujiyqzs@valkosipuli.retiisi.org.uk>
On Wed, Nov 14, 2018 at 12:57:12PM +0200, Sakari Ailus wrote:
> Hi Manivannan,
>
> On Wed, Nov 14, 2018 at 04:09:35PM +0530, Manivannan Sadhasivam wrote:
> > Commit "4adb0a0432f4 media: ov5645: Supported external clock is 24MHz"
> > modified the external clock frequency to be 24MHz instead of the
> > 23.88MHz in driver. Hence, make the same change in corresponding bindings
> > doc and mention the acceptable tolerance.
> >
> > Signed-off-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
> > ---
> > Documentation/devicetree/bindings/media/i2c/ov5645.txt | 5 +++--
> > 1 file changed, 3 insertions(+), 2 deletions(-)
> >
> > diff --git a/Documentation/devicetree/bindings/media/i2c/ov5645.txt b/Documentation/devicetree/bindings/media/i2c/ov5645.txt
> > index fd7aec9f8e24..b155583469a4 100644
> > --- a/Documentation/devicetree/bindings/media/i2c/ov5645.txt
> > +++ b/Documentation/devicetree/bindings/media/i2c/ov5645.txt
> > @@ -8,7 +8,8 @@ Required Properties:
> > - compatible: Value should be "ovti,ov5645".
> > - clocks: Reference to the xclk clock.
> > - clock-names: Should be "xclk".
> > -- clock-frequency: Frequency of the xclk clock.
> > +- clock-frequency: Frequency of the xclk clock. Should be 24MHz with 1%
> > + acceptable tolerance.
>
> DT bindings are for documenting the hardware, not the driver implementation.
> The sensor supports a range AFAIU, not a specific frequency.
>
Agree! That's my bad.
> The bit below seems good.
>
Okay. Will remove the above change and send v2.
Thanks,
Mani
> > - enable-gpios: Chip enable GPIO. Polarity is GPIO_ACTIVE_HIGH. This corresponds
> > to the hardware pin PWDNB which is physically active low.
> > - reset-gpios: Chip reset GPIO. Polarity is GPIO_ACTIVE_LOW. This corresponds to
> > @@ -37,7 +38,7 @@ Example:
> >
> > clocks = <&clks 200>;
> > clock-names = "xclk";
> > - clock-frequency = <23880000>;
> > + clock-frequency = <24000000>;
> >
> > vdddo-supply = <&camera_dovdd_1v8>;
> > vdda-supply = <&camera_avdd_2v8>;
> > --
> > 2.17.1
> >
>
> --
> Sakari Ailus
> e-mail: sakari.ailus@iki.fi
prev parent reply other threads:[~2018-11-14 12:07 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-14 10:39 [PATCH] dt-bindings: media: i2c: Fix external clock frequency for OV5645 Manivannan Sadhasivam
2018-11-14 10:57 ` Sakari Ailus
2018-11-14 12:06 ` Manivannan Sadhasivam [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181114120652.GA26112@Mani-XPS-13-9360 \
--to=manivannan.sadhasivam@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=hansverk@cisco.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=robh+dt@kernel.org \
--cc=sakari.ailus@iki.fi \
--cc=todor.tomov@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).