From: Maxime Ripard <maxime.ripard@bootlin.com>
To: John Garry <john.garry@huawei.com>
Cc: catalin.marinas@arm.com, will.deacon@arm.com, wens@csie.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, icenowy@aosc.io
Subject: Re: [PATCH] arm64: sunxi: Enable REGMAP_MMIO to fix linker error
Date: Wed, 14 Nov 2018 15:51:31 +0100 [thread overview]
Message-ID: <20181114145131.qv4gzg6pqktkpun5@flea> (raw)
In-Reply-To: <1542128665-78302-1-git-send-email-john.garry@huawei.com>
[-- Attachment #1: Type: text/plain, Size: 1600 bytes --]
Hi John,
On Wed, Nov 14, 2018 at 01:04:25AM +0800, John Garry wrote:
> The following linker failure can be seen for a certain heavily reduced
> defconfig:
> drivers/soc/sunxi/sunxi_sram.o: In function `sunxi_sram_probe':
> drivers/soc/sunxi/sunxi_sram.c:353: undefined reference to `__devm_regmap_init_mmio_clk'
> drivers/soc/sunxi/sunxi_sram.c:353:(.text+0x3c4): relocation truncated to fit: R_AARCH64_CALL26 against undefined symbol `__devm_regmap_init_mmio_clk'
>
> It would seem that the sunxi sram driver implicitly depended on config
> REGMAP_MMIO.
>
> To solve, select config REGMAP_MMIO for ARCH_SUNXI. This seems a better
> option than selecting from the respective driver config as this just
> defaults to ARCH_SUNXI.
>
> Fixes: 5828729bebbb ("soc: sunxi: export a regmap for EMAC clock reg on A64")
> Signed-off-by: John Garry <john.garry@huawei.com>
>
> diff --git a/arch/arm64/Kconfig.platforms b/arch/arm64/Kconfig.platforms
> index 51bc479..c8a6ad3 100644
> --- a/arch/arm64/Kconfig.platforms
> +++ b/arch/arm64/Kconfig.platforms
> @@ -12,6 +12,7 @@ config ARCH_SUNXI
> select ARCH_HAS_RESET_CONTROLLER
> select GENERIC_IRQ_CHIP
> select PINCTRL
> + select REGMAP_MMIO
> select RESET_CONTROLLER
> help
> This enables support for Allwinner sunxi based SoCs like the A64.
The sunxi_sram driver has a Kconfig symbol of its own now, it would
make more sense to add that select there, especially since we can also
compile it for arm.
Maxime
--
Maxime Ripard, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
next prev parent reply other threads:[~2018-11-14 14:51 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-13 17:04 [PATCH] arm64: sunxi: Enable REGMAP_MMIO to fix linker error John Garry
2018-11-14 14:51 ` Maxime Ripard [this message]
2018-11-14 15:00 ` John Garry
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181114145131.qv4gzg6pqktkpun5@flea \
--to=maxime.ripard@bootlin.com \
--cc=catalin.marinas@arm.com \
--cc=icenowy@aosc.io \
--cc=john.garry@huawei.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=wens@csie.org \
--cc=will.deacon@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).