* [PATCH] ideapad-laptop: Add Lenovo Yoga 2 13 to the no_hw_rfkill DMI list @ 2018-11-14 15:12 Loic WEI YU NENG 2018-11-14 16:01 ` Andy Shevchenko 0 siblings, 1 reply; 6+ messages in thread From: Loic WEI YU NENG @ 2018-11-14 15:12 UTC (permalink / raw) To: Darren Hart, andy.shevchenko, ike.pan, andy, trivial, platform-driver-x86, LKML Cc: Loic WEI YU NENG Some Lenovo ideapad models lack a physical rfkill switch. On Lenovo models Yoga 2 13, ideapad-laptop would wrongly report all radios as blocked by hardware which caused wireless network connections to fail. Add these models without an rfkill switch to the no_hw_rfkill list. Signed-off-by: Loic WEI YU NENG <loic.wyn@gmail.com> --- drivers/platform/x86/ideapad-laptop.c | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/drivers/platform/x86/ideapad-laptop.c b/drivers/platform/x86/ideapad-laptop.c index b6489cba2985..1589dffab9fa 100644 --- a/drivers/platform/x86/ideapad-laptop.c +++ b/drivers/platform/x86/ideapad-laptop.c @@ -1188,6 +1188,13 @@ static const struct dmi_system_id no_hw_rfkill_list[] = { DMI_MATCH(DMI_BOARD_NAME, "Yoga2"), }, }, + { + .ident = "Lenovo Yoga 2 13", + .matches = { + DMI_MATCH(DMI_SYS_VENDOR, "LENOVO"), + DMI_MATCH(DMI_PRODUCT_VERSION, "Yoga 2 13"), + }, + }, { .ident = "Lenovo Yoga 3 1170 / 1470", .matches = { -- 2.17.1 ^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH] ideapad-laptop: Add Lenovo Yoga 2 13 to the no_hw_rfkill DMI list 2018-11-14 15:12 [PATCH] ideapad-laptop: Add Lenovo Yoga 2 13 to the no_hw_rfkill DMI list Loic WEI YU NENG @ 2018-11-14 16:01 ` Andy Shevchenko 0 siblings, 0 replies; 6+ messages in thread From: Andy Shevchenko @ 2018-11-14 16:01 UTC (permalink / raw) To: Loic Wei-Yu-Neng Cc: Darren Hart, Ike Panhc, Andy Shevchenko, Jiri Kosina, Platform Driver, Linux Kernel Mailing List On Wed, Nov 14, 2018 at 5:13 PM Loic WEI YU NENG <loic.wyn@gmail.com> wrote: > > Some Lenovo ideapad models lack a physical rfkill switch. > On Lenovo models Yoga 2 13, ideapad-laptop would wrongly report all > radios as blocked by hardware which caused wireless network connections > to fail. > Add these models without an rfkill switch to the no_hw_rfkill list. > Pushed to my review and testing queue, thanks > Signed-off-by: Loic WEI YU NENG <loic.wyn@gmail.com> > --- > drivers/platform/x86/ideapad-laptop.c | 7 +++++++ > 1 file changed, 7 insertions(+) > > diff --git a/drivers/platform/x86/ideapad-laptop.c b/drivers/platform/x86/ideapad-laptop.c > index b6489cba2985..1589dffab9fa 100644 > --- a/drivers/platform/x86/ideapad-laptop.c > +++ b/drivers/platform/x86/ideapad-laptop.c > @@ -1188,6 +1188,13 @@ static const struct dmi_system_id no_hw_rfkill_list[] = { > DMI_MATCH(DMI_BOARD_NAME, "Yoga2"), > }, > }, > + { > + .ident = "Lenovo Yoga 2 13", > + .matches = { > + DMI_MATCH(DMI_SYS_VENDOR, "LENOVO"), > + DMI_MATCH(DMI_PRODUCT_VERSION, "Yoga 2 13"), > + }, > + }, > { > .ident = "Lenovo Yoga 3 1170 / 1470", > .matches = { > -- > 2.17.1 > -- With Best Regards, Andy Shevchenko ^ permalink raw reply [flat|nested] 6+ messages in thread
[parent not found: <20181114022245.5798-1-loic.wyn@gmail.com>]
* Re: [PATCH] ideapad-laptop: Add Lenovo Yoga 2 13 to the no_hw_rfkill DMI list [not found] <20181114022245.5798-1-loic.wyn@gmail.com> @ 2018-11-14 5:16 ` Darren Hart [not found] ` <CAJxRB+DyrRWLTsW6fpOYuhS5W3iS3FATSRsoQTFx9ZJjzLv_dg@mail.gmail.com> 0 siblings, 1 reply; 6+ messages in thread From: Darren Hart @ 2018-11-14 5:16 UTC (permalink / raw) To: Loic WEI YU NENG Cc: andy.shevchenko, ike.pan, andy, trivial, platform-driver-x86, LKML On Tue, Nov 13, 2018 at 06:22:45PM -0800, Loic WEI YU NENG wrote: > Some Lenovo ideapad models lack a physical rfkill switch. > On Lenovo models Yoga 2 13, ideapad-laptop would wrongly report all > radios as blocked by hardware which caused wireless network connections > to fail. > Add these models without an rfkill switch to the no_hw_rfkill list. > > Signed-off-by: Loic WEI YU NENG <loic.wyn@gmail.com> Thank you for the patch. In the future, please be sure to check MAINTAINERS and include the relevant lists, now Cc'd. I see this in the context of your patch, but can you confirm the current driver fails to match your system? It contains the following, which I would expect to match: .ident = "Lenovo Yoga 2 11 / 13 / Pro", .matches = { DMI_MATCH(DMI_SYS_VENDOR, "LENOVO"), DMI_MATCH(DMI_BOARD_NAME, "Yoga2"), }, If it doesn't match, what does dmidecode report for SYS_VENDOR and BOARD_NAME on your system? Perhaps we need to make the above more generic. > --- > drivers/platform/x86/ideapad-laptop.c | 7 +++++++ > 1 file changed, 7 insertions(+) > > diff --git a/drivers/platform/x86/ideapad-laptop.c b/drivers/platform/x86/ideapad-laptop.c > index b6489cba2985..1589dffab9fa 100644 > --- a/drivers/platform/x86/ideapad-laptop.c > +++ b/drivers/platform/x86/ideapad-laptop.c > @@ -1188,6 +1188,13 @@ static const struct dmi_system_id no_hw_rfkill_list[] = { > DMI_MATCH(DMI_BOARD_NAME, "Yoga2"), > }, > }, > + { > + .ident = "Lenovo Yoga 2 13", > + .matches = { > + DMI_MATCH(DMI_SYS_VENDOR, "LENOVO"), > + DMI_MATCH(DMI_PRODUCT_VERSION, "Yoga 2 13"), > + }, > + }, > { > .ident = "Lenovo Yoga 3 1170 / 1470", > .matches = { > -- > 2.17.1 > > -- Darren Hart VMware Open Source Technology Center ^ permalink raw reply [flat|nested] 6+ messages in thread
[parent not found: <CAJxRB+DyrRWLTsW6fpOYuhS5W3iS3FATSRsoQTFx9ZJjzLv_dg@mail.gmail.com>]
* Re: [PATCH] ideapad-laptop: Add Lenovo Yoga 2 13 to the no_hw_rfkill DMI list [not found] ` <CAJxRB+DyrRWLTsW6fpOYuhS5W3iS3FATSRsoQTFx9ZJjzLv_dg@mail.gmail.com> @ 2018-11-14 10:52 ` Andy Shevchenko 2018-11-14 15:15 ` Loic Wei-Yu-Neng 0 siblings, 1 reply; 6+ messages in thread From: Andy Shevchenko @ 2018-11-14 10:52 UTC (permalink / raw) To: Loic Wei-Yu-Neng Cc: Darren Hart, Ike Panhc, Andy Shevchenko, Jiri Kosina, Platform Driver, Linux Kernel Mailing List On Wed, Nov 14, 2018 at 9:48 AM Loic Wei-Yu-Neng <loic.wyn@gmail.com> wrote: > > Hello Darren, > Yes, the current driver fails to match match my laptop. I need to add this patch to have wifi functional on my laptop. > Here is the dmidecode snippet from my laptop: > > Handle 0x0001, DMI type 1, 27 bytes > System Information > Manufacturer: LENOVO > Product Name: 20344 > Version: Yoga 2 13 > Serial Number: 3438666500284 > UUID: 933A1748-ACE0-E311-A534-F8A9633129FA > Wake-up Type: Power Switch > SKU Number: LENOVO_MT_20344_BU_idea_FM_Yoga 2 13 > Family: IDEAPAD > Yeah, it has slightly different Version string in your case. Since patchwork (*) still didn't catch your patch you need to resend with all maintainers and mailing lists included like Darren suggested. (*) patchwork is a database which is tracking patches and patch series that are communicated thru mailing lists. It makes maintainer's life easier and allow to keep a trail of what has been done and when. The web interface to our project is here https://patchwork.kernel.org/project/platform-driver-x86/list/ > Loic > > On Tue, Nov 13, 2018 at 9:16 PM Darren Hart <dvhart@infradead.org> wrote: >> >> On Tue, Nov 13, 2018 at 06:22:45PM -0800, Loic WEI YU NENG wrote: >> > Some Lenovo ideapad models lack a physical rfkill switch. >> > On Lenovo models Yoga 2 13, ideapad-laptop would wrongly report all >> > radios as blocked by hardware which caused wireless network connections >> > to fail. >> > Add these models without an rfkill switch to the no_hw_rfkill list. >> > >> > Signed-off-by: Loic WEI YU NENG <loic.wyn@gmail.com> >> >> Thank you for the patch. >> >> In the future, please be sure to check MAINTAINERS and include the >> relevant lists, now Cc'd. >> >> I see this in the context of your patch, but can you confirm the current >> driver fails to match your system? It contains the following, which I >> would expect to match: >> >> .ident = "Lenovo Yoga 2 11 / 13 / Pro", >> .matches = { >> DMI_MATCH(DMI_SYS_VENDOR, "LENOVO"), >> DMI_MATCH(DMI_BOARD_NAME, "Yoga2"), >> }, >> >> If it doesn't match, what does dmidecode report for SYS_VENDOR and >> BOARD_NAME on your system? Perhaps we need to make the above more >> generic. >> >> > --- >> > drivers/platform/x86/ideapad-laptop.c | 7 +++++++ >> > 1 file changed, 7 insertions(+) >> > >> > diff --git a/drivers/platform/x86/ideapad-laptop.c b/drivers/platform/x86/ideapad-laptop.c >> > index b6489cba2985..1589dffab9fa 100644 >> > --- a/drivers/platform/x86/ideapad-laptop.c >> > +++ b/drivers/platform/x86/ideapad-laptop.c >> > @@ -1188,6 +1188,13 @@ static const struct dmi_system_id no_hw_rfkill_list[] = { >> > DMI_MATCH(DMI_BOARD_NAME, "Yoga2"), >> > }, >> > }, >> > + { >> > + .ident = "Lenovo Yoga 2 13", >> > + .matches = { >> > + DMI_MATCH(DMI_SYS_VENDOR, "LENOVO"), >> > + DMI_MATCH(DMI_PRODUCT_VERSION, "Yoga 2 13"), >> > + }, >> > + }, >> > { >> > .ident = "Lenovo Yoga 3 1170 / 1470", >> > .matches = { >> > -- >> > 2.17.1 >> > >> > >> >> -- >> Darren Hart >> VMware Open Source Technology Center > > > > -- > Loic WEI YU NENG > US phone: +1 408 218 2826 > FR phone: +33 674201069 > email: loic.wyn@gmail.com -- With Best Regards, Andy Shevchenko ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] ideapad-laptop: Add Lenovo Yoga 2 13 to the no_hw_rfkill DMI list 2018-11-14 10:52 ` Andy Shevchenko @ 2018-11-14 15:15 ` Loic Wei-Yu-Neng 0 siblings, 0 replies; 6+ messages in thread From: Loic Wei-Yu-Neng @ 2018-11-14 15:15 UTC (permalink / raw) To: Andy Shevchenko Cc: Darren Hart, Ike Panhc, Andy Shevchenko, Jiri Kosina, platform-driver-x86, LKML Sounds good, I can me my patch here now: https://patchwork.kernel.org/patch/10682745/ Loic On Wed, Nov 14, 2018 at 2:52 AM Andy Shevchenko <andy.shevchenko@gmail.com> wrote: > > On Wed, Nov 14, 2018 at 9:48 AM Loic Wei-Yu-Neng <loic.wyn@gmail.com> wrote: > > > > Hello Darren, > > Yes, the current driver fails to match match my laptop. I need to add this patch to have wifi functional on my laptop. > > Here is the dmidecode snippet from my laptop: > > > > Handle 0x0001, DMI type 1, 27 bytes > > System Information > > Manufacturer: LENOVO > > Product Name: 20344 > > Version: Yoga 2 13 > > Serial Number: 3438666500284 > > UUID: 933A1748-ACE0-E311-A534-F8A9633129FA > > Wake-up Type: Power Switch > > SKU Number: LENOVO_MT_20344_BU_idea_FM_Yoga 2 13 > > Family: IDEAPAD > > > > Yeah, it has slightly different Version string in your case. > > Since patchwork (*) still didn't catch your patch you need to resend > with all maintainers and mailing lists included like Darren suggested. > > (*) patchwork is a database which is tracking patches and patch series > that are communicated thru mailing lists. It makes maintainer's life > easier and allow to keep a trail of what has been done and when. > The web interface to our project is here > https://patchwork.kernel.org/project/platform-driver-x86/list/ > > > > Loic > > > > On Tue, Nov 13, 2018 at 9:16 PM Darren Hart <dvhart@infradead.org> wrote: > >> > >> On Tue, Nov 13, 2018 at 06:22:45PM -0800, Loic WEI YU NENG wrote: > >> > Some Lenovo ideapad models lack a physical rfkill switch. > >> > On Lenovo models Yoga 2 13, ideapad-laptop would wrongly report all > >> > radios as blocked by hardware which caused wireless network connections > >> > to fail. > >> > Add these models without an rfkill switch to the no_hw_rfkill list. > >> > > >> > Signed-off-by: Loic WEI YU NENG <loic.wyn@gmail.com> > >> > >> Thank you for the patch. > >> > >> In the future, please be sure to check MAINTAINERS and include the > >> relevant lists, now Cc'd. > >> > >> I see this in the context of your patch, but can you confirm the current > >> driver fails to match your system? It contains the following, which I > >> would expect to match: > >> > >> .ident = "Lenovo Yoga 2 11 / 13 / Pro", > >> .matches = { > >> DMI_MATCH(DMI_SYS_VENDOR, "LENOVO"), > >> DMI_MATCH(DMI_BOARD_NAME, "Yoga2"), > >> }, > >> > >> If it doesn't match, what does dmidecode report for SYS_VENDOR and > >> BOARD_NAME on your system? Perhaps we need to make the above more > >> generic. > >> > >> > --- > >> > drivers/platform/x86/ideapad-laptop.c | 7 +++++++ > >> > 1 file changed, 7 insertions(+) > >> > > >> > diff --git a/drivers/platform/x86/ideapad-laptop.c b/drivers/platform/x86/ideapad-laptop.c > >> > index b6489cba2985..1589dffab9fa 100644 > >> > --- a/drivers/platform/x86/ideapad-laptop.c > >> > +++ b/drivers/platform/x86/ideapad-laptop.c > >> > @@ -1188,6 +1188,13 @@ static const struct dmi_system_id no_hw_rfkill_list[] = { > >> > DMI_MATCH(DMI_BOARD_NAME, "Yoga2"), > >> > }, > >> > }, > >> > + { > >> > + .ident = "Lenovo Yoga 2 13", > >> > + .matches = { > >> > + DMI_MATCH(DMI_SYS_VENDOR, "LENOVO"), > >> > + DMI_MATCH(DMI_PRODUCT_VERSION, "Yoga 2 13"), > >> > + }, > >> > + }, > >> > { > >> > .ident = "Lenovo Yoga 3 1170 / 1470", > >> > .matches = { > >> > -- > >> > 2.17.1 > >> > > >> > > >> > >> -- > >> Darren Hart > >> VMware Open Source Technology Center > > > > > > > > -- > > Loic WEI YU NENG > > US phone: +1 408 218 2826 > > FR phone: +33 674201069 > > email: loic.wyn@gmail.com > > > > -- > With Best Regards, > Andy Shevchenko -- Loic WEI YU NENG US phone: +1 408 218 2826 FR phone: +33 674201069 email: loic.wyn@gmail.com ^ permalink raw reply [flat|nested] 6+ messages in thread
[parent not found: <20180516011741.18010-1-loic.wyn@gmail.com>]
[parent not found: <CAHp75VfY3nYgoUD3kjkZrMHzg2MZVNhgWiXJtxZAfpx_3ZGELQ@mail.gmail.com>]
[parent not found: <CAJxRB+DUzxf2dAwBSPP2FTLkwXHGM22WvUM0yrLGB4inPE3O5A@mail.gmail.com>]
[parent not found: <CAJxRB+C3xzL_m755ifoVzPugCg=bCbb-_mMOvkoH7iUvs3MV8w@mail.gmail.com>]
* Re: [PATCH] ideapad-laptop: Add Lenovo Yoga 2 13 to the no_hw_rfkill DMI list [not found] ` <CAJxRB+C3xzL_m755ifoVzPugCg=bCbb-_mMOvkoH7iUvs3MV8w@mail.gmail.com> @ 2018-11-13 12:52 ` Andy Shevchenko 0 siblings, 0 replies; 6+ messages in thread From: Andy Shevchenko @ 2018-11-13 12:52 UTC (permalink / raw) To: Loic Wei-Yu-Neng, Platform Driver, Linux Kernel Mailing List Cc: Ike Panhc, Darren Hart, Andy Shevchenko, Jiri Kosina +Cc: mailing lists On Tue, Nov 13, 2018 at 5:21 AM Loic Wei-Yu-Neng <loic.wyn@gmail.com> wrote: > Here you go, > I attached my patch. Thanks, though in a kernel we have not using attachments. Moreover, since you forgot to include mailing lists the patchwork doesn't catch this either. Can you send it in a regular way, i.e. using `git format-patch ... && git send-email ...` ? > I rebased it on top of today's latest: > * 7946462d31a0 (HEAD -> test) ideapad-laptop: Add Lenovo Yoga 2 13 to the no_hw_rfkill DMI list > * ccda4af0f4b9 (tag: v4.20-rc2, origin/master, origin/HEAD) Linux 4.20-rc2 > * 7a3765ed66d1 Merge git://git.kernel.org/pub/scm/linux/kernel/git/davem/net > |\ > | * 7236ead1b149 act_mirred: clear skb->tstamp on redirect > | * a9049ff9214d net: dsa: mv88e6xxx: Fix clearing of stats counters > | * 7ab412d33b4c tipc: fix link re-establish failure > | * 63c82997f5c0 net: sched: cls_flower: validate nested enc_opts_policy to avoid warning > | * fbd1d5245372 net: mvneta: correct typo > | * 62230715fd24 flow_dissector: do not dissect l4 ports for fragments > | * d02854dc1999 net: qualcomm: rmnet: Fix incorrect assignment of real_dev > > Loic > > On Fri, Oct 19, 2018 at 7:10 AM Loic Wei-Yu-Neng <loic.wyn@gmail.com> wrote: >> >> Hello Andy, >> Sure let me do that. >> Loic >> >> On Fri, Oct 19, 2018, 4:29 AM Andy Shevchenko <andy.shevchenko@gmail.com wrote: >>> >>> On Wed, May 16, 2018 at 4:18 AM Loic WEI YU NENG <loic.wyn@gmail.com> wrote: >>> > >>> > Some Lenovo ideapad models lack a physical rfkill switch. >>> > On Lenovo models Yoga 2 13, ideapad-laptop would wrongly report all >>> > radios as blocked by hardware which caused wireless network connections >>> > to fail. >>> > Add these models without an rfkill switch to the no_hw_rfkill list. >>> > >>> >>> I'm very sorry, but by some unclear reason this patch is missed in the >>> tree and in our patchwork. >>> Does it still actual? >>> >>> May you resend it rebased on top of our for-next branch? >>> >>> > Signed-off-by: Loic WEI YU NENG <loic.wyn@gmail.com> >>> > --- >>> > drivers/platform/x86/ideapad-laptop.c | 7 +++++++ >>> > 1 file changed, 7 insertions(+) >>> > >>> > diff --git a/drivers/platform/x86/ideapad-laptop.c b/drivers/platform/x86/ideapad-laptop.c >>> > index 535199c9e6bc..0a843c4ca4fc 100644 >>> > --- a/drivers/platform/x86/ideapad-laptop.c >>> > +++ b/drivers/platform/x86/ideapad-laptop.c >>> > @@ -1114,6 +1114,13 @@ static const struct dmi_system_id no_hw_rfkill_list[] = { >>> > DMI_MATCH(DMI_BOARD_NAME, "Yoga2"), >>> > }, >>> > }, >>> > + { >>> > + .ident = "Lenovo Yoga 2 13", >>> > + .matches = { >>> > + DMI_MATCH(DMI_SYS_VENDOR, "LENOVO"), >>> > + DMI_MATCH(DMI_PRODUCT_VERSION, "Yoga 2 13"), >>> > + }, >>> > + }, >>> > { >>> > .ident = "Lenovo Yoga 3 1170 / 1470", >>> > .matches = { >>> > -- >>> > 2.17.0 >>> > >>> >>> >>> -- >>> With Best Regards, >>> Andy Shevchenko > > > > -- > Loic WEI YU NENG > US phone: +1 408 218 2826 > FR phone: +33 674201069 > email: loic.wyn@gmail.com -- With Best Regards, Andy Shevchenko ^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2018-11-14 16:02 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-11-14 15:12 [PATCH] ideapad-laptop: Add Lenovo Yoga 2 13 to the no_hw_rfkill DMI list Loic WEI YU NENG
2018-11-14 16:01 ` Andy Shevchenko
[not found] <20181114022245.5798-1-loic.wyn@gmail.com>
2018-11-14 5:16 ` Darren Hart
[not found] ` <CAJxRB+DyrRWLTsW6fpOYuhS5W3iS3FATSRsoQTFx9ZJjzLv_dg@mail.gmail.com>
2018-11-14 10:52 ` Andy Shevchenko
2018-11-14 15:15 ` Loic Wei-Yu-Neng
[not found] <20180516011741.18010-1-loic.wyn@gmail.com>
[not found] ` <CAHp75VfY3nYgoUD3kjkZrMHzg2MZVNhgWiXJtxZAfpx_3ZGELQ@mail.gmail.com>
[not found] ` <CAJxRB+DUzxf2dAwBSPP2FTLkwXHGM22WvUM0yrLGB4inPE3O5A@mail.gmail.com>
[not found] ` <CAJxRB+C3xzL_m755ifoVzPugCg=bCbb-_mMOvkoH7iUvs3MV8w@mail.gmail.com>
2018-11-13 12:52 ` Andy Shevchenko
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).