From: David Hildenbrand <david@redhat.com>
To: linux-mm@kvack.org
Cc: linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org,
devel@linuxdriverproject.org, linux-fsdevel@vger.kernel.org,
linux-pm@vger.kernel.org, xen-devel@lists.xenproject.org,
David Hildenbrand <david@redhat.com>,
"K. Y. Srinivasan" <kys@microsoft.com>,
Haiyang Zhang <haiyangz@microsoft.com>,
Stephen Hemminger <sthemmin@microsoft.com>,
Kairui Song <kasong@redhat.com>,
Vitaly Kuznetsov <vkuznets@redhat.com>,
Andrew Morton <akpm@linux-foundation.org>,
Matthew Wilcox <willy@infradead.org>,
Michal Hocko <mhocko@suse.com>,
"Michael S. Tsirkin" <mst@redhat.com>
Subject: [PATCH RFC 5/6] hv_balloon: mark inflated pages PG_offline
Date: Wed, 14 Nov 2018 22:17:03 +0100 [thread overview]
Message-ID: <20181114211704.6381-6-david@redhat.com> (raw)
In-Reply-To: <20181114211704.6381-1-david@redhat.com>
Mark inflated and never onlined pages PG_offline, to tell the world that
the content is stale and should not be dumped.
Cc: "K. Y. Srinivasan" <kys@microsoft.com>
Cc: Haiyang Zhang <haiyangz@microsoft.com>
Cc: Stephen Hemminger <sthemmin@microsoft.com>
Cc: Kairui Song <kasong@redhat.com>
Cc: Vitaly Kuznetsov <vkuznets@redhat.com>
Cc: Andrew Morton <akpm@linux-foundation.org>
Cc: Matthew Wilcox <willy@infradead.org>
Cc: Michal Hocko <mhocko@suse.com>
Cc: "Michael S. Tsirkin" <mst@redhat.com>
Signed-off-by: David Hildenbrand <david@redhat.com>
---
drivers/hv/hv_balloon.c | 14 ++++++++++++--
1 file changed, 12 insertions(+), 2 deletions(-)
diff --git a/drivers/hv/hv_balloon.c b/drivers/hv/hv_balloon.c
index 5728dc470eeb..778b6f879d1c 100644
--- a/drivers/hv/hv_balloon.c
+++ b/drivers/hv/hv_balloon.c
@@ -681,8 +681,13 @@ static struct notifier_block hv_memory_nb = {
/* Check if the particular page is backed and can be onlined and online it. */
static void hv_page_online_one(struct hv_hotadd_state *has, struct page *pg)
{
- if (!has_pfn_is_backed(has, page_to_pfn(pg)))
+ if (!has_pfn_is_backed(has, page_to_pfn(pg))) {
+ if (!PageOffline(pg))
+ __SetPageOffline(pg);
return;
+ }
+ if (PageOffline(pg))
+ __ClearPageOffline(pg);
/* This frame is currently backed; online the page. */
__online_page_set_limits(pg);
@@ -1200,6 +1205,7 @@ static void free_balloon_pages(struct hv_dynmem_device *dm,
for (i = 0; i < num_pages; i++) {
pg = pfn_to_page(i + start_frame);
+ __ClearPageOffline(pg);
__free_page(pg);
dm->num_pages_ballooned--;
}
@@ -1212,7 +1218,7 @@ static unsigned int alloc_balloon_pages(struct hv_dynmem_device *dm,
struct dm_balloon_response *bl_resp,
int alloc_unit)
{
- unsigned int i = 0;
+ unsigned int i, j;
struct page *pg;
if (num_pages < alloc_unit)
@@ -1244,6 +1250,10 @@ static unsigned int alloc_balloon_pages(struct hv_dynmem_device *dm,
if (alloc_unit != 1)
split_page(pg, get_order(alloc_unit << PAGE_SHIFT));
+ /* mark all pages offline */
+ for (j = 0; j < (1 << get_order(alloc_unit << PAGE_SHIFT)); j++)
+ __SetPageOffline(pg + j);
+
bl_resp->range_count++;
bl_resp->range_array[i].finfo.start_page =
page_to_pfn(pg);
--
2.17.2
next prev parent reply other threads:[~2018-11-14 21:18 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-14 21:16 [PATCH RFC 0/6] mm/kdump: allow to exclude pages that are logically offline David Hildenbrand
2018-11-14 21:16 ` [PATCH RFC 1/6] mm: balloon: update comment about isolation/migration/compaction David Hildenbrand
2018-11-14 21:17 ` [PATCH RFC 2/6] mm: convert PG_balloon to PG_offline David Hildenbrand
2018-11-14 22:23 ` Matthew Wilcox
2018-11-14 22:49 ` David Hildenbrand
2018-11-15 2:07 ` Mike Rapoport
2018-11-15 9:21 ` David Hildenbrand
2018-11-15 12:19 ` Michal Hocko
2018-11-14 21:17 ` [PATCH RFC 3/6] kexec: export PG_offline to VMCOREINFO David Hildenbrand
2018-11-15 6:19 ` Dave Young
2018-11-15 9:23 ` David Hildenbrand
2018-11-15 11:10 ` Borislav Petkov
2018-11-15 11:20 ` David Hildenbrand
2018-11-15 11:52 ` Borislav Petkov
2018-11-15 12:01 ` David Hildenbrand
2018-11-15 17:58 ` Borislav Petkov
2018-11-15 12:11 ` Michal Hocko
2018-11-15 14:13 ` Borislav Petkov
2018-11-14 21:17 ` [PATCH RFC 4/6] xen/balloon: mark inflated pages PG_offline David Hildenbrand
2018-11-14 21:17 ` David Hildenbrand [this message]
2018-11-14 21:17 ` [PATCH RFC 6/6] PM / Hibernate: exclude all PageOffline() pages David Hildenbrand
2018-11-15 7:48 ` Pavel Machek
2018-11-15 12:23 ` Michal Hocko
2018-11-15 12:29 ` David Hildenbrand
2018-11-14 22:57 ` [PATCH RFC 0/6] mm/kdump: allow to exclude pages that are logically offline Nadav Amit
2018-11-14 23:05 ` David Hildenbrand
2018-11-14 23:41 ` Nadav Amit
2018-11-15 1:42 ` Julien Freche
2018-11-16 18:23 ` David Hildenbrand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181114211704.6381-6-david@redhat.com \
--to=david@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=devel@linuxdriverproject.org \
--cc=haiyangz@microsoft.com \
--cc=kasong@redhat.com \
--cc=kys@microsoft.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-pm@vger.kernel.org \
--cc=mhocko@suse.com \
--cc=mst@redhat.com \
--cc=sthemmin@microsoft.com \
--cc=vkuznets@redhat.com \
--cc=willy@infradead.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).