linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
To: Parthiban Nallathambi <pn@denx.de>
Cc: linus.walleij@linaro.org, afaerber@suse.de, robh+dt@kernel.org,
	mark.rutland@arm.com, linux-gpio@vger.kernel.org,
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org, catalin.marinas@arm.com,
	will.deacon@arm.com, mp-cs@actions-semi.com,
	thomas.liau@actions-semi.com, linux@cubietech.com,
	sravanhome@gmail.com
Subject: Re: [PATCH v6 0/5] Add Actions Semi S700 pinctrl support
Date: Thu, 15 Nov 2018 16:31:04 +0530	[thread overview]
Message-ID: <20181115110104.GB15537@Mani-XPS-13-9360> (raw)
In-Reply-To: <20181113100709.5615-1-pn@denx.de>

On Tue, Nov 13, 2018 at 11:07:04AM +0100, Parthiban Nallathambi wrote:
> This patchset adds pinctrl support for Actions Semi S700 SoC.
> Pinmux functions are only accessible for pin groups while pinconf
> parameters are available for both pin groups and individual pins.
> 
> pinctrl driver is verified using the Cubieboard7.
> 
> common functionalities from s900 is moved for all Actions Semi
> SoC's usage.
> Common pad control configurations are moved to SoC specific
>

Hi Parthiban,

This series looks good to me. Just spotted one nitpick in bindings
patch. Please note that I don't have any S900 device currently to test
the patches. Although nothing looks like breaking.

So for the whole series,

Acked-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>

Thanks a ton for picking it up!

Regards,
Mani

> dts entry for pinctrl depends on clock driver which is still under review:
> https://patchwork.kernel.org/patch/10533959/
> 
> Thanks,
> Saravanan
> Parthiban
> 
> Changelog in v2
> - GPIO Interrupt support is added
> - Device tree entry for GPIO and Interrupt configured
> - GPIO and pinctrl define reorder, commit message findings fixed
> 
> depends on owl GPIO Interrupt support
> https://patchwork.kernel.org/patch/10483477/
> 
> Chnagelog in v3
> - Fixed 0-DAY bisectibility error
> 
> Chnagelog in v4
> - Fixed 0-DAY sparse warnings on static declaration
> 
> Chnagelog in v5
> - Rebase to mainline
> 
> Chnagelog in v6
> - Rebase to 4.20-rc2 mainline
> - Fixed nitpick findings in v5
> 
> Saravanan Sekar (5):
>   pinctrl: actions: define constructor generic to Actions Semi SoC's
>   pinctrl: actions: define pad control configurtion to SoC specific
>   dt-bindings: pinctrl: Add bindings for Actions Semi S700 SoC
>   pinctrl: actions: Add Actions Semi S700 pinctrl driver
>   arm64: dts: actions: Add pinctrl node for Actions Semi S700
> 
>  .../bindings/pinctrl/actions,s700-pinctrl.txt |  170 ++
>  arch/arm64/boot/dts/actions/s700.dtsi         |   16 +
>  drivers/pinctrl/actions/Kconfig               |    6 +
>  drivers/pinctrl/actions/Makefile              |    1 +
>  drivers/pinctrl/actions/pinctrl-owl.c         |   71 +-
>  drivers/pinctrl/actions/pinctrl-owl.h         |  142 +-
>  drivers/pinctrl/actions/pinctrl-s700.c        | 1912 +++++++++++++++++
>  drivers/pinctrl/actions/pinctrl-s900.c        |  205 +-
>  8 files changed, 2324 insertions(+), 199 deletions(-)
>  create mode 100644 Documentation/devicetree/bindings/pinctrl/actions,s700-pinctrl.txt
>  create mode 100644 drivers/pinctrl/actions/pinctrl-s700.c
> 
> -- 
> 2.17.2
> 

      parent reply	other threads:[~2018-11-15 11:01 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-11-13 10:07 Parthiban Nallathambi
2018-11-13 10:07 ` [PATCH v6 1/5] pinctrl: actions: define constructor generic to Actions Semi SoC's Parthiban Nallathambi
2018-11-13 10:07 ` [PATCH v6 2/5] pinctrl: actions: define pad control configurtion to SoC specific Parthiban Nallathambi
2018-11-13 10:07 ` [PATCH v6 3/5] dt-bindings: pinctrl: Add bindings for Actions Semi S700 SoC Parthiban Nallathambi
2018-11-15 10:55   ` Manivannan Sadhasivam
2018-11-15 11:53     ` Parthiban Nallathambi
2018-11-13 10:07 ` [PATCH v6 4/5] pinctrl: actions: Add Actions Semi S700 pinctrl driver Parthiban Nallathambi
2018-11-13 10:07 ` [PATCH v6 5/5] arm64: dts: actions: Add pinctrl node for Actions Semi S700 Parthiban Nallathambi
2018-11-15 10:10 ` [PATCH v6 0/5] Add Actions Semi S700 pinctrl support Linus Walleij
2018-11-15 11:01 ` Manivannan Sadhasivam [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20181115110104.GB15537@Mani-XPS-13-9360 \
    --to=manivannan.sadhasivam@linaro.org \
    --cc=afaerber@suse.de \
    --cc=catalin.marinas@arm.com \
    --cc=devicetree@vger.kernel.org \
    --cc=linus.walleij@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-gpio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@cubietech.com \
    --cc=mark.rutland@arm.com \
    --cc=mp-cs@actions-semi.com \
    --cc=pn@denx.de \
    --cc=robh+dt@kernel.org \
    --cc=sravanhome@gmail.com \
    --cc=thomas.liau@actions-semi.com \
    --cc=will.deacon@arm.com \
    --subject='Re: [PATCH v6 0/5] Add Actions Semi S700 pinctrl support' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).