From: Andrew Morton <akpm@linux-foundation.org>
To: Jan Kara <jack@suse.cz>
Cc: Pavel Tikhomirov <ptikhomirov@virtuozzo.com>,
Vasily Averin <vvs@virtuozzo.com>,
Andrey Ryabinin <aryabinin@virtuozzo.com>,
Konstantin Khorenko <khorenko@virtuozzo.com>,
Johannes Weiner <hannes@cmpxchg.org>,
Mel Gorman <mgorman@techsingularity.net>,
Matthew Wilcox <willy@infradead.org>,
Andi Kleen <ak@linux.intel.com>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mm: cleancache: fix corruption on missed inode invalidation
Date: Thu, 15 Nov 2018 14:29:59 -0800 [thread overview]
Message-ID: <20181115142959.89ecdb6b4f24a1427062d861@linux-foundation.org> (raw)
In-Reply-To: <20181112113153.GC7175@quack2.suse.cz>
On Mon, 12 Nov 2018 12:31:53 +0100 Jan Kara <jack@suse.cz> wrote:
> > mm/truncate.c | 4 ++--
> > 1 file changed, 2 insertions(+), 2 deletions(-)
>
> The patch looks good but can you add a short comment before the
> truncate_inode_pages() call explaining why it needs to be called always?
> Something like:
>
> /*
> * Cleancache needs notification even if there are no pages or
> * shadow entries...
> */
--- a/mm/truncate.c~mm-cleancache-fix-corruption-on-missed-inode-invalidation-fix
+++ a/mm/truncate.c
@@ -519,6 +519,10 @@ void truncate_inode_pages_final(struct a
xa_unlock_irq(&mapping->i_pages);
}
+ /*
+ * Cleancache needs notification even if there are no pages or shadow
+ * entries.
+ */
truncate_inode_pages(mapping, 0);
}
EXPORT_SYMBOL(truncate_inode_pages_final);
_
next prev parent reply other threads:[~2018-11-15 22:30 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-12 9:57 [PATCH] mm: cleancache: fix corruption on missed inode invalidation Pavel Tikhomirov
2018-11-12 11:31 ` Jan Kara
2018-11-12 11:40 ` Andrey Ryabinin
2018-11-12 11:54 ` Jan Kara
2018-11-12 12:00 ` [PATCH v2] " Pavel Tikhomirov
2018-11-15 22:29 ` Andrew Morton [this message]
2018-11-15 22:31 ` [PATCH] " Andrew Morton
2018-11-16 7:55 ` Vasily Averin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181115142959.89ecdb6b4f24a1427062d861@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=ak@linux.intel.com \
--cc=aryabinin@virtuozzo.com \
--cc=hannes@cmpxchg.org \
--cc=jack@suse.cz \
--cc=khorenko@virtuozzo.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mgorman@techsingularity.net \
--cc=ptikhomirov@virtuozzo.com \
--cc=vvs@virtuozzo.com \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).