From: Dan Carpenter <dan.carpenter@oracle.com>
To: kbuild@01.org,
Naga Sureshkumar Relli <naga.sureshkumar.relli@xilinx.com>
Cc: kbuild-all@01.org, boris.brezillon@bootlin.com,
miquel.raynal@bootlin.com, richard@nod.at, dwmw2@infradead.org,
computersforpeace@gmail.com, marek.vasut@gmail.com,
michals@xilinx.com, linux-mtd@lists.infradead.org,
linux-kernel@vger.kernel.org, nagasuresh12@gmail.com,
robh@kernel.org,
Naga Sureshkumar Relli <naga.sureshkumar.relli@xilinx.com>
Subject: Re: [LINUX PATCH v12 3/3] mtd: rawnand: arasan: Add support for Arasan NAND Flash Controller
Date: Thu, 15 Nov 2018 19:45:52 +0300 [thread overview]
Message-ID: <20181115164552.GB14069@unbuntlaptop> (raw)
In-Reply-To: <1541739641-17789-4-git-send-email-naga.sureshkumar.relli@xilinx.com>
Hi Naga,
Thank you for the patch! Perhaps something to improve:
url: https://github.com/0day-ci/linux/commits/Naga-Sureshkumar-Relli/dt-bindings-mtd-arasan-Add-device-tree-binding-documentation/20181110-034106
base: git://git.infradead.org/linux-mtd.git nand/next
smatch warnings:
drivers/mtd/nand/raw/arasan_nand.c:353 anfc_rw_dma_op() warn: right shifting more than type allows 32 vs 32
drivers/mtd/nand/raw/arasan_nand.c:1032 anfc_setup_data_interface() warn: unsigned 'sdr->mode' is never less than zero.
# https://github.com/0day-ci/linux/commit/8db68ae6047a392d3e4092cbd6d3051eec1edd47
git remote add linux-review https://github.com/0day-ci/linux
git remote update linux-review
git checkout 8db68ae6047a392d3e4092cbd6d3051eec1edd47
vim +353 drivers/mtd/nand/raw/arasan_nand.c
8db68ae6 Naga Sureshkumar Relli 2018-11-09 325
8db68ae6 Naga Sureshkumar Relli 2018-11-09 326 static void anfc_rw_dma_op(struct mtd_info *mtd, u8 *buf, int len,
8db68ae6 Naga Sureshkumar Relli 2018-11-09 327 bool do_read, u32 prog, int pktcount, int pktsize)
8db68ae6 Naga Sureshkumar Relli 2018-11-09 328 {
8db68ae6 Naga Sureshkumar Relli 2018-11-09 329 dma_addr_t paddr;
8db68ae6 Naga Sureshkumar Relli 2018-11-09 330 struct nand_chip *chip = mtd_to_nand(mtd);
8db68ae6 Naga Sureshkumar Relli 2018-11-09 331 struct anfc_nand_controller *nfc = to_anfc(chip->controller);
8db68ae6 Naga Sureshkumar Relli 2018-11-09 332 struct anfc_nand_chip *achip = to_anfc_nand(chip);
8db68ae6 Naga Sureshkumar Relli 2018-11-09 333 u32 eccintr = 0, dir;
8db68ae6 Naga Sureshkumar Relli 2018-11-09 334
8db68ae6 Naga Sureshkumar Relli 2018-11-09 335 if (pktsize == 0)
8db68ae6 Naga Sureshkumar Relli 2018-11-09 336 pktsize = len;
8db68ae6 Naga Sureshkumar Relli 2018-11-09 337
8db68ae6 Naga Sureshkumar Relli 2018-11-09 338 anfc_setpktszcnt(nfc, pktsize, pktcount);
8db68ae6 Naga Sureshkumar Relli 2018-11-09 339
8db68ae6 Naga Sureshkumar Relli 2018-11-09 340 if (!achip->strength)
8db68ae6 Naga Sureshkumar Relli 2018-11-09 341 eccintr = MBIT_ERROR;
8db68ae6 Naga Sureshkumar Relli 2018-11-09 342
8db68ae6 Naga Sureshkumar Relli 2018-11-09 343 if (do_read)
8db68ae6 Naga Sureshkumar Relli 2018-11-09 344 dir = DMA_FROM_DEVICE;
8db68ae6 Naga Sureshkumar Relli 2018-11-09 345 else
8db68ae6 Naga Sureshkumar Relli 2018-11-09 346 dir = DMA_TO_DEVICE;
8db68ae6 Naga Sureshkumar Relli 2018-11-09 347 paddr = dma_map_single(nfc->dev, buf, len, dir);
8db68ae6 Naga Sureshkumar Relli 2018-11-09 348 if (dma_mapping_error(nfc->dev, paddr)) {
8db68ae6 Naga Sureshkumar Relli 2018-11-09 349 dev_err(nfc->dev, "Read buffer mapping error");
8db68ae6 Naga Sureshkumar Relli 2018-11-09 350 return;
8db68ae6 Naga Sureshkumar Relli 2018-11-09 351 }
8db68ae6 Naga Sureshkumar Relli 2018-11-09 352 writel(paddr, nfc->base + DMA_ADDR0_OFST);
8db68ae6 Naga Sureshkumar Relli 2018-11-09 @353 writel((paddr >> 32), nfc->base + DMA_ADDR1_OFST);
^^^^^^^^^^^^^
This is zero. Which is probably intended and fine... I was hoping it
would have the other line 1032 warning in the email...
8db68ae6 Naga Sureshkumar Relli 2018-11-09 354 anfc_enable_intrs(nfc, (XFER_COMPLETE | eccintr));
8db68ae6 Naga Sureshkumar Relli 2018-11-09 355 writel(prog, nfc->base + PROG_OFST);
8db68ae6 Naga Sureshkumar Relli 2018-11-09 356 anfc_wait_for_event(nfc);
8db68ae6 Naga Sureshkumar Relli 2018-11-09 357 dma_unmap_single(nfc->dev, paddr, len, dir);
8db68ae6 Naga Sureshkumar Relli 2018-11-09 358 }
8db68ae6 Naga Sureshkumar Relli 2018-11-09 359
---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation
next prev parent reply other threads:[~2018-11-15 16:46 UTC|newest]
Thread overview: 48+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-09 5:00 [LINUX PATCH v12 0/3] Add support for Arasan NAND Flash controller Naga Sureshkumar Relli
2018-11-09 5:00 ` [LINUX PATCH v12 1/3] dt-bindings: mtd: arasan: Add device tree binding documentation Naga Sureshkumar Relli
2018-11-09 6:28 ` Boris Brezillon
2018-11-09 12:33 ` Naga Sureshkumar Relli
2018-11-09 12:54 ` Miquel Raynal
2018-11-09 13:19 ` Naga Sureshkumar Relli
2018-11-16 11:50 ` Martin Lund
2018-11-16 12:10 ` Martin Lund
2018-11-16 12:33 ` Michal Simek
2018-11-16 13:50 ` Naga Sureshkumar Relli
2018-11-16 14:22 ` Martin Lund
2018-11-09 5:00 ` [LINUX PATCH v12 2/3] mtd: rawnand: Add an option to get sdr timing mode number Naga Sureshkumar Relli
2018-11-09 5:00 ` [LINUX PATCH v12 3/3] mtd: rawnand: arasan: Add support for Arasan NAND Flash Controller Naga Sureshkumar Relli
2018-11-09 8:07 ` Boris Brezillon
2018-11-09 13:18 ` Naga Sureshkumar Relli
2018-11-09 23:03 ` kbuild test robot
2018-11-12 10:55 ` Martin Lund
2018-11-12 10:58 ` Boris Brezillon
2018-11-12 12:43 ` Naga Sureshkumar Relli
2018-11-15 9:34 ` Naga Sureshkumar Relli
2018-11-18 18:52 ` Miquel Raynal
2018-11-18 19:43 ` Boris Brezillon
2018-11-19 6:20 ` Naga Sureshkumar Relli
2018-11-19 8:02 ` Boris Brezillon
2018-11-20 7:02 ` Naga Sureshkumar Relli
2018-11-20 11:02 ` Boris Brezillon
2018-11-20 12:36 ` Miquel Raynal
2018-11-23 13:53 ` Naga Sureshkumar Relli
2018-12-12 5:27 ` Naga Sureshkumar Relli
2018-12-12 8:11 ` Miquel Raynal
2018-12-12 9:04 ` Naga Sureshkumar Relli
2018-12-12 9:09 ` Miquel Raynal
2018-12-12 13:07 ` Naga Sureshkumar Relli
2018-12-12 13:18 ` Miquel Raynal
2018-12-17 13:21 ` Naga Sureshkumar Relli
2018-12-17 16:41 ` Miquel Raynal
2018-12-18 5:33 ` Naga Sureshkumar Relli
2018-12-19 14:26 ` Miquel Raynal
2018-12-21 7:36 ` Naga Sureshkumar Relli
2019-01-28 6:04 ` Naga Sureshkumar Relli
2019-01-28 9:27 ` Miquel Raynal
2019-01-28 9:35 ` Naga Sureshkumar Relli
2019-06-19 4:44 ` Naga Sureshkumar Relli
2019-06-27 16:27 ` Miquel Raynal
2019-06-28 4:20 ` Naga Sureshkumar Relli
2018-11-15 16:45 ` Dan Carpenter [this message]
2018-11-20 16:24 ` Boris Brezillon
2018-12-04 9:18 ` Naga Sureshkumar Relli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181115164552.GB14069@unbuntlaptop \
--to=dan.carpenter@oracle.com \
--cc=boris.brezillon@bootlin.com \
--cc=computersforpeace@gmail.com \
--cc=dwmw2@infradead.org \
--cc=kbuild-all@01.org \
--cc=kbuild@01.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=marek.vasut@gmail.com \
--cc=michals@xilinx.com \
--cc=miquel.raynal@bootlin.com \
--cc=naga.sureshkumar.relli@xilinx.com \
--cc=nagasuresh12@gmail.com \
--cc=richard@nod.at \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).