From: David Miller <davem@davemloft.net>
To: thesven73@gmail.com
Cc: svendev@arcx.com, siva.kallam@broadcom.com,
prashant@broadcom.com, mchan@broadcom.com,
linux-kernel@vger.kernel.org, netdev@vger.kernel.org,
arnd@arndb.de
Subject: Re: [PATCH v1] tg3: optionally get mac address from devicetree
Date: Fri, 16 Nov 2018 19:37:25 -0800 (PST) [thread overview]
Message-ID: <20181116.193725.1381952801953862286.davem@davemloft.net> (raw)
In-Reply-To: <20181113161508.7427-1-TheSven73@googlemail.com>
From: thesven73@gmail.com
Date: Tue, 13 Nov 2018 11:15:08 -0500
> If the tg3 has a device node, and that node contains a valid
> mac address property, use that as the tg3's mac address.
>
> This behaviour was previously only present on SPARC, using a
> conditional compile (#ifdef CONFIG_SPARC), presumably because
> at the time, devicetree nodes for pci devices only worked on
> SPARC. However, this has recently been made universal, see
> commit 98d9f30c820d ("pci/of: Match PCI devices to OF nodes dynamically")
>
> Devicetree example:
> (see Documentation/devicetree/bindings/pci/pci.txt)
>
> &pcie {
> host@0 {
> #address-cells = <3>;
> #size-cells = <2>;
> reg = <0 0 0 0 0>;
> bcm5778: bcm5778@0 {
> reg = <0 0 0 0 0>;
> mac-address = [CA 11 AB 1E 10 01];
> };
> };
> };
>
> Signed-off-by: Sven Van Asbroeck <svendev@arcx.com>
Please use eth_platform_get_mac_address() and you can delete all of the
SPARC specific code altogether.
prev parent reply other threads:[~2018-11-17 3:37 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-13 16:15 [PATCH v1] tg3: optionally get mac address from devicetree thesven73
2018-11-13 21:09 ` Andrew Lunn
2018-11-17 3:37 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181116.193725.1381952801953862286.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=arnd@arndb.de \
--cc=linux-kernel@vger.kernel.org \
--cc=mchan@broadcom.com \
--cc=netdev@vger.kernel.org \
--cc=prashant@broadcom.com \
--cc=siva.kallam@broadcom.com \
--cc=svendev@arcx.com \
--cc=thesven73@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).