From: David Miller <davem@davemloft.net>
To: ms@dev.tdt.de
Cc: andrew@lunn.ch, sergei.shtylyov@cogentembedded.com,
f.fainelli@gmail.com, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v5] net: phy: mdio-gpio: Fix working over slow can_sleep GPIOs
Date: Fri, 16 Nov 2018 23:04:13 -0800 (PST) [thread overview]
Message-ID: <20181116.230413.585228813283302740.davem@davemloft.net> (raw)
In-Reply-To: <20181115052428.8133-1-ms@dev.tdt.de>
From: Martin Schiller <ms@dev.tdt.de>
Date: Thu, 15 Nov 2018 06:24:28 +0100
> Up until commit 7e5fbd1e0700 ("net: mdio-gpio: Convert to use gpiod
> functions where possible"), the _cansleep variants of the gpio_ API was
> used. After that commit and the change to gpiod_ API, the _cansleep()
> was dropped. This then results in WARN_ON() when used with GPIO
> devices which do sleep. Add back the _cansleep() to avoid this.
>
> Fixes: 7e5fbd1e0700 ("net: mdio-gpio: Convert to use gpiod functions where possible")
> Signed-off-by: Martin Schiller <ms@dev.tdt.de>
Ok it seems there was still discussion going on here and I accidently applied
v4 of this patch.
I'll revert it and wait for the review to conclude.
next prev parent reply other threads:[~2018-11-17 7:04 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-14 6:17 [PATCH] net: phy: mdio-gpio: fix access that may sleep Martin Schiller
2018-11-14 6:37 ` [PATCH v2] " Martin Schiller
2018-11-14 7:05 ` Andrew Lunn
2018-11-14 7:43 ` Martin Schiller
2018-11-14 20:46 ` Andrew Lunn
2018-11-14 9:20 ` Sergei Shtylyov
2018-11-17 3:52 ` David Miller
2018-11-14 10:12 ` [PATCH v3] net: phy: mdio-gpio: Fix working over slow can_sleep GPIOs Martin Schiller
2018-11-14 11:03 ` Sergei Shtylyov
2018-11-14 11:54 ` [PATCH v4] " Martin Schiller
2018-11-17 4:25 ` David Miller
2018-11-17 6:28 ` Andrew Lunn
2018-11-15 5:24 ` [PATCH v5] " Martin Schiller
2018-11-15 20:12 ` Andrew Lunn
2018-11-17 7:04 ` David Miller [this message]
2018-11-16 7:38 ` [PATCH v6] " Martin Schiller
2018-11-16 7:53 ` Andrew Lunn
2018-11-17 19:52 ` Florian Fainelli
2018-11-18 5:12 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181116.230413.585228813283302740.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=andrew@lunn.ch \
--cc=f.fainelli@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=ms@dev.tdt.de \
--cc=netdev@vger.kernel.org \
--cc=sergei.shtylyov@cogentembedded.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).