linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Guenter Roeck <linux@roeck-us.net>
To: Florian Fainelli <f.fainelli@gmail.com>
Cc: arnd@arndb.de, Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] serial: 8250: Default SERIAL_OF_PLATFORM to SERIAL_8250
Date: Thu, 15 Nov 2018 17:16:56 -0800	[thread overview]
Message-ID: <20181116011656.GA21813@roeck-us.net> (raw)
In-Reply-To: <5937b814-ca5f-5786-93a1-3334df8c92dc@gmail.com>

On Thu, Nov 15, 2018 at 11:48:20AM -0800, Florian Fainelli wrote:
> 
> OK, would you mind testing this below? It seems to me that 8250_of.c is
> incompatible with arch/powerpc/kernel/legacy_serial.c and that is what
> is causing the issue here.
> 
> diff --git a/drivers/tty/serial/8250/Kconfig
> b/drivers/tty/serial/8250/Kconfig
> index d7737dca0e48..21cb14cbd34a 100644
> --- a/drivers/tty/serial/8250/Kconfig
> +++ b/drivers/tty/serial/8250/Kconfig
> @@ -483,7 +483,7 @@ config SERIAL_8250_PXA
> 
>  config SERIAL_OF_PLATFORM
>         tristate "Devicetree based probing for 8250 ports"
> -       depends on SERIAL_8250 && OF
> +       depends on SERIAL_8250 && OF && !(PPC && PPC_UDBG_16550)
>         default SERIAL_8250
>         help
>           This option is used for all 8250 compatible serial ports that

44x/virtex5_defconfig has both PPC_UDBG_16550 and SERIAL_OF_PLATFORM enabled
and fails to boot (or display anything on the console) with this patch applied.

Guenter

  reply	other threads:[~2018-11-16  1:17 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-11-15  1:11 [PATCH] serial: 8250: Default SERIAL_OF_PLATFORM to SERIAL_8250 Guenter Roeck
2018-11-15  3:56 ` Florian Fainelli
2018-11-15  5:36   ` Guenter Roeck
2018-11-15 17:19     ` Florian Fainelli
2018-11-15  5:38   ` Guenter Roeck
2018-11-15 17:19     ` Florian Fainelli
2018-11-15 17:25       ` Guenter Roeck
2018-11-15 19:48         ` Florian Fainelli
2018-11-16  1:16           ` Guenter Roeck [this message]
2018-11-19 18:44             ` Florian Fainelli
2018-11-19 20:50               ` Guenter Roeck
2018-11-23 18:20                 ` Guenter Roeck
2018-11-27  0:08                   ` Florian Fainelli
2018-12-05  5:47                     ` Michael Ellerman
2018-12-05 22:40                       ` Florian Fainelli
2018-12-20 15:21 ` Greg Kroah-Hartman
2018-12-20 17:38   ` Guenter Roeck
2018-12-21  4:27     ` [PATCH] Revert "serial: 8250: Default SERIAL_OF_PLATFORM to SERIAL_8250" Florian Fainelli
2018-12-21  4:28     ` [PATCH] serial: 8250: Default SERIAL_OF_PLATFORM to SERIAL_8250 Florian Fainelli
  -- strict thread matches above, loose matches on Subject: below --
2018-11-01 18:26 Florian Fainelli

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20181116011656.GA21813@roeck-us.net \
    --to=linux@roeck-us.net \
    --cc=arnd@arndb.de \
    --cc=f.fainelli@gmail.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).