From: Omar Sandoval <osandov@osandov.com>
To: Ming Lei <ming.lei@redhat.com>
Cc: Jens Axboe <axboe@kernel.dk>,
linux-block@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-mm@kvack.org, Dave Chinner <dchinner@redhat.com>,
Kent Overstreet <kent.overstreet@gmail.com>,
linux-fsdevel@vger.kernel.org,
Alexander Viro <viro@zeniv.linux.org.uk>,
Shaohua Li <shli@kernel.org>,
linux-raid@vger.kernel.org, linux-erofs@lists.ozlabs.org,
linux-btrfs@vger.kernel.org, David Sterba <dsterba@suse.com>,
"Darrick J . Wong" <darrick.wong@oracle.com>,
Gao Xiang <gaoxiang25@huawei.com>, Christoph Hellwig <hch@lst.de>,
Theodore Ts'o <tytso@mit.edu>,
linux-ext4@vger.kernel.org, Coly Li <colyli@suse.de>,
linux-bcache@vger.kernel.org, Boaz Harrosh <ooo@electrozaur.com>,
Bob Peterson <rpeterso@redhat.com>,
cluster-devel@redhat.com
Subject: Re: [PATCH V10 12/19] block: allow bio_for_each_segment_all() to iterate over multi-page bvec
Date: Thu, 15 Nov 2018 17:22:45 -0800 [thread overview]
Message-ID: <20181116012245.GG23828@vader> (raw)
In-Reply-To: <20181115085306.9910-13-ming.lei@redhat.com>
On Thu, Nov 15, 2018 at 04:52:59PM +0800, Ming Lei wrote:
> This patch introduces one extra iterator variable to bio_for_each_segment_all(),
> then we can allow bio_for_each_segment_all() to iterate over multi-page bvec.
>
> Given it is just one mechannical & simple change on all bio_for_each_segment_all()
> users, this patch does tree-wide change in one single patch, so that we can
> avoid to use a temporary helper for this conversion.
>
> Cc: Dave Chinner <dchinner@redhat.com>
> Cc: Kent Overstreet <kent.overstreet@gmail.com>
> Cc: linux-fsdevel@vger.kernel.org
> Cc: Alexander Viro <viro@zeniv.linux.org.uk>
> Cc: Shaohua Li <shli@kernel.org>
> Cc: linux-raid@vger.kernel.org
> Cc: linux-erofs@lists.ozlabs.org
> Cc: linux-btrfs@vger.kernel.org
> Cc: David Sterba <dsterba@suse.com>
> Cc: Darrick J. Wong <darrick.wong@oracle.com>
> Cc: Gao Xiang <gaoxiang25@huawei.com>
> Cc: Christoph Hellwig <hch@lst.de>
> Cc: Theodore Ts'o <tytso@mit.edu>
> Cc: linux-ext4@vger.kernel.org
> Cc: Coly Li <colyli@suse.de>
> Cc: linux-bcache@vger.kernel.org
> Cc: Boaz Harrosh <ooo@electrozaur.com>
> Cc: Bob Peterson <rpeterso@redhat.com>
> Cc: cluster-devel@redhat.com
> Signed-off-by: Ming Lei <ming.lei@redhat.com>
> ---
> block/bio.c | 27 ++++++++++++++++++---------
> block/blk-zoned.c | 1 +
> block/bounce.c | 6 ++++--
> drivers/md/bcache/btree.c | 3 ++-
> drivers/md/dm-crypt.c | 3 ++-
> drivers/md/raid1.c | 3 ++-
> drivers/staging/erofs/data.c | 3 ++-
> drivers/staging/erofs/unzip_vle.c | 3 ++-
> fs/block_dev.c | 6 ++++--
> fs/btrfs/compression.c | 3 ++-
> fs/btrfs/disk-io.c | 3 ++-
> fs/btrfs/extent_io.c | 12 ++++++++----
> fs/btrfs/inode.c | 6 ++++--
> fs/btrfs/raid56.c | 3 ++-
> fs/crypto/bio.c | 3 ++-
> fs/direct-io.c | 4 +++-
> fs/exofs/ore.c | 3 ++-
> fs/exofs/ore_raid.c | 3 ++-
> fs/ext4/page-io.c | 3 ++-
> fs/ext4/readpage.c | 3 ++-
> fs/f2fs/data.c | 9 ++++++---
> fs/gfs2/lops.c | 6 ++++--
> fs/gfs2/meta_io.c | 3 ++-
> fs/iomap.c | 6 ++++--
> fs/mpage.c | 3 ++-
> fs/xfs/xfs_aops.c | 5 +++--
> include/linux/bio.h | 11 +++++++++--
> include/linux/bvec.h | 31 +++++++++++++++++++++++++++++++
> 28 files changed, 129 insertions(+), 46 deletions(-)
>
[snip]
> diff --git a/include/linux/bio.h b/include/linux/bio.h
> index 3496c816946e..1a2430a8b89d 100644
> --- a/include/linux/bio.h
> +++ b/include/linux/bio.h
> @@ -131,12 +131,19 @@ static inline bool bio_full(struct bio *bio)
> return bio->bi_vcnt >= bio->bi_max_vecs;
> }
>
> +#define bvec_for_each_segment(bv, bvl, i, iter_all) \
> + for (bv = bvec_init_iter_all(&iter_all); \
> + (iter_all.done < (bvl)->bv_len) && \
> + ((bvec_next_segment((bvl), &iter_all)), 1); \
The parentheses around (bvec_next_segment((bvl), &iter_all)) are
unnecessary.
> + iter_all.done += bv->bv_len, i += 1)
> +
> /*
> * drivers should _never_ use the all version - the bio may have been split
> * before it got to the driver and the driver won't own all of it
> */
> -#define bio_for_each_segment_all(bvl, bio, i) \
> - for (i = 0, bvl = (bio)->bi_io_vec; i < (bio)->bi_vcnt; i++, bvl++)
> +#define bio_for_each_segment_all(bvl, bio, i, iter_all) \
> + for (i = 0, iter_all.idx = 0; iter_all.idx < (bio)->bi_vcnt; iter_all.idx++) \
> + bvec_for_each_segment(bvl, &((bio)->bi_io_vec[iter_all.idx]), i, iter_all)
Would it be possible to move i into iter_all to streamline this a bit?
> static inline void __bio_advance_iter(struct bio *bio, struct bvec_iter *iter,
> unsigned bytes, bool mp)
> diff --git a/include/linux/bvec.h b/include/linux/bvec.h
> index 01616a0b6220..02f26d2b59ad 100644
> --- a/include/linux/bvec.h
> +++ b/include/linux/bvec.h
> @@ -82,6 +82,12 @@ struct bvec_iter {
> current bvec */
> };
>
> +struct bvec_iter_all {
> + struct bio_vec bv;
> + int idx;
> + unsigned done;
> +};
> +
> /*
> * various member access, note that bio_data should of course not be used
> * on highmem page vectors
> @@ -216,6 +222,31 @@ static inline bool mp_bvec_iter_advance(const struct bio_vec *bv,
> .bi_bvec_done = 0, \
> }
>
> +static inline struct bio_vec *bvec_init_iter_all(struct bvec_iter_all *iter_all)
> +{
> + iter_all->bv.bv_page = NULL;
> + iter_all->done = 0;
> +
> + return &iter_all->bv;
> +}
> +
> +/* used for chunk_for_each_segment */
> +static inline void bvec_next_segment(const struct bio_vec *bvec,
> + struct bvec_iter_all *iter_all)
Indentation.
> +{
> + struct bio_vec *bv = &iter_all->bv;
> +
> + if (bv->bv_page) {
> + bv->bv_page += 1;
> + bv->bv_offset = 0;
> + } else {
> + bv->bv_page = bvec->bv_page;
> + bv->bv_offset = bvec->bv_offset;
> + }
> + bv->bv_len = min_t(unsigned int, PAGE_SIZE - bv->bv_offset,
> + bvec->bv_len - iter_all->done);
Indentation.
> +}
> +
> /*
> * Get the last singlepage segment from the multipage bvec and store it
> * in @seg
> --
> 2.9.5
>
next prev parent reply other threads:[~2018-11-16 1:22 UTC|newest]
Thread overview: 103+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-15 8:52 [PATCH V10 00/19] block: support multi-page bvec Ming Lei
2018-11-15 8:52 ` [PATCH V10 01/19] block: introduce multi-page page bvec helpers Ming Lei
2018-11-15 18:25 ` Omar Sandoval
2018-11-19 2:25 ` Ming Lei
2018-11-16 13:13 ` Christoph Hellwig
2018-11-19 2:23 ` Ming Lei
2018-11-19 3:10 ` Jens Axboe
2018-11-19 3:35 ` Ming Lei
2018-11-15 8:52 ` [PATCH V10 02/19] block: introduce bio_for_each_bvec() Ming Lei
2018-11-15 18:28 ` Omar Sandoval
2018-11-16 13:30 ` Christoph Hellwig
2018-11-19 3:31 ` Ming Lei
2018-11-15 8:52 ` [PATCH V10 03/19] block: use bio_for_each_bvec() to compute multi-page bvec count Ming Lei
2018-11-15 20:20 ` Omar Sandoval
2018-11-15 21:05 ` Mike Snitzer
2018-11-15 22:18 ` Omar Sandoval
2018-11-16 9:19 ` Christoph Hellwig
2018-11-16 9:41 ` Gao Xiang
2018-11-16 16:04 ` Omar Sandoval
2018-11-19 7:50 ` Ming Lei
2018-11-15 8:52 ` [PATCH V10 04/19] block: use bio_for_each_bvec() to map sg Ming Lei
2018-11-15 22:33 ` Omar Sandoval
2018-11-16 13:33 ` Christoph Hellwig
2018-11-19 7:51 ` Ming Lei
2018-11-15 8:52 ` [PATCH V10 05/19] block: introduce bvec_last_segment() Ming Lei
2018-11-15 23:23 ` Omar Sandoval
2018-11-19 7:57 ` Ming Lei
2018-11-16 13:34 ` Christoph Hellwig
2018-11-15 8:52 ` [PATCH V10 06/19] fs/buffer.c: use bvec iterator to truncate the bio Ming Lei
2018-11-16 0:20 ` Omar Sandoval
2018-11-16 13:36 ` Christoph Hellwig
2018-11-15 8:52 ` [PATCH V10 07/19] btrfs: use bvec_last_segment to get bio's last page Ming Lei
2018-11-16 0:21 ` Omar Sandoval
2018-11-16 13:37 ` Christoph Hellwig
2018-11-19 8:09 ` Ming Lei
2018-11-15 8:52 ` [PATCH V10 08/19] btrfs: move bio_pages_all() to btrfs Ming Lei
2018-11-16 0:23 ` Omar Sandoval
2018-11-19 8:15 ` Ming Lei
2018-11-16 13:38 ` Christoph Hellwig
2018-11-19 8:19 ` Ming Lei
2018-11-19 8:24 ` Christoph Hellwig
2018-11-15 8:52 ` [PATCH V10 09/19] block: introduce bio_bvecs() Ming Lei
2018-11-16 0:26 ` Omar Sandoval
2018-11-16 13:45 ` Christoph Hellwig
2018-11-19 8:21 ` Ming Lei
2018-11-20 0:49 ` Sagi Grimberg
2018-11-20 16:16 ` Christoph Hellwig
2018-11-20 20:11 ` Sagi Grimberg
2018-11-21 0:59 ` Ming Lei
2018-11-21 3:20 ` Sagi Grimberg
2018-11-21 3:44 ` Ming Lei
2018-11-21 4:25 ` Sagi Grimberg
2018-11-21 4:42 ` Sagi Grimberg
2018-11-21 5:04 ` Ming Lei
2018-11-21 5:35 ` Sagi Grimberg
2018-11-21 8:46 ` Christoph Hellwig
2018-11-21 10:19 ` Ming Lei
2018-11-15 8:52 ` [PATCH V10 10/19] block: loop: pass multi-page bvec to iov_iter Ming Lei
2018-11-16 0:40 ` Omar Sandoval
2018-11-19 8:25 ` Ming Lei
2018-11-15 8:52 ` [PATCH V10 11/19] bcache: avoid to use bio_for_each_segment_all() in bch_bio_alloc_pages() Ming Lei
2018-11-16 0:44 ` Omar Sandoval
2018-11-19 8:27 ` Ming Lei
2018-11-16 13:46 ` Christoph Hellwig
2018-11-19 8:28 ` Ming Lei
2018-11-15 8:52 ` [PATCH V10 12/19] block: allow bio_for_each_segment_all() to iterate over multi-page bvec Ming Lei
2018-11-15 12:42 ` David Sterba
2018-11-19 8:29 ` Ming Lei
2018-11-16 1:22 ` Omar Sandoval [this message]
2018-11-19 8:32 ` Ming Lei
2018-11-15 8:53 ` [PATCH V10 13/19] iomap & xfs: only account for new added page Ming Lei
2018-11-16 1:46 ` Omar Sandoval
2018-11-19 8:35 ` Ming Lei
2018-11-16 13:49 ` Christoph Hellwig
2018-11-19 8:39 ` Ming Lei
2018-11-15 8:53 ` [PATCH V10 14/19] block: enable multipage bvecs Ming Lei
2018-11-16 1:56 ` Omar Sandoval
2018-11-19 8:45 ` Ming Lei
2018-11-16 13:53 ` Christoph Hellwig
2018-11-19 9:00 ` Ming Lei
2018-11-15 8:53 ` [PATCH V10 15/19] block: always define BIO_MAX_PAGES as 256 Ming Lei
2018-11-16 1:59 ` Omar Sandoval
2018-11-19 9:04 ` Ming Lei
2018-11-20 2:45 ` Huang, Ying
2018-11-16 13:53 ` Christoph Hellwig
2018-11-15 8:53 ` [PATCH V10 16/19] block: document usage of bio iterator helpers Ming Lei
2018-11-16 2:05 ` Omar Sandoval
2018-11-15 8:53 ` [PATCH V10 17/19] block: don't use bio->bi_vcnt to figure out segment number Ming Lei
2018-11-16 2:11 ` Omar Sandoval
2018-11-19 9:06 ` Ming Lei
2018-11-16 13:55 ` Christoph Hellwig
2018-11-15 8:53 ` [PATCH V10 18/19] block: kill QUEUE_FLAG_NO_SG_MERGE Ming Lei
2018-11-16 2:18 ` Omar Sandoval
2018-11-16 13:59 ` Christoph Hellwig
2018-11-16 16:40 ` Omar Sandoval
2018-11-19 9:17 ` Ming Lei
2018-11-16 13:58 ` Christoph Hellwig
2018-11-19 9:20 ` Ming Lei
2018-11-15 8:53 ` [PATCH V10 19/19] block: kill BLK_MQ_F_SG_MERGE Ming Lei
2018-11-16 13:59 ` Christoph Hellwig
2018-11-16 16:40 ` Omar Sandoval
2018-11-16 14:03 ` [PATCH V10 00/19] block: support multi-page bvec Christoph Hellwig
2018-11-17 2:42 ` Ming Lei
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181116012245.GG23828@vader \
--to=osandov@osandov.com \
--cc=axboe@kernel.dk \
--cc=cluster-devel@redhat.com \
--cc=colyli@suse.de \
--cc=darrick.wong@oracle.com \
--cc=dchinner@redhat.com \
--cc=dsterba@suse.com \
--cc=gaoxiang25@huawei.com \
--cc=hch@lst.de \
--cc=kent.overstreet@gmail.com \
--cc=linux-bcache@vger.kernel.org \
--cc=linux-block@vger.kernel.org \
--cc=linux-btrfs@vger.kernel.org \
--cc=linux-erofs@lists.ozlabs.org \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-raid@vger.kernel.org \
--cc=ming.lei@redhat.com \
--cc=ooo@electrozaur.com \
--cc=rpeterso@redhat.com \
--cc=shli@kernel.org \
--cc=tytso@mit.edu \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).