linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Mauro Carvalho Chehab <mchehab+samsung@kernel.org>
To: Leon Romanovsky <leon@kernel.org>
Cc: Dave Jiang <dave.jiang@intel.com>,
	ksummit-discuss@lists.linuxfoundation.org,
	"linux-nvdimm@lists.01.org" <linux-nvdimm@lists.01.org>,
	vishal.l.verma@intel.com,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	zwisler@kernel.org
Subject: Re: [Ksummit-discuss] [RFC PATCH 3/3] libnvdimm, MAINTAINERS: Subsystem Profile
Date: Fri, 16 Nov 2018 03:33:17 -0800	[thread overview]
Message-ID: <20181116033258.23992cde@silica.lan> (raw)
In-Reply-To: <20181115193520.GA24359@mtr-leonro.mtl.com>

Em Thu, 15 Nov 2018 21:35:20 +0200
Leon Romanovsky <leon@kernel.org> escreveu:

> On Thu, Nov 15, 2018 at 11:09:34AM -0800, Mauro Carvalho Chehab wrote:
> > Em Thu, 15 Nov 2018 18:20:08 +0200
> > Leon Romanovsky <leon@kernel.org> escreveu:
> >  
> > > On Thu, Nov 15, 2018 at 06:10:36AM -0800, Mauro Carvalho Chehab wrote:  
> > > > Em Thu, 15 Nov 2018 09:03:11 +0100
> > > > Geert Uytterhoeven <geert@linux-m68k.org> escreveu:
> > > >  
> > > > > Hi Dan,
> > > > >
> > > > > On Thu, Nov 15, 2018 at 6:06 AM Dan Williams <dan.j.williams@intel.com> wrote:  
> > > > > > Document the basic policies of the libnvdimm subsystem and provide a
> > > > > > first example of a Subsystem Profile for others to duplicate and edit.
> > > > > >
> > > > > > Cc: Ross Zwisler <zwisler@kernel.org>
> > > > > > Cc: Vishal Verma <vishal.l.verma@intel.com>
> > > > > > Cc: Dave Jiang <dave.jiang@intel.com>
> > > > > > Signed-off-by: Dan Williams <dan.j.williams@intel.com>  
> > > > >
> > > > > Thanks for your patch!
> > > > >  
> > > > > > --- /dev/null
> > > > > > +++ b/Documentation/nvdimm/subsystem-profile.rst  
> > > > >  
> > > > > > +Trusted Reviewers
> > > > > > +-----------------
> > > > > > +Johannes Thumshirn
> > > > > > +Toshi Kani
> > > > > > +Jeff Moyer
> > > > > > +Robert Elliott  
> > > > >
> > > > > Don't you want to add email addresses?
> > > > > Only the first one is listed in MAINTAINERS.  
> > > >
> > > > IMO, it makes sense to have their e-mails here, in a way that it could
> > > > easily be parsed by get_maintainers.pl.  
> > >
> > > I personally think that list of "trusted reviewers" makes more harm than
> > > good. It creates unneeded negative feelings to those who wanted to be in
> > > this list, but for any reason they don't. Those reviewers will feel
> > > "untrusted".  
> >
> > Yeah, perhaps something like "most active reviewers" would sound
> > better.  
> 
> I would recommend to remove this section at all.
> New maintainers won't come out of blue, but will be come
> from existing community and such individuals for sure will see
> and judge by themselves to whom they trust and to whom not.

I see your point, but, on the other hand, having a list with the ones
that are actively doing reviews helps newcomers.

I would keep, but perhaps it makes sense to add some notice about a
criteria about how to be included at the "active reviewers" list,
(the criteria probably belongs to the subsystem profile), e. g. 
something like:

	"Active reviewers are developers that contribute with more than 25
	 patches per year and do more than 50 reviews per year on 
	 on patches written for drivers that they're not usual contributors" 
Cheers,
Mauro

  parent reply	other threads:[~2018-11-16 11:33 UTC|newest]

Thread overview: 61+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-11-15  4:53 [RFC PATCH 0/3] Maintainer Handbook: Subsystem Profile Dan Williams
2018-11-15  4:53 ` [RFC PATCH 1/3] MAINTAINERS: Reclaim the P: tag for " Dan Williams
2018-11-15  5:39   ` [Ksummit-discuss] " Mauro Carvalho Chehab
2018-11-15 20:12     ` Joe Perches
2018-11-15  4:53 ` [RFC PATCH 2/3] MAINTAINERS, Handbook: " Dan Williams
2018-11-15  5:48   ` [Ksummit-discuss] " Julia Lawall
2018-11-15  7:59     ` Geert Uytterhoeven
2018-11-15 13:47       ` Julia Lawall
2018-11-16 12:44         ` Jani Nikula
2018-11-16 17:56           ` Joe Perches
2018-11-17 14:12             ` Rob Herring
2018-11-17 17:03               ` Julia Lawall
2018-11-20  7:28             ` Jani Nikula
2018-11-15  5:49   ` Mauro Carvalho Chehab
2018-11-15  7:58   ` Geert Uytterhoeven
2018-11-15  8:38   ` Jani Nikula
2018-11-15 18:03     ` Tim.Bird
2018-11-15 23:56     ` Tobin C. Harding
2018-11-15 15:44   ` Mauro Carvalho Chehab
2018-11-16 23:28     ` Randy Dunlap
2018-11-17 11:57     ` Hans Verkuil
2018-11-16  0:11   ` Frank Rowand
2018-11-16 12:04     ` Mauro Carvalho Chehab
2018-11-16 18:57       ` Dan Williams
2018-11-18 12:58         ` Mauro Carvalho Chehab
2018-11-18 17:31           ` Dan Williams
2018-11-18 17:31             ` Dan Williams
2018-11-18 17:34               ` Dan Williams
2018-11-18 17:44                 ` Mauro Carvalho Chehab
2018-11-16 16:47     ` Frank Rowand
2018-11-15  4:53 ` [RFC PATCH 3/3] libnvdimm, MAINTAINERS: " Dan Williams
2018-11-15  8:03   ` [Ksummit-discuss] " Geert Uytterhoeven
2018-11-15 14:10     ` Mauro Carvalho Chehab
2018-11-15 16:20       ` Leon Romanovsky
2018-11-15 19:09         ` Mauro Carvalho Chehab
2018-11-15 19:35           ` Leon Romanovsky
2018-11-15 19:40             ` Luck, Tony
2018-11-15 19:43               ` Joe Perches
2018-11-16 11:39                 ` Mauro Carvalho Chehab
2018-11-18  7:12                   ` Leon Romanovsky
2018-11-16 11:33             ` Mauro Carvalho Chehab [this message]
2018-11-16 12:00               ` Jan Kara
2018-11-18  7:00               ` Leon Romanovsky
2018-11-16 20:36         ` Rodrigo Vivi
2018-11-16 23:44           ` Dan Williams
2018-11-17  0:38             ` NeilBrown
2018-11-18 13:11               ` Mauro Carvalho Chehab
2018-11-18 13:03             ` Mauro Carvalho Chehab
2018-11-20  8:10               ` Jani Nikula
2018-11-20 19:31                 ` Dan Williams
2018-11-26 11:12                 ` Mauro Carvalho Chehab
2018-11-26 15:55                   ` Joe Perches
2018-11-16 19:13     ` Dan Williams
2018-11-15 14:30   ` Mauro Carvalho Chehab
2018-11-15 14:51     ` Julia Lawall
2018-11-16 19:20     ` Dan Williams
2018-11-16  2:58   ` y-goto
2018-11-17  0:32   ` [Ksummit-discuss] " David Woodhouse
2018-11-15  5:56 ` [RFC PATCH 0/3] Maintainer Handbook: " Mauro Carvalho Chehab
2018-11-25 10:57 ` Pavel Machek
2018-11-25 20:55   ` Dan Williams

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20181116033258.23992cde@silica.lan \
    --to=mchehab+samsung@kernel.org \
    --cc=dave.jiang@intel.com \
    --cc=ksummit-discuss@lists.linuxfoundation.org \
    --cc=leon@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-nvdimm@lists.01.org \
    --cc=vishal.l.verma@intel.com \
    --cc=zwisler@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).