From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=DKIMWL_WL_MED,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS, URIBL_BLOCKED,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C3866C43441 for ; Fri, 16 Nov 2018 16:40:36 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 88AC620684 for ; Fri, 16 Nov 2018 16:40:36 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=osandov-com.20150623.gappssmtp.com header.i=@osandov-com.20150623.gappssmtp.com header.b="aB4svGZ9" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 88AC620684 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=osandov.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2390274AbeKQCxk (ORCPT ); Fri, 16 Nov 2018 21:53:40 -0500 Received: from mail-pf1-f196.google.com ([209.85.210.196]:40985 "EHLO mail-pf1-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2390242AbeKQCxh (ORCPT ); Fri, 16 Nov 2018 21:53:37 -0500 Received: by mail-pf1-f196.google.com with SMTP id e22-v6so11647587pfn.8 for ; Fri, 16 Nov 2018 08:40:31 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=osandov-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=2UIrJLU44vLfyM1GaYdgYb8aFp1tVp8wrSUZpBwp96A=; b=aB4svGZ9OFckPOMSQl095156w9SKLCbC7XiIVLgOnRsJM2+Lu5ln3wjnKRyMtMPe7b oj86T/T8OQMh0LFDqCDd0aynQvY5eBRj0La5PQce+zyuWJQaSNe/Bsv/WKijc50ELDGA yAwfssofJsqDbUc94Rg7YHiC6vutqOGuVSXnmeuuYCTUJ0KTDKR1AN7Xqj0BAtBEMBoJ b0kuMUEPHSeZAx4rvZZnmSglXChKVJz4t/iCg+7qcWRpDiwus46kutTn2NqPIT/ZD7BG fClNkdZeyRvD+z6dbFYbobwlR1AxPt7Dbl9ANQzOfTXR5EnfAvvQdi9AGmw3pihcU542 qNGA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=2UIrJLU44vLfyM1GaYdgYb8aFp1tVp8wrSUZpBwp96A=; b=KbSHKNNYSplDVNBKGSwTqMpMgvyutD0pmqRQuh8B7o6t54P0HnpfC1engIQKJImc6K +vmP0oZKSsrrNTLb2v8iemmFsLJMSgHB6/wZCbrh3X5qTn81yXmelultlAgQpTLZ60U/ PdJfQI/JJYSG9DNTbHy/vQNfeXd7uF0PxOw/xgOAP5sfxdmYK8PZqvhqiITgsl7uWn6S O6SbA+fQGXt+IlqHca+GPjXPJ+Sr9XbEAby3okTRJxzdvwouG2HTmeeMcbLg+D4Ga9cF ykFeuy84VWn0GNr6+Kzap4ipG832FY4E9g1fgOi3k5UpdzCoSN5W8jhEjEEnauM+eohy zWTA== X-Gm-Message-State: AGRZ1gJ2sGZXiV3bqHDQS+AClI3nhDUMT4RxJoU584xAxX+aNVdWByyZ IYqYg3y7xu18QVdD86xHd6doWo0RuYiwhSyT X-Google-Smtp-Source: AJdET5f+s9XT96L6c7XnPZBglWcnGckfH8lsTWflIPtLsRqj3xUKDT2yZwzel9Bs+QmGOb2aTPeQtg== X-Received: by 2002:a63:164d:: with SMTP id 13-v6mr10678635pgw.103.1542386431231; Fri, 16 Nov 2018 08:40:31 -0800 (PST) Received: from vader ([64.114.255.114]) by smtp.gmail.com with ESMTPSA id r6-v6sm41944759pfk.157.2018.11.16.08.40.30 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Fri, 16 Nov 2018 08:40:30 -0800 (PST) Date: Fri, 16 Nov 2018 08:40:28 -0800 From: Omar Sandoval To: Christoph Hellwig Cc: Ming Lei , Jens Axboe , linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, Dave Chinner , Kent Overstreet , Mike Snitzer , dm-devel@redhat.com, Alexander Viro , linux-fsdevel@vger.kernel.org, Shaohua Li , linux-raid@vger.kernel.org, linux-erofs@lists.ozlabs.org, David Sterba , linux-btrfs@vger.kernel.org, "Darrick J . Wong" , linux-xfs@vger.kernel.org, Gao Xiang , Theodore Ts'o , linux-ext4@vger.kernel.org, Coly Li , linux-bcache@vger.kernel.org, Boaz Harrosh , Bob Peterson , cluster-devel@redhat.com Subject: Re: [PATCH V10 18/19] block: kill QUEUE_FLAG_NO_SG_MERGE Message-ID: <20181116164028.GW23828@vader> References: <20181115085306.9910-1-ming.lei@redhat.com> <20181115085306.9910-19-ming.lei@redhat.com> <20181116021811.GM23828@vader> <20181116135922.GO3165@lst.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20181116135922.GO3165@lst.de> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Nov 16, 2018 at 02:59:22PM +0100, Christoph Hellwig wrote: > On Thu, Nov 15, 2018 at 06:18:11PM -0800, Omar Sandoval wrote: > > This commit message wasn't very clear. Is it the case that > > QUEUE_FLAG_NO_SG_MERGE is no longer set by any drivers? > > I think he wants to say that not doing S/G merging is rather pointless > with the current setup of the I/O path, as it isn't going to save > you a significant amount of cycles. Okay, that makes sense. Ming, you can add Reviewed-by: Omar Sandoval