* [PATCH 1/7] Staging: iio: adt7316: Set the data field
@ 2018-11-16 22:49 Shreeya Patel
2018-11-17 16:59 ` Jonathan Cameron
0 siblings, 1 reply; 2+ messages in thread
From: Shreeya Patel @ 2018-11-16 22:49 UTC (permalink / raw)
To: lars, Michael.Hennerich, jic23, knaack.h, pmeerw, gregkh,
linux-iio, devel, linux-kernel
adt7316_i2c_read function nowhere sets the data field.
It is necessary to have an appropriate value for it.
Hence, assign the value stored in 'ret' variable to data field.
Signed-off-by: Shreeya Patel <shreeya.patel23498@gmail.com>
---
drivers/staging/iio/addac/adt7316-i2c.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/staging/iio/addac/adt7316-i2c.c b/drivers/staging/iio/addac/adt7316-i2c.c
index f66dd3ebbab1..856bcfa60c6c 100644
--- a/drivers/staging/iio/addac/adt7316-i2c.c
+++ b/drivers/staging/iio/addac/adt7316-i2c.c
@@ -35,6 +35,8 @@ static int adt7316_i2c_read(void *client, u8 reg, u8 *data)
return ret;
}
+ *data = ret;
+
return 0;
}
--
2.17.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH 1/7] Staging: iio: adt7316: Set the data field
2018-11-16 22:49 [PATCH 1/7] Staging: iio: adt7316: Set the data field Shreeya Patel
@ 2018-11-17 16:59 ` Jonathan Cameron
0 siblings, 0 replies; 2+ messages in thread
From: Jonathan Cameron @ 2018-11-17 16:59 UTC (permalink / raw)
To: Shreeya Patel
Cc: lars, Michael.Hennerich, knaack.h, pmeerw, gregkh, linux-iio,
devel, linux-kernel
On Sat, 17 Nov 2018 04:19:07 +0530
Shreeya Patel <shreeya.patel23498@gmail.com> wrote:
> adt7316_i2c_read function nowhere sets the data field.
> It is necessary to have an appropriate value for it.
> Hence, assign the value stored in 'ret' variable to data field.
>
> Signed-off-by: Shreeya Patel <shreeya.patel23498@gmail.com>
I have amended the description slightly to make it clear this
is a fix and that it has been broken so long we aren't that
bothered about it going into stable!
Applied to the togreg branch of iio.git and pushed out as
testing for the autobuilders to play with it.
Thanks,
Jonathan
> ---
> drivers/staging/iio/addac/adt7316-i2c.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/staging/iio/addac/adt7316-i2c.c b/drivers/staging/iio/addac/adt7316-i2c.c
> index f66dd3ebbab1..856bcfa60c6c 100644
> --- a/drivers/staging/iio/addac/adt7316-i2c.c
> +++ b/drivers/staging/iio/addac/adt7316-i2c.c
> @@ -35,6 +35,8 @@ static int adt7316_i2c_read(void *client, u8 reg, u8 *data)
> return ret;
> }
>
> + *data = ret;
> +
> return 0;
> }
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-11-17 16:59 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-11-16 22:49 [PATCH 1/7] Staging: iio: adt7316: Set the data field Shreeya Patel
2018-11-17 16:59 ` Jonathan Cameron
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).