linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Pavel Machek <pavel@ucw.cz>
To: Sebastian Reichel <sebastian.reichel@collabora.com>
Cc: Sebastian Reichel <sre@kernel.org>,
	Tomi Valkeinen <tomi.valkeinen@ti.com>,
	Tony Lindgren <tony@atomide.com>,
	Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
	"H. Nikolaus Schaller" <hns@goldelico.com>,
	dri-devel@lists.freedesktop.org, linux-omap@vger.kernel.org,
	linux-kernel@vger.kernel.org, kernel@collabora.com
Subject: Re: [PATCHv4 3/6] drm/omap: don't check dispc timings for DSI
Date: Sat, 17 Nov 2018 22:04:25 +0100	[thread overview]
Message-ID: <20181117210425.GD22813@amd> (raw)
In-Reply-To: <20181115230645.15748-4-sebastian.reichel@collabora.com>

[-- Attachment #1: Type: text/plain, Size: 979 bytes --]

On Fri 2018-11-16 00:06:42, Sebastian Reichel wrote:
> While all display types only forward their VM to the DISPC, this

"While most?"

> is not true for DSI. DSI calculates the VM for DISPC based on its
> own, but its not identical. Actually the DSI VM is not even a valid

"but it is not"

> DISPC VM making this check fail. Let's restore the old behaviour
> and avoid checking the DISPC VM for DSI here.
> 
> Fixes: 7c27fa57ef31 ("drm/omap: Call dispc timings check operation directly")
> Signed-off-by: Sebastian Reichel <sebastian.reichel@collabora.com>

Acked-by: Pavel Machek <pavel@ucw.cz>

With the fixes tag, stable is going to pick this up. Do we want this
in stable?

I believe stable does not need it as it is not going to get manually
updated display support, anyway?

Best regards,
									Pavel

-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 181 bytes --]

  reply	other threads:[~2018-11-17 21:04 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-11-15 23:06 [PATCHv4 0/6] omapdrm: DSI command mode panel support Sebastian Reichel
2018-11-15 23:06 ` [PATCHv4 1/6] drm/omap: use DRM_DEBUG_DRIVER instead of CORE Sebastian Reichel
2018-11-17 21:01   ` Pavel Machek
2018-11-15 23:06 ` [PATCHv4 2/6] drm/omap: populate DSI platform bus earlier Sebastian Reichel
2018-11-17 21:02   ` Pavel Machek
2018-11-15 23:06 ` [PATCHv4 3/6] drm/omap: don't check dispc timings for DSI Sebastian Reichel
2018-11-17 21:04   ` Pavel Machek [this message]
2018-11-15 23:06 ` [PATCHv4 4/6] drm/omap: fix incorrect union usage Sebastian Reichel
2018-11-16 13:41   ` Tomi Valkeinen
2018-11-16 22:36     ` Sebastian Reichel
2018-11-15 23:06 ` [PATCHv4 5/6] drm/omap: add framedone interrupt support Sebastian Reichel
2018-11-17 21:08   ` Pavel Machek
2018-11-19 12:05     ` Sebastian Reichel
2018-11-19 12:12       ` Pavel Machek
2018-11-15 23:06 ` [PATCHv4 6/6] drm/omap: add support for manually updated displays Sebastian Reichel
2018-11-17 21:16   ` Pavel Machek
2018-11-16 22:09 ` [PATCHv4 0/6] omapdrm: DSI command mode panel support Tony Lindgren
2018-11-17 21:00 ` Pavel Machek

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20181117210425.GD22813@amd \
    --to=pavel@ucw.cz \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=hns@goldelico.com \
    --cc=kernel@collabora.com \
    --cc=laurent.pinchart@ideasonboard.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-omap@vger.kernel.org \
    --cc=sebastian.reichel@collabora.com \
    --cc=sre@kernel.org \
    --cc=tomi.valkeinen@ti.com \
    --cc=tony@atomide.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).