From: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
To: Roberto Sassu <roberto.sassu@huawei.com>
Cc: zohar@linux.ibm.com, david.safford@ge.com, monty.wiseman@ge.com,
linux-integrity@vger.kernel.org,
linux-security-module@vger.kernel.org,
linux-kernel@vger.kernel.org, silviu.vlasceanu@huawei.com
Subject: Re: [PATCH v5 7/7] tpm: pass an array of tpm_bank_list structures to tpm_pcr_extend()
Date: Sun, 18 Nov 2018 09:27:45 +0200 [thread overview]
Message-ID: <20181118072745.GA5897@linux.intel.com> (raw)
In-Reply-To: <9c534ed1-7832-7a3b-3e69-5fcc25c565cc@huawei.com>
On Fri, Nov 16, 2018 at 04:55:36PM +0100, Roberto Sassu wrote:
> On 11/16/2018 4:03 PM, Jarkko Sakkinen wrote:
> > On Wed, Nov 14, 2018 at 04:31:08PM +0100, Roberto Sassu wrote:
> > > Currently, tpm_pcr_extend() accepts as an input only a SHA1 digest.
> > >
> > > This patch modifies the definition of tpm_pcr_extend() to allow other
> > > kernel subsystems to pass a digest for each algorithm supported by the TPM.
> > > All digests are processed by the TPM in one operation.
> > >
> > > If a tpm_pcr_extend() caller provides a subset of the supported algorithms,
> > > the TPM driver extends the remaining PCR banks with the first digest
> > > passed as an argument to the function.
> >
> > What is the legit use case for this?
>
> A subset could be chosen for better performance, or when a TPM algorithm
> is not supported by the crypto subsystem.
Doesn't extending a subset a security concern?
/Jarkko
next prev parent reply other threads:[~2018-11-18 7:27 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-14 15:31 [PATCH v5 0/7] tpm: retrieve digest size of unknown algorithms from TPM Roberto Sassu
2018-11-14 15:31 ` [PATCH v5 1/7] tpm: dynamically allocate the allocated_banks array Roberto Sassu
2018-11-16 13:36 ` Jarkko Sakkinen
2018-11-14 15:31 ` [PATCH v5 2/7] tpm: remove definition of TPM2_ACTIVE_PCR_BANKS Roberto Sassu
2018-11-16 13:38 ` Jarkko Sakkinen
2018-11-28 7:50 ` Roberto Sassu
2018-11-28 12:17 ` Roberto Sassu
2018-11-29 12:04 ` Roberto Sassu
2018-11-30 19:41 ` Jarkko Sakkinen
2018-11-30 19:45 ` Jarkko Sakkinen
2018-11-30 22:18 ` Jarkko Sakkinen
2018-12-03 9:59 ` Roberto Sassu
2018-12-03 17:31 ` Jarkko Sakkinen
2018-11-14 15:31 ` [PATCH v5 3/7] tpm: rename and export tpm2_digest and tpm2_algorithms Roberto Sassu
2018-11-14 15:31 ` [PATCH v5 4/7] tpm: modify tpm_pcr_read() definition to pass a TPM hash algorithm Roberto Sassu
2018-11-16 13:41 ` Jarkko Sakkinen
2018-11-14 15:31 ` [PATCH v5 5/7] tpm: retrieve digest size of unknown algorithms with PCR read Roberto Sassu
2018-11-14 15:31 ` [PATCH v5 6/7] tpm: ensure that the output of PCR read contains the correct digest size Roberto Sassu
2018-11-16 13:41 ` Jarkko Sakkinen
2018-11-16 16:06 ` Roberto Sassu
2018-11-18 7:32 ` Jarkko Sakkinen
2018-11-19 8:14 ` Roberto Sassu
2018-11-19 14:33 ` Jarkko Sakkinen
2018-11-19 15:09 ` Roberto Sassu
2018-11-19 16:07 ` Jarkko Sakkinen
2018-11-28 8:40 ` Roberto Sassu
2018-11-28 19:19 ` Jarkko Sakkinen
2018-11-14 15:31 ` [PATCH v5 7/7] tpm: pass an array of tpm_bank_list structures to tpm_pcr_extend() Roberto Sassu
2018-11-16 15:03 ` Jarkko Sakkinen
2018-11-16 15:55 ` Roberto Sassu
2018-11-18 7:27 ` Jarkko Sakkinen [this message]
2018-11-19 4:57 ` Mimi Zohar
2018-11-19 8:16 ` Roberto Sassu
2018-11-19 14:33 ` Mimi Zohar
2018-11-19 14:39 ` Jarkko Sakkinen
2018-11-18 7:29 ` Jarkko Sakkinen
2018-11-19 8:22 ` Roberto Sassu
2018-11-19 14:42 ` Jarkko Sakkinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181118072745.GA5897@linux.intel.com \
--to=jarkko.sakkinen@linux.intel.com \
--cc=david.safford@ge.com \
--cc=linux-integrity@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-security-module@vger.kernel.org \
--cc=monty.wiseman@ge.com \
--cc=roberto.sassu@huawei.com \
--cc=silviu.vlasceanu@huawei.com \
--cc=zohar@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).