From: Peter Zijlstra <peterz@infradead.org>
To: luca abeni <luca.abeni@santannapisa.it>
Cc: Thomas Gleixner <tglx@linutronix.de>,
syzbot <syzbot+119ba87189432ead09b4@syzkaller.appspotmail.com>,
Borislav Petkov <bp@alien8.de>, "H. Peter Anvin" <hpa@zytor.com>,
LKML <linux-kernel@vger.kernel.org>,
Andy Lutomirski <luto@kernel.org>,
mingo@redhat.com, syzkaller-bugs@googlegroups.com,
x86@kernel.org, Juri Lelli <juri.lelli@redhat.com>,
Daniel Bristot de Oliveira <bristot@redhat.com>
Subject: Re: WARNING in enqueue_task_dl
Date: Mon, 19 Nov 2018 13:52:41 +0100 [thread overview]
Message-ID: <20181119125241.GC9761@hirez.programming.kicks-ass.net> (raw)
In-Reply-To: <20181119130718.69eddf46@luca64>
On Mon, Nov 19, 2018 at 01:07:18PM +0100, luca abeni wrote:
> > On Sun, 18 Nov 2018, syzbot wrote:
> > > WARNING: CPU: 1 PID: 6351 at kernel/sched/deadline.c:628
> > > enqueue_task_dl+0x22da/0x38a0 kernel/sched/deadline.c:1504
>
> Here, it looks like a task is invoking sched_setattr() to become
> SCHED_DEADLINE when dl_boosted is set...
>
> Is this possible / correct?
Possible, clearly. Correct, only in so far as that it is not a malformed
program, but it is very poor design to actually trigger this (of course
the fuzzer doesn't care about that).
> If this (sched_setattr() with dl_boosted set) should not be possible,
> then we have a bug that we need to investigate...
>
> Otherwise, I suspect we can just remove the WARN_ON at line 628 of
> deadline.c
I wonder why we put that WARN in there to begin with... git-blame gives
us:
98b0a8578050 ("sched/deadline: Remove useless parameter from setup_new_dl_entity()")
So the problem seems to be that if we're boosted, we should maybe not be
using our own (newly set) parameters, but those of the donor task.
Specifically, our 'suboptimal' deadline inheritance scheme 'requires' us
to use the inherited deadline, not our own. So in that respect I think
the WARN is valid, although I'm not sure what, apart from actually
finishing that PE patch-set we can do about it just now.
next prev parent reply other threads:[~2018-11-19 12:52 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-18 18:49 WARNING in enqueue_task_dl syzbot
2018-11-19 8:23 ` Thomas Gleixner
2018-11-19 10:34 ` Peter Zijlstra
2018-11-19 12:07 ` luca abeni
2018-11-19 12:52 ` Peter Zijlstra [this message]
2018-11-19 13:43 ` Juri Lelli
2018-11-19 15:32 ` Juri Lelli
2019-01-07 16:19 ` Daniel Bristot de Oliveira
2019-02-07 9:35 ` Dmitry Vyukov
2019-07-24 4:45 ` Eric Biggers
2020-06-16 6:53 ` Daniel Wagner
2020-06-16 8:20 ` Peter Zijlstra
2020-06-23 7:19 ` [tip: sched/urgent] sched/core: Fix PI boosting between RT and DEADLINE tip-bot2 for Juri Lelli
2020-06-23 8:48 ` [tip: sched/urgent] sched/core: Fix PI boosting between RT and DEADLINE tasks tip-bot2 for Juri Lelli
2018-12-31 15:02 ` WARNING in enqueue_task_dl syzbot
2019-01-02 9:15 ` luca abeni
2019-01-07 7:46 ` Juri Lelli
2019-03-20 17:08 ` syzbot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181119125241.GC9761@hirez.programming.kicks-ass.net \
--to=peterz@infradead.org \
--cc=bp@alien8.de \
--cc=bristot@redhat.com \
--cc=hpa@zytor.com \
--cc=juri.lelli@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=luca.abeni@santannapisa.it \
--cc=luto@kernel.org \
--cc=mingo@redhat.com \
--cc=syzbot+119ba87189432ead09b4@syzkaller.appspotmail.com \
--cc=syzkaller-bugs@googlegroups.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).